[PATCH] Compiling DOT_X_FILES requires version.h

[PATCH] Compiling DOT_X_FILES requires version.h

[Yan Li]

[-- Attachment #1: Type: text/plain, Size: 1298 bytes --]

There was a race condition when building Guile since DOT_X_FILES didn't
depend on version.h, which is dynamically generated. Sometimes the
DOT_X_FILES are compiled before the version.h is generated and leads to
build failure. This patch fixed this problem.

Signed-off-by: Yan Li <yan.i.li@intel.com>
---
 libguile/Makefile.am |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/libguile/Makefile.am b/libguile/Makefile.am
index a899b85..9836aa1 100644
--- a/libguile/Makefile.am
+++ b/libguile/Makefile.am
@@ -670,7 +670,7 @@ AM_V_FILTER_0 = @echo "  FILTER" $@;
 .c.doc:
 	-$(AM_V_FILTER)$(AWK) -f $(srcdir)/guile-func-name-check $< && (./guile-snarf-docs $(snarfcppopts) $< | ./guile_filter_doc_snarfage$(EXEEXT) --filter-snarfage) > $@ || { rm $@; false; }
 
-$(DOT_X_FILES) $(EXTRA_DOT_X_FILES): scmconfig.h snarf.h guile-snarf.in
+$(DOT_X_FILES) $(EXTRA_DOT_X_FILES): scmconfig.h snarf.h guile-snarf.in version.h
 
 $(DOT_DOC_FILES) $(EXTRA_DOT_DOC_FILES): scmconfig.h snarf.h guile-snarf-docs.in guile_filter_doc_snarfage$(EXEEXT)
 
-- 
1.7.1


-- 
Best regards,
Li, Yan

MeeGo Team, Opensource Technology Center, SSG, Intel
Office tel.: +86-10-82171695 (inet: 8-758-1695)
OpenPGP key: 5C6C31EF
IRC: yanli on network irc.freenode.net

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] Compiling DOT_X_FILES requires version.h

[Andy Wingo]

On Wed 04 Aug 2010 09:02, Yan Li <yan.i.li@intel.com> writes:

> There was a race condition when building Guile since DOT_X_FILES didn't
> depend on version.h, which is dynamically generated. Sometimes the
> DOT_X_FILES are compiled before the version.h is generated and leads to
> build failure. This patch fixed this problem.

Applied. Thanks!

Andy
-- 
http://wingolog.org/