From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.bugs,gmane.comp.lib.gnulib.bugs Subject: Re: -Wundef warning in striconveh.h Date: Thu, 17 Mar 2011 15:46:20 +0100 Message-ID: References: <4D82151D.50303@redhat.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1300373955 579 80.91.229.12 (17 Mar 2011 14:59:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 17 Mar 2011 14:59:15 +0000 (UTC) Cc: bug-guile@gnu.org, bug-gnulib@gnu.org To: Eric Blake Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Thu Mar 17 15:59:10 2011 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0EfL-00057t-K4 for guile-bugs@m.gmane.org; Thu, 17 Mar 2011 15:59:10 +0100 Original-Received: from localhost ([127.0.0.1]:48438 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q0EfI-0001ew-Sa for guile-bugs@m.gmane.org; Thu, 17 Mar 2011 10:59:04 -0400 Original-Received: from [140.186.70.92] (port=47733 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q0ESx-0001z1-57 for bug-guile@gnu.org; Thu, 17 Mar 2011 10:46:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q0ESv-0005TW-UO for bug-guile@gnu.org; Thu, 17 Mar 2011 10:46:18 -0400 Original-Received: from a-pb-sasl-sd.pobox.com ([64.74.157.62]:46767 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q0ESt-0005Sx-8Q; Thu, 17 Mar 2011 10:46:15 -0400 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTP id 3EB6B4E3F; Thu, 17 Mar 2011 10:47:48 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=CY3bmn8pmX2gbIWOIuzB16HofRE=; b=k0qLjz jJ9Uk03bcYP2cpvQm3NS8xCPKVF4dBuGNJSTOatTliZMaVDVGov0un3sduCSp5AW Wm9XDxsrJq19L1DjVH2kB+tC70jTlPCJma0pi0meKb4T4Xk9gCGxJcPt+wcRxsGQ Wg4GXbemPzcFF8fZ/nMZzGrnd9c31vpAAYNzU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=KnyZtpnE8kl105MvDwibkX1fXHKiY9Nh KeLJxzn6P/Ja47IRu8dQDEST04jkrFS/h85BovynL9yOMVZ1lnjX7yDZdRm0x6hY 44a6EAo9Ak8UZrfF5A8MO1FyQLElsRNlHS2K2A6bgvziznB2+GFQV/2SWm+Pvzpl 3kLtC4pZ5wU= Original-Received: from a-pb-sasl-sd.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTP id 19CE94E33; Thu, 17 Mar 2011 10:47:45 -0400 (EDT) Original-Received: from unquote.localdomain (unknown [90.164.198.39]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTPSA id 342964E2B; Thu, 17 Mar 2011 10:47:41 -0400 (EDT) In-Reply-To: <4D82151D.50303@redhat.com> (Eric Blake's message of "Thu, 17 Mar 2011 08:05:17 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) X-Pobox-Relay-ID: 84DE4DC2-50A5-11E0-99CC-E8AB60295C12-02397024!a-pb-sasl-sd.pobox.com X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 64.74.157.62 X-BeenThere: bug-guile@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.bugs:5333 gmane.comp.lib.gnulib.bugs:25675 Archived-At: Hi Eric, On Thu 17 Mar 2011 15:05, Eric Blake writes: > On 03/17/2011 04:20 AM, Andy Wingo wrote: >> striconveh.h:22 and striconveh.h:34 use #if when they should use #ifdef, >> or something. > > Not a bug in gnulib, > >> >> Building Guile a contributor got this warning: > > but in guile. Gnulib specifically documents that -Wundef is > incompatible with gnulib modules, and that our coding style is > deliberate. -Wundef only catches portability problems for ancient > (non-C89) compilers, and gnulib requires C89 as a bare minimum. While > you are free to use it for the rest of your project, you need to avoid > it while compiling gnulib (or at least ignore the warnings and avoid > -Werror). This error did not occur while compiling gnulib (in the lib/) directory, but rather libguile, which included striconveh.h. I believe we already follow your suggestions for building gnulib itself. Can you consider changing this one header file? It does not sound like an issue on which it is fruitful to be stubborn. See also this thread also: http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/24225 Do you have a response to Ludovic's concerns in his second message? Regards, Andy -- http://wingolog.org/