From: Andy Wingo <wingo@pobox.com>
To: Eric Blake <eblake@redhat.com>
Cc: bug-guile@gnu.org, bug-gnulib@gnu.org
Subject: Re: -Wundef warning in striconveh.h
Date: Thu, 17 Mar 2011 15:46:20 +0100 [thread overview]
Message-ID: <m3wrjxztxf.fsf@unquote.localdomain> (raw)
In-Reply-To: <4D82151D.50303@redhat.com> (Eric Blake's message of "Thu, 17 Mar 2011 08:05:17 -0600")
Hi Eric,
On Thu 17 Mar 2011 15:05, Eric Blake <eblake@redhat.com> writes:
> On 03/17/2011 04:20 AM, Andy Wingo wrote:
>> striconveh.h:22 and striconveh.h:34 use #if when they should use #ifdef,
>> or something.
>
> Not a bug in gnulib,
>
>>
>> Building Guile a contributor got this warning:
>
> but in guile. Gnulib specifically documents that -Wundef is
> incompatible with gnulib modules, and that our coding style is
> deliberate. -Wundef only catches portability problems for ancient
> (non-C89) compilers, and gnulib requires C89 as a bare minimum. While
> you are free to use it for the rest of your project, you need to avoid
> it while compiling gnulib (or at least ignore the warnings and avoid
> -Werror).
This error did not occur while compiling gnulib (in the lib/) directory,
but rather libguile, which included striconveh.h. I believe we already
follow your suggestions for building gnulib itself.
Can you consider changing this one header file? It does not sound like
an issue on which it is fruitful to be stubborn.
See also this thread also:
http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/24225
Do you have a response to Ludovic's concerns in his second message?
Regards,
Andy
--
http://wingolog.org/
next prev parent reply other threads:[~2011-03-17 14:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 10:20 -Wundef warning in striconveh.h Andy Wingo
2011-03-17 14:05 ` Eric Blake
2011-03-17 14:46 ` Andy Wingo [this message]
2011-03-17 16:15 ` Paul Eggert
2011-03-17 17:03 ` Andy Wingo
2011-04-25 21:35 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3wrjxztxf.fsf@unquote.localdomain \
--to=wingo@pobox.com \
--cc=bug-gnulib@gnu.org \
--cc=bug-guile@gnu.org \
--cc=eblake@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).