From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.bugs Subject: Re: find-versioned-module bugs Date: Thu, 10 Jun 2010 14:23:13 +0200 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1276172733 8069 80.91.229.12 (10 Jun 2010 12:25:33 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 10 Jun 2010 12:25:33 +0000 (UTC) Cc: bug-guile To: Julian Graham Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Thu Jun 10 14:25:31 2010 connect(): No such file or directory Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OMgp7-000646-QY for guile-bugs@m.gmane.org; Thu, 10 Jun 2010 14:25:30 +0200 Original-Received: from localhost ([127.0.0.1]:46691 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMgp7-0003JQ-9D for guile-bugs@m.gmane.org; Thu, 10 Jun 2010 08:25:29 -0400 Original-Received: from [140.186.70.92] (port=58608 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMgoz-0003HX-Ka for bug-guile@gnu.org; Thu, 10 Jun 2010 08:25:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OMgoy-00066M-B8 for bug-guile@gnu.org; Thu, 10 Jun 2010 08:25:21 -0400 Original-Received: from a-pb-sasl-quonix.pobox.com ([208.72.237.25]:34744 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMgoy-00066H-8G for bug-guile@gnu.org; Thu, 10 Jun 2010 08:25:20 -0400 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id 265E71FC2; Thu, 10 Jun 2010 08:25:20 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=Lu7fICHFrcq3 y5MYwjdgs/RIJBY=; b=fill38sUfwa7hXZl1Jh0dvlGwETaqxl+bQZCe9W/rmNw 6shIRXMVKk8MJuIDkRyDDQims0Tc8QR40BHc/98ixU0U9v9RjhNJUYB4cZspait2 cfsSviZnuP2WV9MtqpWeRXXJfNKeFxzfiiX669iQ2LmRFA2c4qAiogscWfhJHq4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=LEfdU2 NAKTPMqghqV4aGQIwXVeRk4YjkHwMLGZqrTEOgtsoV5FaJmhzTYNd13xoqzVRnjk jwYi7hXHZKCbJrJ1WRz9U4zbmM3mqre820j9Oqkts5AjsNz1za2Bjpn/KFpepWL+ SWjAZnRfYYeG/WKgjnmEKjYfiZEtzXCjvQM4Q= Original-Received: from a-pb-sasl-quonix. (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id 140951FC1; Thu, 10 Jun 2010 08:25:19 -0400 (EDT) Original-Received: from unquote (unknown [88.17.129.247]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTPSA id 4C8C01FC0; Thu, 10 Jun 2010 08:25:16 -0400 (EDT) In-Reply-To: (Julian Graham's message of "Thu, 10 Jun 2010 00:25:14 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.92 (gnu/linux) X-Pobox-Relay-ID: 3B6ABFDC-748B-11DF-9E8E-9056EE7EF46B-02397024!a-pb-sasl-quonix.pobox.com X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: bug-guile@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.bugs:4642 Archived-At: On Thu 10 Jun 2010 06:25, Julian Graham writes: >>> As you see this function is preferring modules from the end of the >>> %load-path. In addition it has adds an unnecessary "/". Do you have time >>> to fix it? :) >> >> Eep! =C2=A0Sure, I'll try to take a look this evening. > > Fixed! See commit dc232ed059a0af5955d21f077da88af6fdc562a0. Thanks! Now, a further request, which you may turn down of course :-). This function currently looks in all dirs in the load path for all ways that versions can be represented, hence the stat explosion. Instead of enumerating the entire set of compatible modules, why not simply stop with the first one? I suspect this would respect the user's expectations just as well. What do you think? :) Andy --=20 http://wingolog.org/