From: Andy Wingo <wingo@pobox.com>
To: Julian Graham <joolean@gmail.com>
Cc: bug-guile <bug-guile@gnu.org>
Subject: Re: find-versioned-module bugs
Date: Thu, 10 Jun 2010 14:23:13 +0200 [thread overview]
Message-ID: <m3vd9rnkjy.fsf@pobox.com> (raw)
In-Reply-To: <AANLkTinI0j6fJlvH30YdF3TkQ5xJnH9W1VroBk7eTQgj@mail.gmail.com> (Julian Graham's message of "Thu, 10 Jun 2010 00:25:14 -0400")
On Thu 10 Jun 2010 06:25, Julian Graham <joolean@gmail.com> writes:
>>> As you see this function is preferring modules from the end of the
>>> %load-path. In addition it has adds an unnecessary "/". Do you have time
>>> to fix it? :)
>>
>> Eep! Sure, I'll try to take a look this evening.
>
> Fixed! See commit dc232ed059a0af5955d21f077da88af6fdc562a0.
Thanks! Now, a further request, which you may turn down of course :-).
This function currently looks in all dirs in the load path for all ways
that versions can be represented, hence the stat explosion. Instead of
enumerating the entire set of compatible modules, why not simply stop
with the first one? I suspect this would respect the user's expectations
just as well.
What do you think? :)
Andy
--
http://wingolog.org/
next prev parent reply other threads:[~2010-06-10 12:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-09 7:11 find-versioned-module bugs Andy Wingo
2010-06-09 12:40 ` Julian Graham
2010-06-10 4:25 ` Julian Graham
2010-06-10 12:23 ` Andy Wingo [this message]
2010-06-10 14:02 ` Julian Graham
2010-06-10 14:49 ` Andy Wingo
2010-06-14 22:53 ` Andy Wingo
2010-06-15 5:02 ` Julian Graham
2010-06-15 7:34 ` Andy Wingo
2010-06-17 12:58 ` Julian Graham
2010-06-18 8:28 ` Andy Wingo
2010-06-15 23:12 ` Ludovic Courtès
2010-06-16 7:23 ` Andy Wingo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3vd9rnkjy.fsf@pobox.com \
--to=wingo@pobox.com \
--cc=bug-guile@gnu.org \
--cc=joolean@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).