From: Neil Jerram <neil@ossau.uklinux.net>
Cc: bug-guile@gnu.org, johns776@pilot.msu.edu
Subject: Re: Fix for 1001-local-eval-error-backtrace-segfaults - please review
Date: 05 May 2002 15:00:59 +0100 [thread overview]
Message-ID: <m3it62elt0.fsf@laruns.ossau.uklinux.net> (raw)
In-Reply-To: E173U5J-0004uh-00@giblet
>>>>> "thi" == Thien-Thi Nguyen <ttn@giblet.glug.org> writes:
thi> From: Neil Jerram <neil@ossau.uklinux.net>
thi> Date: 02 May 2002 13:59:06 +0100
thi> The copy in scm_unmemocopy, which looks as though it might be
thi> intended to fix this problem [...]
thi> was this used previously? (i'm trying to crawl inside the head of
thi> whoever wrote it this way in the first place.)
I don't know. The most likely ChangeLog entry I can find is `Tue Aug
20 18:48:40 1996 Mikael Djurfeldt', which describes the initial
addition of scm_unmemocopy.
thi> Fix isn't very elegant, though;
thi> is there a nicer way of doing this?
thi> both the old way and the new way involve mutating some nested list
thi> structure, so i'm guessing that doesn't play into "elegance".
No; the new way doesn't mutate at all. It creates a new environment
that shares some substructure with the old environment.
thi> i'm wondering what is it about this fix that makes it not
thi> very elegant?
My fix may use more consing than it needs to. Where possible, I feel
that mutation is desirable because it's faster and doesn't encourage
the GC. So perhaps there's a fix that still works but with fewer than
3 new pairs.
thi> 2. Rerun of problem scenarios:
thi> cool. this touches upon the need to extend the testing framework to
thi> handle interactive cases. actually, i believe that's already possible
thi> w/ the current framework via (ice-9 expect); the limitation really is
thi> that all tests share an execution environment -- this is fine for the
thi> most part, but undesirable for this kind of bug.
But, does this test need a different execution environment? It's true
for any existing test case that, if it causes a SEGV, the following
test cases won't run. This doesn't worry us much because SEGVs aren't
an important part of our plans :-)
Neil
_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://mail.gnu.org/mailman/listinfo/bug-guile
next prev parent reply other threads:[~2002-05-05 14:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-02 12:59 Fix for 1001-local-eval-error-backtrace-segfaults - please review Neil Jerram
2002-05-03 3:50 ` Thien-Thi Nguyen
2002-05-05 14:00 ` Neil Jerram [this message]
2002-05-15 12:43 ` Thien-Thi Nguyen
2002-05-18 13:47 ` Neil Jerram
2002-05-07 18:36 ` Marius Vollmer
2002-05-07 19:30 ` Neil Jerram
2002-05-07 19:39 ` Marius Vollmer
2002-05-11 15:52 ` Neil Jerram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3it62elt0.fsf@laruns.ossau.uklinux.net \
--to=neil@ossau.uklinux.net \
--cc=bug-guile@gnu.org \
--cc=johns776@pilot.msu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).