From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Ricardo G. Herdt" Newsgroups: gmane.lisp.guile.bugs Subject: bug#41131: Bug in hash-table-merge! (and patch) Date: Fri, 08 May 2020 01:50:01 +0200 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=_5212ecabfe80dbc72e77809617dd3d50" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="97548"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Posteo Webmail To: 41131@debbugs.gnu.org Original-X-From: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Fri May 08 02:20:07 2020 Return-path: Envelope-to: guile-bugs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jWqkJ-000PHk-Ml for guile-bugs@m.gmane-mx.org; Fri, 08 May 2020 02:20:07 +0200 Original-Received: from localhost ([::1]:35560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWqkI-00011Q-EI for guile-bugs@m.gmane-mx.org; Thu, 07 May 2020 20:20:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40978) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWqkE-00011C-B3 for bug-guile@gnu.org; Thu, 07 May 2020 20:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60858) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jWqkE-0003SO-0i for bug-guile@gnu.org; Thu, 07 May 2020 20:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jWqkD-0004Vo-SQ for bug-guile@gnu.org; Thu, 07 May 2020 20:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Ricardo G. Herdt" Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Fri, 08 May 2020 00:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 41131 X-GNU-PR-Package: guile X-Debbugs-Original-To: bug-guile@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.158889717517285 (code B ref -1); Fri, 08 May 2020 00:20:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 8 May 2020 00:19:35 +0000 Original-Received: from localhost ([127.0.0.1]:44165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWqjm-0004Ui-VP for submit@debbugs.gnu.org; Thu, 07 May 2020 20:19:35 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:38766) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWqHI-0003j1-77 for submit@debbugs.gnu.org; Thu, 07 May 2020 19:50:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34164) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWqHH-0003Kq-Ux for bug-guile@gnu.org; Thu, 07 May 2020 19:50:07 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:59856) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWqHG-0002yy-MJ for bug-guile@gnu.org; Thu, 07 May 2020 19:50:07 -0400 Original-Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 093C416005C for ; Fri, 8 May 2020 01:50:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1588895402; bh=m6YwxVT+yhH4/+0OI2gqsQPdD9B7ByWUM0gV2z4OeWI=; h=Date:From:To:Subject:From; b=ECjmaT3c3W4x0oeex8rla3oVT1LOmyRJG2yuAU5M+8AGp+wDgfBGDQyV5obZIeNd/ ultA1iDLnnP2ocrZpGvHXuHcHVoR9+GKN/4F/zsqsd0HM1jjDaGsC65ewMKboL759e dxLuhdo5gg4tu0GU/cHkrporY36d7X7Pa05A+2bPXX9KnS5sn6oN08X9kAGZRH/6GE 9HppCCO0B6JHX2pUIUP156FCw3Jp/7gYPZy5GASPHX2C7AZ2MLE7CAk6VpJqMAoe+A b1B2IPc/9buPCz0A8LniR6fSphjdUxjpn6KGdhkNKy7J6v16wopgoumNZi1OgJnO/4 dVvEqi/9ZIUsw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 49J9Dn2WmKz9rxX for ; Fri, 8 May 2020 01:50:01 +0200 (CEST) X-Sender: r.herdt@posteo.de Received-SPF: pass client-ip=185.67.36.65; envelope-from=r.herdt@posteo.de; helo=mout01.posteo.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/07 19:50:02 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Mailman-Approved-At: Thu, 07 May 2020 20:19:34 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.io gmane.lisp.guile.bugs:9754 Archived-At: --=_5212ecabfe80dbc72e77809617dd3d50 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Hi, I just found this bug in the hash-table-merge! function (modul/srfi/srfi-69.scm). Instead of merging both hash tables, it was ignoring one of them (other-ht). Attached is the fix, where it now folds over other-ht and store its data in ht. Cheers, Ricardo G. Herdt --=_5212ecabfe80dbc72e77809617dd3d50 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-Fix-hash-table-merge-bug.patch Content-Disposition: attachment; filename=0001-Fix-hash-table-merge-bug.patch; size=831 RnJvbSAxODBhOWUxNGI4MDcyOTVhYTMxOTY2YTUyYmZkNzMyNjQ3NDU4ZWY5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiUmljYXJkbyBHLiBIZXJkdCIgPHIuaGVyZHRAcG9zdGVvLmRl PgpEYXRlOiBGcmksIDggTWF5IDIwMjAgMDE6Mzc6MjQgKzAyMDAKU3ViamVjdDogW1BBVENIXSBG aXggaGFzaC10YWJsZS1tZXJnZSEgYnVnLgoKKiBtb2R1bGUvc3JmaS9zcmZpLTY5LnNjbSA6IGZv bGQgb3ZlciBzZWNvbmQgaGFzaCB0YWJsZS4KLS0tCiBtb2R1bGUvc3JmaS9zcmZpLTY5LnNjbSB8 IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlm ZiAtLWdpdCBhL21vZHVsZS9zcmZpL3NyZmktNjkuc2NtIGIvbW9kdWxlL3NyZmkvc3JmaS02OS5z Y20KaW5kZXggYjk0ODZjNDY1Li45MWJjYzc3ZGIgMTAwNjQ0Ci0tLSBhL21vZHVsZS9zcmZpL3Ny ZmktNjkuc2NtCisrKyBiL21vZHVsZS9zcmZpL3NyZmktNjkuc2NtCkBAIC0zMzAsNyArMzMwLDcg QEAgQW5zd2VyIHRoZSBmaW5hbCBGIHJlc3VsdC4iCiAgICJBZGQgYWxsIGtleS92YWx1ZSBwYWly cyBmcm9tIE9USEVSLUhUIHRvIEhULCBvdmVycmlkaW5nIEhUJ3MKIG1hcHBpbmdzIHdoZXJlIHBy ZXNlbnQuICBSZXR1cm4gSFQuIgogICAoaGFzaC10YWJsZS1mb2xkCi0gICBodCAobGFtYmRhIChr IHYgaWduKSAoaGFzaC10YWJsZS1zZXQhIGh0IGsgdikpICNmKQorICAgb3RoZXItaHQgKGxhbWJk YSAoayB2IGlnbikgKGhhc2gtdGFibGUtc2V0ISBodCBrIHYpKSAjZikKICAgaHQpCiAKIDs7OyBz cmZpLTY5LnNjbSBlbmRzIGhlcmUKLS0gCjIuMjAuMQoK --=_5212ecabfe80dbc72e77809617dd3d50 Content-Transfer-Encoding: base64 Content-Type: text/plain; name=Changelog Content-Disposition: attachment; filename=Changelog; size=170 MjAyMC0wNS0wOCBSaWNhcmRvIEcuIEhlcmR0IDxyLmhlcmR0QHBvc3Rlby5kZT4KCiogc3JmaS02 OS5zY206IGhhc2gtdGFibGUtbWVyZ2UhIHdhcyBpZ25vcmluZyB0aGUgc2Vjb25kIGhhc2ggdGFi bGUuCkZvbGQgb3ZlciBvdGhlci1odCwgYW5kIHN0b3JlIGl0cyBrZXktdmFsdWVzIGluIGh0Lgo= --=_5212ecabfe80dbc72e77809617dd3d50--