From: "Ricardo G. Herdt" <r.herdt@posteo.de>
To: 41131@debbugs.gnu.org
Subject: bug#41131: Bug in hash-table-merge! (and patch)
Date: Fri, 08 May 2020 01:50:01 +0200 [thread overview]
Message-ID: <ff3f98118ceb25811284e08551ec3771@posteo.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 274 bytes --]
Hi,
I just found this bug in the hash-table-merge! function
(modul/srfi/srfi-69.scm). Instead of merging both hash tables, it was
ignoring one of them (other-ht). Attached is the fix, where it now folds
over other-ht and store its data in ht.
Cheers,
Ricardo G. Herdt
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-hash-table-merge-bug.patch --]
[-- Type: text/x-diff; name=0001-Fix-hash-table-merge-bug.patch, Size: 831 bytes --]
From 180a9e14b807295aa31966a52bfd732647458ef9 Mon Sep 17 00:00:00 2001
From: "Ricardo G. Herdt" <r.herdt@posteo.de>
Date: Fri, 8 May 2020 01:37:24 +0200
Subject: [PATCH] Fix hash-table-merge! bug.
* module/srfi/srfi-69.scm : fold over second hash table.
---
module/srfi/srfi-69.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/module/srfi/srfi-69.scm b/module/srfi/srfi-69.scm
index b9486c465..91bcc77db 100644
--- a/module/srfi/srfi-69.scm
+++ b/module/srfi/srfi-69.scm
@@ -330,7 +330,7 @@ Answer the final F result."
"Add all key/value pairs from OTHER-HT to HT, overriding HT's
mappings where present. Return HT."
(hash-table-fold
- ht (lambda (k v ign) (hash-table-set! ht k v)) #f)
+ other-ht (lambda (k v ign) (hash-table-set! ht k v)) #f)
ht)
;;; srfi-69.scm ends here
--
2.20.1
[-- Attachment #3: Changelog --]
[-- Type: text/plain, Size: 170 bytes --]
2020-05-08 Ricardo G. Herdt <r.herdt@posteo.de>
* srfi-69.scm: hash-table-merge! was ignoring the second hash table.
Fold over other-ht, and store its key-values in ht.
next reply other threads:[~2020-05-07 23:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 23:50 Ricardo G. Herdt [this message]
2021-03-12 21:32 ` bug#41131: Bug in hash-table-merge! (and patch) Andy Wingo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff3f98118ceb25811284e08551ec3771@posteo.de \
--to=r.herdt@posteo.de \
--cc=41131@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).