From: Jean Abou Samra <jean@abou-samra.fr>
To: 16060@debbugs.gnu.org
Subject: bug#16060: Attempt to mutate a literal pair results in segfault (master)
Date: Thu, 20 Jul 2023 00:13:47 +0200 [thread overview]
Message-ID: <e7ef2be10cd781d7bbf8c8fe93c2f6ed20af1956.camel@abou-samra.fr> (raw)
In-Reply-To: <52A0D66A.2070708@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1634 bytes --]
This is still happening with Guile 3.0, but only at -O2, not at -O1.
$ cat x.scm
(set-car! '(1 . 2) 3)
$ guild3.0 compile -O1 x.scm
wrote `/home/jean/.cache/guile/ccache/3.0-LE-8-4.5/home/jean/tmp/x.scm.go'
$ guile3.0 x.scm
Backtrace:
In ice-9/boot-9.scm:
1752:10 6 (with-exception-handler _ _ #:unwind? _ # _)
In unknown file:
5 (apply-smob/0 #<thunk 7f72df6e0f60>)
In ice-9/boot-9.scm:
724:2 4 (call-with-prompt ("prompt") #<procedure 7f72df6e7ee0 …> …)
In ice-9/eval.scm:
619:8 3 (_ #(#(#<directory (guile-user) 7f72df6d9c80>)))
In ice-9/boot-9.scm:
2835:4 2 (save-module-excursion #<procedure 7f72df6c7150 at ice-…>)
4380:12 1 (_)
In x.scm:
1:0 0 (_)
x.scm:1:0: In procedure set-car!: Wrong type argument in position 1 (expecting
mutable pair): (1 . 2)
$ guild3.0 compile -O2 x.scm
wrote `/home/jean/.cache/guile/ccache/3.0-LE-8-4.5/home/jean/tmp/x.scm.go'
$ guile3.0 x.scm
Segmentation fault (core dumped)
I found that module/language/cps/lower-primcalls.scm contains:
;; precondition: pair is mutable pair
(define-primcall-lowerer (set-car! cps k src #f (pair val))
(with-cps cps
(build-term
($continue k src
($primcall 'scm-set!/immediate '(pair . 0) (pair val))))))
which bypasses the check that the scm_set_car_x and scm_set_cdr_x
functions do.
I wonder if instead of checking the pair beforehand, Guile could just
do the set-c(a|d)r! anyway. Could the problem with mmapped bytecode
just be solved by adding PROT_WRITE to the mmap flags? (Or are there
maybe thread-safety problems?)
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2023-07-19 22:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 19:39 bug#16060: segfault when loading file Pieter Slabbert
2013-12-05 23:04 ` bug#16060: Attempt to mutate a literal pair results in segfault (master) Mark H Weaver
2023-07-19 22:13 ` Jean Abou Samra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7ef2be10cd781d7bbf8c8fe93c2f6ed20af1956.camel@abou-samra.fr \
--to=jean@abou-samra.fr \
--cc=16060@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).