From: Taylan Kammer <taylan.kammer@gmail.com>
To: Tomas Volf <~@wolfsden.cz>, 72377@debbugs.gnu.org
Subject: bug#72377: srfi-64: test-eq evaluates test-name multiple times
Date: Wed, 2 Oct 2024 00:22:19 +0200 [thread overview]
Message-ID: <c40e14de-2973-4f5e-9527-e805a7008963@gmail.com> (raw)
In-Reply-To: <ZqlEXVbiwh56HY0e@ws>
[-- Attachment #1: Type: text/plain, Size: 806 bytes --]
On 30.07.2024 21:51, Tomas Volf wrote:
> Hello,
>
> I think I found a bug in (srfi srfi-64) module shipped with GNU Guile.
>
> The specification says that test-eq is equivalent to:
>
>> (test-assert [test-name] (eq? expected test-expr))
> Hence the test-assert's requirement to evaluate test-name only once applies.
>
> However the test-name is evaluated multiple times:
>
> (use-modules (srfi srfi-64))
> (test-begin "x")
> (test-eq (pk "t") #t #t)
>
> Leading to:
>
> ;;; ("t")
>
> ;;; ("t")
>
> Have a nice day
> Tomas Volf
>
>
Same exact deal as in bug reports 72372, 72373, 72375, and 72376.
Fixing 72375 would fix this one too, as test-eq, test-eqv, and test-equal share a helper procedure, and the bug is in that helper procedure.
Already fixed in my implementation.
- Taylan
[-- Attachment #2: Type: text/html, Size: 1465 bytes --]
prev parent reply other threads:[~2024-10-01 22:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 19:51 bug#72377: srfi-64: test-eq evaluates test-name multiple times Tomas Volf
2024-10-01 22:22 ` Taylan Kammer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c40e14de-2973-4f5e-9527-e805a7008963@gmail.com \
--to=taylan.kammer@gmail.com \
--cc=72377@debbugs.gnu.org \
--cc=~@wolfsden.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).