unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
* bug#40584: R7RS string-for-each does not work two or more strings on its argument
@ 2020-04-12 19:38 OKUMURA Yuki
  2020-04-17 21:07 ` Mark H Weaver
  2021-05-12 21:03 ` Taylan Kammer
  0 siblings, 2 replies; 3+ messages in thread
From: OKUMURA Yuki @ 2020-04-12 19:38 UTC (permalink / raw)
  To: 40584

Hi,

Actually it's my own bug but let me report here: (scheme base) lacks
implementation for string-for-each thus following code does not work;

(import (scheme base))

(string-for-each
  (lambda (e f) 'ok)
  "01234"
  "slas")

Please note that we already have incompatible string-for-each for
SRFI-13 and R6RS.
(It seems current (scheme base) uses SRFI-13 one)
R7RS for-each (and map) procedures allow different length of
collection as arguments.

Checked on 2b4e45ca1b89a942200b7b9f46060dddc44d2876





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#40584: R7RS string-for-each does not work two or more strings on its argument
  2020-04-12 19:38 bug#40584: R7RS string-for-each does not work two or more strings on its argument OKUMURA Yuki
@ 2020-04-17 21:07 ` Mark H Weaver
  2021-05-12 21:03 ` Taylan Kammer
  1 sibling, 0 replies; 3+ messages in thread
From: Mark H Weaver @ 2020-04-17 21:07 UTC (permalink / raw)
  To: OKUMURA Yuki; +Cc: 40584

OKUMURA Yuki <mjt@cltn.org> wrote:
> Actually it's my own bug but let me report here: (scheme base) lacks
> implementation for string-for-each thus following code does not work;
> 
> (import (scheme base))
> 
> (string-for-each
>   (lambda (e f) 'ok)
>   "01234"
>   "slas")
> 
> Please note that we already have incompatible string-for-each for
> SRFI-13 and R6RS.
> (It seems current (scheme base) uses SRFI-13 one)
> R7RS for-each (and map) procedures allow different length of
> collection as arguments.
> 
> Checked on 2b4e45ca1b89a942200b7b9f46060dddc44d2876

For the record, the version of R7RS 'string-for-each' that I implemented
for Guile many years ago, in the 'r7rs-wip' branch of Guile's git
repository (not to be confused with 'wip-r7rs'), does not have this bug:

  https://git.savannah.gnu.org/cgit/guile.git/tree/module/scheme/base.scm?h=r7rs-wip&id=2d76447bda2f3d61c94d80b3b78732648a0a511d#n221

I'm not sure why Andy chose not to use my work.

      Mark





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#40584: R7RS string-for-each does not work two or more strings on its argument
  2020-04-12 19:38 bug#40584: R7RS string-for-each does not work two or more strings on its argument OKUMURA Yuki
  2020-04-17 21:07 ` Mark H Weaver
@ 2021-05-12 21:03 ` Taylan Kammer
  1 sibling, 0 replies; 3+ messages in thread
From: Taylan Kammer @ 2021-05-12 21:03 UTC (permalink / raw)
  To: 40584; +Cc: OKUMURA Yuki

[-- Attachment #1: Type: text/plain, Size: 107 bytes --]

Attached is a simple patch to use Mark's implementation
within the current (scheme base) module.

- Taylan

[-- Attachment #2: 0001-Fix-scheme-base-string-for-each.patch --]
[-- Type: text/plain, Size: 2480 bytes --]

From dda2aaaf0e9064f11d89a83f55340ba0c0115bca Mon Sep 17 00:00:00 2001
From: Taylan Kammer <taylan.kammer@gmail.com>
Date: Wed, 12 May 2021 22:36:26 +0200
Subject: [PATCH] Fix (scheme base) string-for-each.

* module/scheme/base.scm (r7:string-for-each): New procedure.

Fixes <https://bugs.gnu.org/40584>.
---
 module/scheme/base.scm | 26 ++++++++++++++++++++++++--
 1 file changed, 24 insertions(+), 2 deletions(-)

diff --git a/module/scheme/base.scm b/module/scheme/base.scm
index 20e280467..58d5acc74 100644
--- a/module/scheme/base.scm
+++ b/module/scheme/base.scm
@@ -51,6 +51,7 @@
             open-output-bytevector get-output-bytevector
             peek-u8 read-u8 read-bytevector read-bytevector!
             read-string read-line
+            (r7:string-for-each . string-for-each)
             write-u8 write-bytevector write-string flush-output-port
             (r7:string-map . string-map)
             bytevector bytevector-append
@@ -108,7 +109,7 @@
    real? remainder reverse round set!
    set-car! set-cdr! string string->list string->number
    string->symbol string-append
-   string-copy string-copy! string-fill! string-for-each
+   string-copy string-copy! string-fill!
    string-length string-ref string-set! string<=? string<?
    string=? string>=? string>? string? substring symbol->string
    symbol? syntax-error syntax-rules truncate
@@ -403,7 +404,28 @@
 (define (r7:string-map proc s . s*)
   (if (null? s*)
       (string-map proc s)
-      (list->string (apply map proc (string->list s) (map string->list s*)))))
+      (list->string (apply map proc (string->list s) (map string->list
+                                                          s*)))))
+
+(define r7:string-for-each
+      (case-lambda
+        ((proc s) (string-for-each proc s))
+        ((proc s1 s2)
+         (let ((len (min (string-length s1)
+                         (string-length s2))))
+           (let loop ((i 0))
+             (when (< i len)
+               (proc (string-ref s1 i)
+                     (string-ref s2 i))
+               (loop (+ i 1))))))
+        ((proc . strings)
+         (let ((len (apply min (map string-length strings))))
+           (let loop ((i 0))
+             (when (< i len)
+               (apply proc (map (lambda (s)
+                                  (string-ref s i))
+                                strings))
+               (loop (+ i 1))))))))
 
 (define (bytevector . lis)
   (u8-list->bytevector lis))
-- 
2.30.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-12 21:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-12 19:38 bug#40584: R7RS string-for-each does not work two or more strings on its argument OKUMURA Yuki
2020-04-17 21:07 ` Mark H Weaver
2021-05-12 21:03 ` Taylan Kammer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).