From: Taylan Kammer <taylan.kammer@gmail.com>
To: 40584@debbugs.gnu.org
Cc: OKUMURA Yuki <mjt@cltn.org>
Subject: bug#40584: R7RS string-for-each does not work two or more strings on its argument
Date: Wed, 12 May 2021 23:03:25 +0200 [thread overview]
Message-ID: <b8453ef0-3e66-e584-0b0f-6954a6a5a446@gmail.com> (raw)
In-Reply-To: <CAG1-Us2+h_CkND26N5PQ4WC12kb85STR2Mtq+Kd9+beAcQg7QQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 107 bytes --]
Attached is a simple patch to use Mark's implementation
within the current (scheme base) module.
- Taylan
[-- Attachment #2: 0001-Fix-scheme-base-string-for-each.patch --]
[-- Type: text/plain, Size: 2480 bytes --]
From dda2aaaf0e9064f11d89a83f55340ba0c0115bca Mon Sep 17 00:00:00 2001
From: Taylan Kammer <taylan.kammer@gmail.com>
Date: Wed, 12 May 2021 22:36:26 +0200
Subject: [PATCH] Fix (scheme base) string-for-each.
* module/scheme/base.scm (r7:string-for-each): New procedure.
Fixes <https://bugs.gnu.org/40584>.
---
module/scheme/base.scm | 26 ++++++++++++++++++++++++--
1 file changed, 24 insertions(+), 2 deletions(-)
diff --git a/module/scheme/base.scm b/module/scheme/base.scm
index 20e280467..58d5acc74 100644
--- a/module/scheme/base.scm
+++ b/module/scheme/base.scm
@@ -51,6 +51,7 @@
open-output-bytevector get-output-bytevector
peek-u8 read-u8 read-bytevector read-bytevector!
read-string read-line
+ (r7:string-for-each . string-for-each)
write-u8 write-bytevector write-string flush-output-port
(r7:string-map . string-map)
bytevector bytevector-append
@@ -108,7 +109,7 @@
real? remainder reverse round set!
set-car! set-cdr! string string->list string->number
string->symbol string-append
- string-copy string-copy! string-fill! string-for-each
+ string-copy string-copy! string-fill!
string-length string-ref string-set! string<=? string<?
string=? string>=? string>? string? substring symbol->string
symbol? syntax-error syntax-rules truncate
@@ -403,7 +404,28 @@
(define (r7:string-map proc s . s*)
(if (null? s*)
(string-map proc s)
- (list->string (apply map proc (string->list s) (map string->list s*)))))
+ (list->string (apply map proc (string->list s) (map string->list
+ s*)))))
+
+(define r7:string-for-each
+ (case-lambda
+ ((proc s) (string-for-each proc s))
+ ((proc s1 s2)
+ (let ((len (min (string-length s1)
+ (string-length s2))))
+ (let loop ((i 0))
+ (when (< i len)
+ (proc (string-ref s1 i)
+ (string-ref s2 i))
+ (loop (+ i 1))))))
+ ((proc . strings)
+ (let ((len (apply min (map string-length strings))))
+ (let loop ((i 0))
+ (when (< i len)
+ (apply proc (map (lambda (s)
+ (string-ref s i))
+ strings))
+ (loop (+ i 1))))))))
(define (bytevector . lis)
(u8-list->bytevector lis))
--
2.30.2
next prev parent reply other threads:[~2021-05-12 21:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-12 19:38 bug#40584: R7RS string-for-each does not work two or more strings on its argument OKUMURA Yuki
2020-04-17 21:07 ` Mark H Weaver
2021-05-12 21:03 ` Taylan Kammer [this message]
2023-09-29 17:01 ` bug#40584: lloda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8453ef0-3e66-e584-0b0f-6954a6a5a446@gmail.com \
--to=taylan.kammer@gmail.com \
--cc=40584@debbugs.gnu.org \
--cc=mjt@cltn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).