From: Roel Janssen <roel@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 39997@debbugs.gnu.org
Subject: bug#39997: High CPU load and no return value with 3.0.0
Date: Wed, 11 Mar 2020 14:03:47 +0100 [thread overview]
Message-ID: <a42e8bfb36ecf5b3a240f8324af41609f20d34ed.camel@gnu.org> (raw)
In-Reply-To: <87eetzm9oq.fsf@gnu.org>
On Wed, 2020-03-11 at 12:07 +0100, Ludovic Courtès wrote:
> Hi,
>
> Roel Janssen <roel@gnu.org> skribis:
>
> > When I use the "md5" module from guile-lib (release 0.2.6.1)
> > together
> > with the following snippet in Guile 3.0.0, it never returns, while
> > on
> > Guile 2.2.6, it returns the MD5 sum of the input string:
> > ---
> > (use-modules (md5))
> >
> > (define (md5-from-string input)
> > (call-with-input-string input md5))
> >
> > (define (random-ascii length)
> > "Returns a random string of ASCII characters of length LENGTH."
> > (list->string
> > (map (lambda _ (integer->char (+ (random 95) 32)))
> > (iota length))))
> >
> > (display
> > (md5-from-string
> > (random-ascii 32)))
> > ---
> >
> > Could you point me in the right direction for finding the problem?
>
> The Guix package has this patch:
>
> '(begin
> ;; Work around miscompilation on Guile 3.0.0 at -O2:
> ;; <https://bugs.gnu.org/39251>;.
> (substitute* "src/md5.scm"
> (("\\(define f-ash ash\\)")
> "(define f-ash (@ (guile) ash))\n")
> (("\\(define f-add \\+\\)")
> "(define f-add (@ (guile) +))\n"))
> #t)
>
> It’s very likely that you’re hitting this problem.
Yes! Thanks for sharing this fix.
I applied the same changes to my code and now I don't encounter the bug
anymore.
I tested the patched code with both guile-2.2 and guile-3.0. Do you
know whether this will also work with guile-2.0? (I'd like to keep
things compatible with guile-2.0 for a few more years).
Kind regards,
Roel Janssen
next prev parent reply other threads:[~2020-03-11 13:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 12:13 bug#39997: High CPU load and no return value with 3.0.0 Roel Janssen
2020-03-11 11:07 ` Ludovic Courtès
2020-03-11 13:03 ` Roel Janssen [this message]
2020-03-11 14:05 ` Ludovic Courtès
2020-03-11 14:11 ` Roel Janssen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a42e8bfb36ecf5b3a240f8324af41609f20d34ed.camel@gnu.org \
--to=roel@gnu.org \
--cc=39997@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).