unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
* bug#72375: srfi-64: test-eqv evaluates test-name multiple times
@ 2024-07-30 19:51 Tomas Volf
  2024-10-01 22:18 ` Taylan Kammer
  0 siblings, 1 reply; 2+ messages in thread
From: Tomas Volf @ 2024-07-30 19:51 UTC (permalink / raw)
  To: 72375

Hello,

I think I found a bug in (srfi srfi-64) module shipped with GNU Guile.

The specification says that test-eqv is equivalent to:

> (test-assert [test-name] (eqv? expected test-expr))

Hence the test-assert's requirement to evaluate test-name only once applies.

However the test-name is evaluated multiple times:

    (use-modules (srfi srfi-64))
    (test-begin "x")
    (test-eqv (pk "t") #t #t)

Leading to:

    ;;; ("t")

    ;;; ("t")

Have a nice day
Tomas Volf





^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#72375: srfi-64: test-eqv evaluates test-name multiple times
  2024-07-30 19:51 bug#72375: srfi-64: test-eqv evaluates test-name multiple times Tomas Volf
@ 2024-10-01 22:18 ` Taylan Kammer
  0 siblings, 0 replies; 2+ messages in thread
From: Taylan Kammer @ 2024-10-01 22:18 UTC (permalink / raw)
  To: Tomas Volf, 72375

On 30.07.2024 21:51, Tomas Volf wrote:
> Hello,
>
> I think I found a bug in (srfi srfi-64) module shipped with GNU Guile.
>
> The specification says that test-eqv is equivalent to:
>
>> (test-assert [test-name] (eqv? expected test-expr))
> Hence the test-assert's requirement to evaluate test-name only once applies.
>
> However the test-name is evaluated multiple times:
>
>     (use-modules (srfi srfi-64))
>     (test-begin "x")
>     (test-eqv (pk "t") #t #t)
>
> Leading to:
>
>     ;;; ("t")
>
>     ;;; ("t")
>
> Have a nice day
> Tomas Volf
>
>
Same exact deal as in bug reports 72372 and 72373.

Affected line is 768 this time.

Already fixed in my implementation.

- Taylan






^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-10-01 22:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-30 19:51 bug#72375: srfi-64: test-eqv evaluates test-name multiple times Tomas Volf
2024-10-01 22:18 ` Taylan Kammer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).