From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tomas Volf <~@wolfsden.cz> Newsgroups: gmane.lisp.guile.bugs Subject: bug#68504: [PATCH v3] Add copy-on-write support to scm_copy_file. Date: Wed, 13 Mar 2024 00:19:24 +0100 Message-ID: References: <20240116124817.14680-1-~@wolfsden.cz> <20240124191607.3571-1-~@wolfsden.cz> <878r2nmwf9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vHDuOdkzqzrmfLwb" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9828"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68504@debbugs.gnu.org To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-X-From: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Wed Mar 13 00:20:54 2024 Return-path: Envelope-to: guile-bugs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rkBQT-0002OP-O8 for guile-bugs@m.gmane-mx.org; Wed, 13 Mar 2024 00:20:53 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rkBQ8-00082h-9v; Tue, 12 Mar 2024 19:20:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rkBQ3-0007wx-Ho for bug-guile@gnu.org; Tue, 12 Mar 2024 19:20:30 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rkBQ3-00054r-8s for bug-guile@gnu.org; Tue, 12 Mar 2024 19:20:27 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rkBQb-0002Te-QE for bug-guile@gnu.org; Tue, 12 Mar 2024 19:21:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tomas Volf <~@wolfsden.cz> Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Tue, 12 Mar 2024 23:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68504 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch Original-Received: via spool by 68504-submit@debbugs.gnu.org id=B68504.17102856079440 (code B ref 68504); Tue, 12 Mar 2024 23:21:01 +0000 Original-Received: (at 68504) by debbugs.gnu.org; 12 Mar 2024 23:20:07 +0000 Original-Received: from localhost ([127.0.0.1]:44158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rkBPi-0002SC-Lr for submit@debbugs.gnu.org; Tue, 12 Mar 2024 19:20:06 -0400 Original-Received: from wolfsden.cz ([37.205.8.62]:41454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1rkBPe-0002Rf-QH for 68504@debbugs.gnu.org; Tue, 12 Mar 2024 19:20:04 -0400 Original-Received: by wolfsden.cz (Postfix, from userid 104) id 54D8928C755; Tue, 12 Mar 2024 23:19:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1710285566; bh=HSZvMKep+Tt6e/X+BQCCan72D2NfvM+02SbL7/xjQAw=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=qKbpz2u6knmMGtRcCwZo9ND7GrszdMxji19zXchcEXS80rQO/axA4K7pgAnCqU9N6 kT87F9GPfD6JZ0yS7IkIjPoGZLwZlxj+TishZwnRKD+X5HqcTkICf95sI+74nU3GLI o6SoEESDNzSTTYn44/boZ7h0P9bbX8IfuNl6ML+L7J8nYso62lAx+kyIbsFpKFJTFR Dg6pPyzJJcMHIM2kbaMDP/oYelIztwYaF16YYb9XVNDySNZdbs/JJr8SzJyZQXmCzz ZOAkdcMwHOUP7Lc1Rk0uraSjmNca/woyYgIgf/4bUslJtaAGMysSDupq2cxMEakBNs vEvYex/T7KMQr2YfRl35ZZz2wP/vwd/dH7PSDYB896wFtb+nzwxjuyFdLqLIoRSeth HpM2RpscUWoWgqGxufdxhFWscf5SThUAs5klmtI8J4mWo6js7BG29a+mzlsmTvCQ0E 8kvFo4BKGEsjnezUHYtZeeyD0QM0mPf41qRVjJYT0LCIHmDbJjMrCSBrH3sONUoOhe mWugWJMWZJVA4zoVEEdRZKBIBlYRB9GDtQnqyPzCkwxhwKxAS8fEeXtx8IvPVPxdkL Kt/7d1MLuppHtnWrxn3CG0sP3sHO+F+jmAgiR/PPIEO76PYBsIEE5X1S89dbFqNr82 emqTkyWDwuBnMZtGm/JtpuWU= Original-Received: from localhost (unknown [193.32.127.156]) by wolfsden.cz (Postfix) with ESMTPSA id 68DF62893C6; Tue, 12 Mar 2024 23:19:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1710285565; bh=HSZvMKep+Tt6e/X+BQCCan72D2NfvM+02SbL7/xjQAw=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=E9MRRko8EtlZnJ2/gIy5HfyDgB9mazH/oQkGuV0/jUOZyvqMM5IBP05NWCkrx+npM 3noFSo9HXzuKAQNsVv6GskvYwVuFeTv5JWXVC6DxKNmtUvZdVYUAAlySkA5yMO4LXL uD1m/xQ19mJyEQ0HoP0YJIUqFQHGuzW8j2zydcHX9iFph/2nmaxUHalZdbcJiSAISx 3op0svZ7Uiinl9YCUUCjfAv5qVQiT4hvG3KrVCdAKAFuo7LUVflCOZGjYeUHgg0XNJ kYFZdWE3e9zJmY6bTD7zivar4oQrhbgOvL48py3rgIwo40b8Cqs+WNilDtwhUPtvCx 5rhBvIIlfWguUTNR8Zxn3Gc4AW+xFmKOII/QpDugby49nJ9aLIHj4fUZZ97wz+smnk F38Jn0gBy1JyRqOnifMqvL9NtQch4jYamQgqmx5PX6FOYWk1Nc1ZRzOmu+l6sft7NN hR0LrvhA3MrzSblVnnRhl0WzpsOS9CP0ochWTWD3EMMjsR/isiyJSoatlxjFC8Wu/k 79q10Awu2qb4IVt2fHwz3C7sHv9OYwxzplKAr7lU0oVNgP4o8eX4x5XVJlAIgSTlYz 2zMFR4VO87yXbVQ3KWPUm/xnL7LDSIWj/7CW3kGyf07vB4LDwlPFyB2r8qlVhPfP8B jig4DNbBrgwCN+WX/4ge10rI= Content-Disposition: inline In-Reply-To: <878r2nmwf9.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.bugs:10790 Archived-At: --vHDuOdkzqzrmfLwb Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2024-03-12 14:06:34 +0100, Ludovic Court=C3=A8s wrote: > > Finally pushed as e1690f3fd251d69b3687ec12c6f4b41034047f0f. Note that I > added copyright lines for you, let me know if I got it wrong. Thank you for merging it, and thanks for the copyright, looks correct :) > As a followup, we should add support for =E2=80=98copy_file_range=E2=80= =99 when FICLONE > cannot be used; glibc supports it on all platforms but it returns ENOSYS > on GNU/Hurd currently. > > WDYT? Sure, I am willing to do my part. I managed to find this blog post[0], so = after some minor troubles I did manage to get a VM with GNU/Hurd running. Next I= will read up on copy_file_range and try to put together a patch. Just to make sure, your idea here is exactly what? Always try to use copy_file_range before the regular copy? So the flow would be For 'always case: CoW ---fail--> FAIL For 'auto case: CoW ---fail--> copy_file_range ---fail--> current copy ---fail--> = FAIL For 'never case: copy_file_range ---fail--> current copy ---fail--> FAIL Is that an accurate summary? Or did you mean only as a fallback for the Co= W, so only for 'auto, but not for the 'never? Tomas 0: https://guix.gnu.org/en/blog/2020/a-hello-world-virtual-machine-running-= the-hurd/ -- There are only two hard things in Computer Science: cache invalidation, naming things and off-by-one errors. --vHDuOdkzqzrmfLwb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmXw4vwACgkQL7/ufbZ/ wamXaA//e89I0+8GmuZOBp9Ah0Sd983f/D+tQiuA3T8oDe99nWRl9RAuTfsz4uq2 NAY1ekT+x+07nEDmFoRMko0KWglObZGFO6h5Zu4buAG/81beh6QqNSsv3Jr9ZD1J weUOo/AiAQG8GelP4ZxAa185GDN9I9oBWkD4raGeeUErXaXzKw6M/R1c9ss1iswW txs/vbsdkP0FxSi7cBuL4cw3kdFRzZ7Ylcth2kTR3ers8p+76+MK+qqLOmYYQKry vR4Jsjjv4qJBF/aVJnLYrvjLA6FrF64xywvCLo2cmtGitNHlsK98ykwVRc/MDtEy gmefNWYXOssxqrtD/d74vz9Nkuo9Vh8/3fP8nxIh+Mx0tjrxzvTHJUVAaWq8ASnW jbbP8nC+kACuEk+JO4gU2yUb4OCw56illy8i75/0krXff+8zkfiL634Lg8DHrBxB B8/Uvy7vl8ND2yMmS97BsgHLyIgCjs6SKrlt1lqIkGRjS9ogKqHYhNLB70La5b3d XtRCYkRo0rsMluROuI9RWcjK9t/1VcC6X5a7gsDFGNMWP/7lffbGOJ/B8iSS+fe+ eFLr0ALmAYmI4SezgC0mG9fmIBJITxarprCcFtX5aqdQtPkaeoMM0KY/Nv4qWEqP fAdeh5QpVW3Cej9Q/p1vjzOb3EiUzsI9SQwGEoVD8ZTnzxxKPzE= =/Jsb -----END PGP SIGNATURE----- --vHDuOdkzqzrmfLwb--