From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tomas Volf <~@wolfsden.cz> Newsgroups: gmane.lisp.guile.bugs Subject: bug#68504: [PATCH] Add copy-on-write support to scm_copy_file. Date: Wed, 24 Jan 2024 20:19:51 +0100 Message-ID: References: <20240116124817.14680-1-~@wolfsden.cz> <87le8fuivj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xo/A4N8EqDgMYc40" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9252"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68504@debbugs.gnu.org To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-X-From: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Wed Jan 24 20:21:31 2024 Return-path: Envelope-to: guile-bugs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rSioT-0002DS-SO for guile-bugs@m.gmane-mx.org; Wed, 24 Jan 2024 20:21:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rSio7-0008Nz-Sb; Wed, 24 Jan 2024 14:21:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSinz-0008KK-Ri for bug-guile@gnu.org; Wed, 24 Jan 2024 14:21:01 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rSinw-0005O8-Qz for bug-guile@gnu.org; Wed, 24 Jan 2024 14:20:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rSio2-00016Y-5d for bug-guile@gnu.org; Wed, 24 Jan 2024 14:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tomas Volf <~@wolfsden.cz> Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Wed, 24 Jan 2024 19:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68504 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch Original-Received: via spool by 68504-submit@debbugs.gnu.org id=B68504.17061240024148 (code B ref 68504); Wed, 24 Jan 2024 19:21:02 +0000 Original-Received: (at 68504) by debbugs.gnu.org; 24 Jan 2024 19:20:02 +0000 Original-Received: from localhost ([127.0.0.1]:46625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSin4-00014k-6h for submit@debbugs.gnu.org; Wed, 24 Jan 2024 14:20:02 -0500 Original-Received: from wolfsden.cz ([37.205.8.62]:47004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1rSin1-00014P-SJ for 68504@debbugs.gnu.org; Wed, 24 Jan 2024 14:20:01 -0500 Original-Received: by wolfsden.cz (Postfix, from userid 104) id 55B6A2765E4; Wed, 24 Jan 2024 19:19:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1706123993; bh=XLEMKCJSp9uUx3OPhNYkzR238ZRCfb60Ut2T465xibU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=XNCCBLK86Y5SV0ctU40OwvZOoeevMWx7p19mC/DXcE9SiN0ulzBoYEAGy7r0xz1Q/ 0F8wRngIw5LRrK1rrs95VLBpu3pgGDNwaWHg/GPj82kvY9qPqaRRKhaoLttxfME2pt DazqKUHhGsYkpBypej6ntvH27l1cH420bLyFnWyW6eINkLQN0AzbULDAL4Wov4uOvO cVfo0HKPT6QD8W5UneXZxsbLEiNAK4aK/Uk2HGva0rIhtIhFKhjpB/fKvKUPVebpXZ bCiyYjMEV8anA5+sCpelQ23Co9WLhlFey6zxpRspOl3sImd0Z/2ee/7Ksht9jeMk7j jBnWl/wYMnDE6zDsN/Fnppui+tMHQ9Ixj0oD+UmsRLCMDUuhL11uu3DNwkOJGgrh1T yf+avw+PervM9eobaJnyiqdD7ptr9WJ1L4kbpMeMhKUMto4jgmBA+ePzTCge2prlop shHvkPmPJonmRRVjCrsrbfCCZxR0qghNRipj+06JK/i4PsTo2bJIjInfbVbz/ZPqdH V/qw5sWW80fHhZlNEIEIYK9rf3r47kbKJBwC0MQAeiWP7M4+q1GtxpdMFDfRRZTF2x bjVU24zkCYNHZ0WBv/VX+Pf5azBZEK0v/gS8mSaTnps4XvA9LDwjq8JhwvM9UWPFPP mkkezVtxO+wWGX03woLcIlhU= Original-Received: from localhost (unknown [146.70.134.137]) by wolfsden.cz (Postfix) with ESMTPSA id 783A1277E95; Wed, 24 Jan 2024 19:19:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1706123992; bh=XLEMKCJSp9uUx3OPhNYkzR238ZRCfb60Ut2T465xibU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=OzOFOmCrMmXVrFsqOP0aWxqUtGa75p6gipMMC6T6EdTqoC4qqwpE0RoNcj0IeOO80 62p3H89iC+D26/ZYsqgErpE5h5cvhptJ+zSRRVMmn0jKMKEcyaLPZxph6x2ZnG7lAL nskVXohqhh6K9LWfwctGOYsDT5QE9fXvMI8n51pMN1YwFc64MzihemBk4j4VxaLje9 9c8ti5DC44FIp/nZkG6UnZ71JlwuGgOHZil+3kew/+ITy2lgYuIXwwqDMY2MjWn4PJ 1K01/R0G6mOszKGIFdDsNRFeRmpJpNolR6Jlw4nhhKtjOeb8TVodMvZJXA4kzVJMDS +pd+uVa4YOHEZKi5pN59D25bmrxe0AGT3p0ycZfiJBkq6KsVIFiqEr0pz0ojLoLRQd 17uRyS+Qa4/EZ01pJ8Hrju+hptPkU7bnrZNdDSLrxwYvyUTs5u9X957lq0ne0EIeFZ 6ZImCj6Tv0cJvQLRK+3Vso754D51yNFOJ6oYWKBJjCJ54rLzWIzOGSqlG4LHjcuXdq p6NhQzpyJ92M+A5KjLvNOl/GdOHsQh7+xelNSCs3chqP4flqZBBlOt+X4hAYlP5aHZ N2AMXCFiTTlt3LtkUWAlm5int9xLZSAGBgfKtu0kTcrKRzQf07Ri382OkHEsUKvBBU jm6Y2bIC7PhNwpglyhW7AmXg= Content-Disposition: inline In-Reply-To: <87le8fuivj.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.bugs:10768 Archived-At: --xo/A4N8EqDgMYc40 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2024-01-24 11:26:56 +0100, Ludovic Court=C3=A8s wrote: > > The patch looks great (and very useful) to me, modulo one issue: > > > -SCM_API SCM scm_copy_file (SCM oldfile, SCM newfile); > > +SCM_API SCM scm_copy_file (SCM oldfile, SCM newfile, SCM rest); > > Since this is a public interface, we cannot change this function=E2=80=99s > signature during the 3.0 stable series. > > Thus, I would suggest keeping the public =E2=80=98scm_copy_file=E2=80=99 = unchanged and > internally having a three-argument variant. The Scheme-level > =E2=80=98copy-file=E2=80=99 would map to that three-argument variant. (S= ee how > =E2=80=98scm_pipe=E2=80=99 and =E2=80=98scm=C2=A0accept=E2=80=99 as examp= les.) That is a very good point, which I did not realize at all. Thanks to the examples you provided, it was not that hard to do (well, assuming I did it right). > Could you send an updated patch? Done. However now that I read it after myself, I overlooked this occurrenc= e of scm_copy_file in the commit message: This commit adds support for this feature into our copy-file (scm_copy_file) procedure. Same as `cp', it defaults to So I just sent v3 right after v2, sorry for the noise, should have been more careful. > > BTW, copyright assignment to the FSF is now optional but encouraged. > Please see > . Since it is optional, I will currently opt into not doing the assignment, I= do not like the concept that much. I will try to find time to actually form an opinion based on facts. Have a nice day, Tomas -- There are only two hard things in Computer Science: cache invalidation, naming things and off-by-one errors. --xo/A4N8EqDgMYc40 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmWxYtcACgkQL7/ufbZ/ walVqxAAi5THU9sSyNMZOZigU3Wb4PVZWPkRE2FjPG1AiXbwpJlaki6A7yRvXYT7 N62ChPRI0CHf1NPBAnuKLd9w4/0rpARWTKBloVD4WklM39hQKaQLqOVtZoLKud4R huf9L6rZQ20oH071UwnP2el23v/tMSWNowcnlsydamVy4/d6TAsG8wqQkp6bG1wm 51v1N+KTzp+W1Gvro/LE5kd4f4gq8D+CpecKKs+XFKEeOh2IkwRhrRxuKVoSJyl4 1g1rOFOZocx8Z96Mywt/Gmz09qlpxqORfG8cGvPlhkMDtMrOv3cF4AhLb6ndDHg7 i6Qk0Qg21e5vN2ADQpWnW/61VT98KemRhqRoftezkOeGNHyJz1Cso7gNXN9OWJeu nE0NxJ/QDcYsNohL1Wh7h7+MVNmviUXqnkNsIqzWximo08LXcQ4/wQOKBCX1rYkA Nlxjcqe42VNn9yBDd/J0f/sb78IY+vFgwlaRk0BBrpYQ7HNgXyYt3LenSX2u4KPU NkmcLXysaqdXqmVhS+ZiV8JpB6yFh/LQV6ZnapTAY0uOjTmAtpIhLp01a56eH000 HbKy9GpBI+6125gjT48u/OXAl6q2OTgyhj6E++63QWWVqMBiA+69c1IYqEaudiR5 rGl/bXyKlu9WD+AkKTqVLj6ZGCgRs1dtEohNKT4d/NsxEm+jAqQ= =XZc3 -----END PGP SIGNATURE----- --xo/A4N8EqDgMYc40--