From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tomas Volf Newsgroups: gmane.lisp.guile.bugs Subject: bug#66531: [PATCH] ftw: Fix getuid-or-false, getgid-or-false macros. Date: Fri, 13 Oct 2023 20:20:03 +0200 Message-ID: References: <20231013161811.19233-1-wolf@wolfsden.cz> <458374241.8000448.1697218206032@mail.yahoo.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LI0+977NKn5E6PUe" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4174"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "66531@debbugs.gnu.org" <66531@debbugs.gnu.org> To: Mike Gran Original-X-From: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Fri Oct 13 20:21:03 2023 Return-path: Envelope-to: guile-bugs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qrMmU-0000si-RI for guile-bugs@m.gmane-mx.org; Fri, 13 Oct 2023 20:21:03 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qrMmE-0006uZ-Mw; Fri, 13 Oct 2023 14:20:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrMm9-0006tU-Gd for bug-guile@gnu.org; Fri, 13 Oct 2023 14:20:42 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qrMm8-0001C9-9P for bug-guile@gnu.org; Fri, 13 Oct 2023 14:20:41 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qrMmU-00013L-35 for bug-guile@gnu.org; Fri, 13 Oct 2023 14:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tomas Volf Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Fri, 13 Oct 2023 18:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66531 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch Original-Received: via spool by 66531-submit@debbugs.gnu.org id=B66531.16972212404009 (code B ref 66531); Fri, 13 Oct 2023 18:21:02 +0000 Original-Received: (at 66531) by debbugs.gnu.org; 13 Oct 2023 18:20:40 +0000 Original-Received: from localhost ([127.0.0.1]:47396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrMm8-00012b-HV for submit@debbugs.gnu.org; Fri, 13 Oct 2023 14:20:40 -0400 Original-Received: from wolfsden.cz ([37.205.8.62]:43056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrMm2-00012K-NK for 66531@debbugs.gnu.org; Fri, 13 Oct 2023 14:20:39 -0400 Original-Received: by wolfsden.cz (Postfix, from userid 104) id B7D0526CB9F; Fri, 13 Oct 2023 18:20:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1697221208; bh=Hwk0xXbVMB7RqbipJyUOvZrgQvEnu1u33k+mhj6qXwk=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=SUqUkoOMU70jBsMGtC/nlcm2UGgWerq1ZW7xWfmB/uvNGDfOctPllKL6gcXoTy/BS zpVRHvfHT7k3iPYisgfU1cUfPOGX0KzKOWXrm1PEhBs47MfOfJxs3qn+Gkts99JPjN b0DTog+GsuSDcB7QZaLGByFG7o+tOQ/vhYLlHiPH8SPVLwIZifNM9ETPqapTAVke2w xKI741/gnwPYO0UJnMGMPZ+dy/VgAarZ+Ygtrw4/XKLNfcdgel6ZjQo2JyuahJvl3d PQeyaQNzwYSTTdiBb8nsMk0goE7q/mK/hUJgtYYglP9KU72dUDmj3w8xlFWoUk7LUP U0TvxdYrVWVS/IcRMonbymu+jVvyoMoq+L7ktyyCdAoVW8pu+kTEdkfMhjWqlzR3sW hNQ709JmDA8Z+9TPLfcyu1GBAhMHko9ji7YOb9VmyVZzbmSOOFt3acBtaqse5hZzIj lG7Vud3Eq60MndM2Yrcq2XKdVcvniy4H1FQkUCg5JTToPOmUwSCVd0fQlvpbJNvMu0 WelUMIkowEZNTCswEN9IX7GS7HG1yVjI2m73lKYhYYNmVIStabFP7WYyxlIfknMDTs mrSOUXpHqN57qlca2TB7j9H2ZRa35bOQU/jCim+1SkJRtyqYWSLTo7Y3I+Cq+zPvOQ ixavs9gbedPCRr5XbxZZZMO0= Original-Received: from localhost (unknown [81.17.16.88]) by wolfsden.cz (Postfix) with ESMTPSA id 6DAE426C78D; Fri, 13 Oct 2023 18:20:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1697221207; bh=Hwk0xXbVMB7RqbipJyUOvZrgQvEnu1u33k+mhj6qXwk=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=vNYnUJD/hmwaEPDS7wdafiq7crtIhe5nQ9esQokwGlquxR0oJEsL86hlUjRnZGHSw xpvudaiL//UEXWDXNQ0D61zesI23CVMYkedKiKC4FlSWjTANR49kmgJELSWNtTyDAB DUIhzosZyBEEV34lbeJE2kmDgGVu+mA+N1xCSMcGAVdl98fbewzi2sH7olY/5RDuiy AarY/j3ZWys8skPtgt8mzGAib72aIEu81lj3k/WEl3N9tu//N8Rk2FXN81IcT+QD15 Y1So/HlUwszqrZ1naffPN+RT20qj43JVITQ5dRVE/dny13pPLzEnJ9aVfFYE6TfQ9z PQ2/+B6j/CM+UCPwjPsWM4hCxzPcvl+0hup4q4EU1W68tsaDTfjXXECLruT5kr5yJJ bs1uU6T2e+nYqBJe9TRoH1l+7AJlWzG4O4Sz7GbYNyFABgo4LOj4ZIZ/eID5H+BquX Wa0i8KTvmxnonjn8nbjr4gsdGnoTZDMD9OkCETrpb5DeyKcy7Q/uLvpDG4wEPC7rU5 3bbPlCG+WrWdptqPGvndfhIIHSOMzOo6pONoz/oqDMYNyncgTxIfjEI7ySN150gbNP D55LUriH55yaMrG7NaNrBplYMnwzTDkhJHvPTh6LcNDJcxZr0CEMc7/okkIKCXOtI3 G9Zo8xLPEZ3QgNRyPikPR668= Original-Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id ffb90aca; Fri, 13 Oct 2023 18:20:03 +0000 (UTC) Content-Disposition: inline In-Reply-To: <458374241.8000448.1697218206032@mail.yahoo.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.bugs:10681 Archived-At: --LI0+977NKn5E6PUe Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2023-10-13 17:30:06 +0000, Mike Gran wrote: > > Both macros were missing a quote for the procedure call, causing the > > actual return value to be compiled into the ftw.go, instead of the > >procedure call.=A0 Snippet from disassembly of ftw.go does confirm that: >=20 > Looks good to me. >=20 > If you don't have commit approval, I can take the action to commit it, > and write a test case, since I was the one who broke it back in 2021. I do not have commit access, nor I am sure how the tests should look like, so if you would be so kind to take it over from here, that would be great. :) >=20 > Mike Gran Tomas Volf --=20 There are only two hard things in Computer Science: cache invalidation, naming things and off-by-one errors. --LI0+977NKn5E6PUe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmUpilMACgkQL7/ufbZ/ waku8RAAsBcAmNEcEVr2S+gKv09shY2mNmI0eovF8jPlzBfm/49jlEPbQFa9cOdT ASXQB7wkjGz9tum9IhzU6Q2UW7AcR0IS+g2Rvr4JATuKTds3vfShxhw+1WQccoCh YvzT/OugnhL+89pth+RjM9wUmJMKF81DBZa/Sdya7CdE9xVniJaiLhgjd7xNy3Pe gBcnBGk6KcAruie5lElpVxZyeXUDaUPUtQTQqqSMkOOhbPjtOP+LA+RQAIV2NSg4 UlABG+LTMhAfo94puj6ZEpGCg6MQZcrE28rX5sMP3SfC3THwu9yox56z19Ti+L4p EkPtf6Bn1+ySgJF/mslHc4Cu2AJGUaYnwxmkJl3M7fL4eJtmWMZUyuD/gzlRCOkt pSmwQsusPciHoxNVck+lU16krZbgAsNr2TlkFSlzWub+5K+xBuSWiDzU7cft+OcM EQBIxuDSqCZ4aLlSJ1ybd8fiZLeWzDWm9ZtGne/Fuv2S7C0soEs/39eXO5d8szBt phNf3KfPtqXe9lRJxyw2ioUnjKf4FtA36zRx363PXzNg/vDrjNDsjTsJHw7WjfwY CBPcX6uxqpaMbSy5Uj4zwD9LC3EY/0WcZxyPS7t34KpIxvl7lwtYbyTscWAE//BG d4RnwdlGk+g/3s7C27E0RKxkth/B70hoKBOv2paDj0PGM+nbtcg= =HeZA -----END PGP SIGNATURE----- --LI0+977NKn5E6PUe--