unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
* bug#35430: MinGW: Including libguile.h breaks build because there is no sys/select.h
@ 2019-04-25 20:01 ` John Ralls
  2019-04-25 20:59   ` bug#35430: Patch for 35430 John Ralls
  2022-09-21 12:53   ` bug#35430: close Mike Gran via Bug reports for GUILE, GNU's Ubiquitous Extension Language
  0 siblings, 2 replies; 3+ messages in thread
From: John Ralls @ 2019-04-25 20:01 UTC (permalink / raw)
  To: 35430

libguile.h indirectly includes libguile/iselect.h via libguile/threads.h and libguile/deprecated.h. iselect.h in turn includes <sys/select.h> that is not provided by MinGW.

<sys/select.h> is included in iselect.h to provide a declaration of fd_set; in MinGW that's declared in winsock2.h.







^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#35430: Patch for 35430
  2019-04-25 20:01 ` bug#35430: MinGW: Including libguile.h breaks build because there is no sys/select.h John Ralls
@ 2019-04-25 20:59   ` John Ralls
  2022-09-21 12:53   ` bug#35430: close Mike Gran via Bug reports for GUILE, GNU's Ubiquitous Extension Language
  1 sibling, 0 replies; 3+ messages in thread
From: John Ralls @ 2019-04-25 20:59 UTC (permalink / raw)
  To: 35430

From 843070dd3961a2282ee9f6582f459e70894758fa Mon Sep 17 00:00:00 2001
From: John Ralls <jralls@ceridwen.us>
Date: Thu, 25 Apr 2019 13:49:02 -0700
Subject: [PATCH] MinGW: Don't break build when including libguile.h

     * iselect.h: get fd_set declaration from winsock2.h on MinGW.
Fixes bug 35430.
---
 libguile/iselect.h | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/libguile/iselect.h b/libguile/iselect.h
index 945ad14af..806c30504 100644
--- a/libguile/iselect.h
+++ b/libguile/iselect.h
@@ -29,7 +29,11 @@
 /* Needed for FD_SET on some systems.  */
 #include <sys/types.h>

+#ifdef __MINGW32__
+#include <winsock2.h>
+#else
 #include <sys/select.h>
+#endif

 SCM_API int scm_std_select (int fds,
                            fd_set *rfds,
@@ -38,7 +42,6 @@ SCM_API int scm_std_select (int fds,
                            struct timeval *timeout);

 #define SELECT_TYPE fd_set
-
 #endif  /* SCM_ISELECT_H */

 /*
--
2.20.1






^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#35430: close
  2019-04-25 20:01 ` bug#35430: MinGW: Including libguile.h breaks build because there is no sys/select.h John Ralls
  2019-04-25 20:59   ` bug#35430: Patch for 35430 John Ralls
@ 2022-09-21 12:53   ` Mike Gran via Bug reports for GUILE, GNU's Ubiquitous Extension Language
  1 sibling, 0 replies; 3+ messages in thread
From: Mike Gran via Bug reports for GUILE, GNU's Ubiquitous Extension Language @ 2022-09-21 12:53 UTC (permalink / raw)
  To: 35430

Was fixed January 2021 in 1b0da42672262426bca7bb58e70fb753c628ffc3







^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-09-21 12:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <YysJQlrLuaDIhsoQ.ref@spikycactus.com>
2019-04-25 20:01 ` bug#35430: MinGW: Including libguile.h breaks build because there is no sys/select.h John Ralls
2019-04-25 20:59   ` bug#35430: Patch for 35430 John Ralls
2022-09-21 12:53   ` bug#35430: close Mike Gran via Bug reports for GUILE, GNU's Ubiquitous Extension Language

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).