bug#49930: glibc-2.34 build failure in gnulib (needs a sync)

bug#49930: glibc-2.34 build failure in gnulib (needs a sync)

[Sergei Trofimovich]

Hi bug-guile!

Recent glibc-2.34 released changed attribute macros slightly
which broke older gnulib macros. Fixed in gnulib upstream as:
    https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=0c907f7da13232908f05c415b8cec56024071906

guile.git now fails to build on x86_64-linux as:

```
  CC       regex.lo
In file included from regexec.c:1368,
                 from regex.c:74:
./malloc/dynarray-skeleton.c:195:24: error: expected declaration specifiers or '...' before '(' token
  195 | __attribute_nonnull__ ((1))
      |                        ^
./malloc/dynarray-skeleton.c:205:51: error: expected declaration specifiers or '...' before '(' token
  205 | __attribute_maybe_unused__ __attribute_nonnull__ ((1))
      |                                                   ^
./malloc/dynarray-skeleton.c:216:24: error: expected declaration specifiers or '...' before '(' token
  216 | __attribute_nonnull__ ((1))
      |                        ^
./malloc/dynarray-skeleton.c:225:24: error: expected declaration specifiers or '...' before '(' token
  225 | __attribute_nonnull__ ((1))
      |                        ^
./malloc/dynarray-skeleton.c:239:24: error: expected declaration specifiers or '...' before '(' token
  239 | __attribute_nonnull__ ((1))
      |                        ^
./malloc/dynarray-skeleton.c:248:24: error: expected declaration specifiers or '...' before '(' token
  248 | __attribute_nonnull__ ((1))
      |                        ^
./malloc/dynarray-skeleton.c:260:24: error: expected declaration specifiers or '...' before '(' token
  260 | __attribute_nonnull__ ((1))
      |                        ^
./malloc/dynarray-skeleton.c:270:24: error: expected declaration specifiers or '...' before '(' token
  270 | __attribute_nonnull__ ((1))
      |                        ^
./malloc/dynarray-skeleton.c: In func
```

Would it be reasonable to sync gnulib and cut a guile point release
compatible with it?

Thank you!

-- 

  Sergei

bug#49930: glibc-2.34 build failure in gnulib (needs a sync)

[lloda]

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]


Hi,

I have updated gnulib in http://git.savannah.gnu.org/gitweb/?p=guile.git;a=commitdiff;h=b4a80f4239b19fea4d2cc3e9d197f24b809f0624 <http://git.savannah.gnu.org/gitweb/?p=guile.git;a=commitdiff;h=b4a80f4239b19fea4d2cc3e9d197f24b809f0624>. Please let me know if this solves the issue – I am unable to test with the newer glibc versions. 

Thanks

	Daniel

[-- Attachment #2: Type: text/html, Size: 842 bytes --]

bug#49930: glibc-2.34 build failure in gnulib (needs a sync)

[Sergei Trofimovich]

[-- Attachment #1: Type: text/plain, Size: 629 bytes --]

On Mon, 16 Aug 2021 19:41:36 +0200
lloda <lloda@sarc.name> wrote:

> Hi,
> 
> I have updated gnulib in http://git.savannah.gnu.org/gitweb/?p=guile.git;a=commitdiff;h=b4a80f4239b19fea4d2cc3e9d197f24b809f0624 <http://git.savannah.gnu.org/gitweb/?p=guile.git;a=commitdiff;h=b4a80f4239b19fea4d2cc3e9d197f24b809f0624>. Please let me know if this solves the issue – I am unable to test with the newer glibc versions. 

The change fixes build for me and passes all except one test:
    test-suite/standalone/test-out-of-memory
which is unrelated to glibc-2.34.

Definitely an improvement.

Thank you!

-- 

  Sergei

[-- Attachment #2: Цифровая подпись OpenPGP --]
[-- Type: application/pgp-signature, Size: 981 bytes --]