From: Gregory Marton <gremio@csail.mit.edu>
To: Neil Jerram <neil@ossau.uklinux.net>
Cc: bug-guile@gnu.org
Subject: Re: A passing test case
Date: Sat, 26 Jan 2008 14:09:46 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.62.0801261405390.307@ashmore.csail.mit.edu> (raw)
In-Reply-To: <87wspwo1m1.fsf@ossau.uklinux.net>
> Gregory Marton <gremio@csail.mit.edu> writes:
>
>> The differences are not significant. I guess I wanted to make clear
>> in the test case that this isn't something to do with literal
>> rationals, and I didn't want the test case to be printing things to
>> the console.
>
> OK, thanks for explaining that. I assume that this test relates to
> the following NEWS item (for 1.8.2):
>
> ** Fractions were not `equal?' if stored in unreduced form.
> (A subtle problem, since printing a value reduced it, making it work.)
Yes.
> But doesn't that mean that your test needs to use an unreduced
> fraction, e.g. 2/4 instead of 1/2 ?
Now that I look more carefully at fractions.test, my assumption that a test
case was already added for that case seems to be incorrect. I'm happy to
try to add these tests as well.
> (Or does Guile have a strange idea of reduction which means that 1/2
> is not already a reduced form?)
This appears to me to be the case for guile 1.8.1 at least. I assume the
two bugs, if they were separate, were fixed together. I observed this
behavior in guile 1.8.1, but not 1.8.3.
Best,
Grem
--
------ __@ Gregory A. Marton http://csail.mit.edu/~gremio/
--- _`\<,_ .
-- (*)/ (*) Help! My inertia is gaining momentum!
~~~~~~~~~~~~~~~~-~~~~~~~~_~~~_~~~~~v~~~~^^^^~~~~~--~~~~~~~~~~~~~~~++~~~~~~~
prev parent reply other threads:[~2008-01-26 19:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-26 1:19 A passing test case Gregory Marton
2008-01-26 13:19 ` Neil Jerram
2008-01-26 14:28 ` Gregory Marton
2008-01-26 18:58 ` Neil Jerram
2008-01-26 19:09 ` Gregory Marton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.62.0801261405390.307@ashmore.csail.mit.edu \
--to=gremio@csail.mit.edu \
--cc=bug-guile@gnu.org \
--cc=neil@ossau.uklinux.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).