unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
From: Thamer Al-Harbash <tmh@whitefang.com>
Subject: Fix for guile-www/cgi.scm (cgi:make-cookie)
Date: Thu, 28 Aug 2003 10:53:34 -0400 (EDT)	[thread overview]
Message-ID: <Pine.BSF.4.51.0308281052000.83685@helena.whitefang.com> (raw)

This cgi::make-cookie breaks under guile-1.6 because it's using a
#&key and the (bound?) macro which seem to be no longer available
or depreciated. Please accept my patch below which fixes the
problem:

Index: cgi.scm
===================================================================
RCS file: /cvsroot/guile/guile/guile-www/cgi.scm,v
retrieving revision 1.6
diff -c -r1.6 cgi.scm
*** cgi.scm     27 Apr 2002 01:49:47 -0000      1.6
--- cgi.scm     28 Aug 2003 14:49:36 -0000
***************
*** 173,190 ****
      (and cookie-values (car cookie-values))))

  (define-public cgi:make-cookie
!   (lambda* (name value #&key path domain expires secure)
             (format #f "Set-Cookie: ~A=~A~A~A~A~A"
                     name value
!                    (if (bound? path)
                         (format #f "; path=~A" path) "")
!                    (if (bound? domain)
                         (format #f "; domain=~A" domain) "")
!                    (if (bound? expires)
                         (format #f "; expires=~A" expires) "")
!                    (if (and (bound? secure) secure)
                         "; secure" ""))))
-



  ;;; Internal functions.
--- 173,189 ----
      (and cookie-values (car cookie-values))))

  (define-public cgi:make-cookie
!   (lambda* (name value #:key path domain expires secure)
             (format #f "Set-Cookie: ~A=~A~A~A~A~A"
                     name value
!                    (if path
                         (format #f "; path=~A" path) "")
!                    (if domain
                         (format #f "; domain=~A" domain) "")
!                    (if expires
                         (format #f "; expires=~A" expires) "")
!                    (if secure
                         "; secure" ""))))



  ;;; Internal functions.


_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://mail.gnu.org/mailman/listinfo/bug-guile


             reply	other threads:[~2003-08-28 14:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-28 14:53 Thamer Al-Harbash [this message]
2003-08-29 10:44 ` Fix for guile-www/cgi.scm (cgi:make-cookie) Thien-Thi Nguyen
2003-08-29 13:00   ` Thamer Al-Harbash
2003-08-29 13:11     ` Thien-Thi Nguyen
2003-08-31 18:47   ` Marius Vollmer
2003-08-31 18:39 ` Marius Vollmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.BSF.4.51.0308281052000.83685@helena.whitefang.com \
    --to=tmh@whitefang.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).