* [PATCH] Fix bug: Init auto var to unrandomize `stack_depth' rv.
@ 2010-01-09 8:28 Thien-Thi Nguyen
0 siblings, 0 replies; 7+ messages in thread
From: Thien-Thi Nguyen @ 2010-01-09 8:28 UTC (permalink / raw)
To: bug-guile
First patch to Guile 1.9!
I prepared the following with "git format-patch -s", recopying the
Subject line, sans "[PATCH] ", and prefixing with a horizontal rule.
Is this ok? Do you prefer some other format? Most importantly:
Am i on the right path to regaining official repo write privs?
thi
_______________________________________________________________________
Fix bug: Init auto var to unrandomize `stack_depth' rv.
* stacks.c (stack_depth): Init `n'.
Signed-off-by: Thien-Thi Nguyen <ttn@gnuvola.org>
---
libguile/stacks.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/libguile/stacks.c b/libguile/stacks.c
index 61b7be3..ce16063 100644
--- a/libguile/stacks.c
+++ b/libguile/stacks.c
@@ -66,7 +66,7 @@ static SCM stack_id_with_fp (SCM frame, SCM **fp);
static long
stack_depth (SCM frame, SCM *fp)
{
- long n;
+ long n = 0;
/* count frames, skipping boot frames */
for (; scm_is_true (frame) && SCM_VM_FRAME_FP (frame) > fp;
frame = scm_frame_previous (frame))
--
1.6.3.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] Fix bug: Init auto var to unrandomize `stack_depth' rv.
@ 2010-01-09 10:01 Thien-Thi Nguyen
2010-01-09 22:29 ` Andy Wingo
0 siblings, 1 reply; 7+ messages in thread
From: Thien-Thi Nguyen @ 2010-01-09 10:01 UTC (permalink / raw)
To: bug-guile
Below is a revised patch, with updated ChangeLog entry
(includes "libguile/" prefix).
thi
____________________________________________________________________________
From 666e9de72a7dbaff3ee67a77b3efc981b33c44eb Mon Sep 17 00:00:00 2001
From: Thien-Thi Nguyen <ttn@gnuvola.org>
Date: Sat, 9 Jan 2010 09:12:49 +0100
Subject: [PATCH] Fix bug: Init auto var to unrandomize `stack_depth' rv.
* libguile/stacks.c (stack_depth): Init `n'.
Signed-off-by: Thien-Thi Nguyen <ttn@gnuvola.org>
---
libguile/stacks.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/libguile/stacks.c b/libguile/stacks.c
index 61b7be3..ce16063 100644
--- a/libguile/stacks.c
+++ b/libguile/stacks.c
@@ -66,7 +66,7 @@ static SCM stack_id_with_fp (SCM frame, SCM **fp);
static long
stack_depth (SCM frame, SCM *fp)
{
- long n;
+ long n = 0;
/* count frames, skipping boot frames */
for (; scm_is_true (frame) && SCM_VM_FRAME_FP (frame) > fp;
frame = scm_frame_previous (frame))
--
1.6.3.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] Fix bug: Init auto var to unrandomize `stack_depth' rv.
2010-01-09 10:01 Thien-Thi Nguyen
@ 2010-01-09 22:29 ` Andy Wingo
2010-01-10 17:41 ` Thien-Thi Nguyen
0 siblings, 1 reply; 7+ messages in thread
From: Andy Wingo @ 2010-01-09 22:29 UTC (permalink / raw)
To: Thien-Thi Nguyen; +Cc: bug-guile
On Sat 09 Jan 2010 11:01, Thien-Thi Nguyen <ttn@gnuvola.org> writes:
> Below is a revised patch, with updated ChangeLog entry
> (includes "libguile/" prefix).
Applied, along with some other patches.
If you're going to send patches like this, I'm very happy to apply them;
but it would be easier for me if you just sent the messages produced by
git-format-patch, so I could just pipe your whole message through
git-am.
As it is I have to edit the commit logs to cut until the
git-format-patch body.
Thanks for the patches!
Andy
--
http://wingolog.org/
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Fix bug: Init auto var to unrandomize `stack_depth' rv.
2010-01-09 22:29 ` Andy Wingo
@ 2010-01-10 17:41 ` Thien-Thi Nguyen
2010-01-12 19:35 ` Andy Wingo
2010-01-13 10:02 ` Ludovic Courtès
0 siblings, 2 replies; 7+ messages in thread
From: Thien-Thi Nguyen @ 2010-01-10 17:41 UTC (permalink / raw)
To: bug-guile
() Andy Wingo <wingo@pobox.com>
() Sat, 09 Jan 2010 23:29:34 +0100
Applied, along with some other patches.
Cool, thanks.
If you're going to send patches like this, I'm very happy to
apply them; but it would be easier for me if you just sent the
messages produced by git-format-patch, so I could just pipe
your whole message through git-am.
As it is I have to edit the commit logs to cut until the
git-format-patch body.
Often i include some kind of commentary describing the patch or
the motivation of the patch, etc. Where should i include that
info? Maybe "git-format-patch --attach"?
thi
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Fix bug: Init auto var to unrandomize `stack_depth' rv.
2010-01-10 17:41 ` Thien-Thi Nguyen
@ 2010-01-12 19:35 ` Andy Wingo
2010-01-13 10:02 ` Ludovic Courtès
1 sibling, 0 replies; 7+ messages in thread
From: Andy Wingo @ 2010-01-12 19:35 UTC (permalink / raw)
To: Thien-Thi Nguyen; +Cc: bug-guile
On Sun 10 Jan 2010 18:41, Thien-Thi Nguyen <ttn@gnuvola.org> writes:
> () Andy Wingo <wingo@pobox.com>
> () Sat, 09 Jan 2010 23:29:34 +0100
>
> Applied, along with some other patches.
>
> Cool, thanks.
>
> If you're going to send patches like this, I'm very happy to
> apply them; but it would be easier for me if you just sent the
> messages produced by git-format-patch, so I could just pipe
> your whole message through git-am.
>
> As it is I have to edit the commit logs to cut until the
> git-format-patch body.
>
> Often i include some kind of commentary describing the patch or
> the motivation of the patch, etc. Where should i include that
> info? Maybe "git-format-patch --attach"?
For me, if I would be interested in knowing it in a couple years, it
should go in the commit log. Otherwise I guess it is nice, and I should
finally learn how to use GNUS properly at some point...
Andy
--
http://wingolog.org/
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Fix bug: Init auto var to unrandomize `stack_depth' rv.
2010-01-10 17:41 ` Thien-Thi Nguyen
2010-01-12 19:35 ` Andy Wingo
@ 2010-01-13 10:02 ` Ludovic Courtès
2010-01-13 13:56 ` Thien-Thi Nguyen
1 sibling, 1 reply; 7+ messages in thread
From: Ludovic Courtès @ 2010-01-13 10:02 UTC (permalink / raw)
To: bug-guile
Hi,
Thien-Thi Nguyen <ttn@gnuvola.org> writes:
> Often i include some kind of commentary describing the patch or
> the motivation of the patch, etc. Where should i include that
> info? Maybe "git-format-patch --attach"?
I would advise adding explanatory comments in the code, rather than in
the log.
From the GCS (info "(standards) Change Log Concepts"):
There's no need to describe the full purpose of the changes or how
they work together. If you think that a change calls for explanation,
you're probably right. Please do explain it--but please put the
explanation in comments in the code, where people will see it whenever
they see the code. For example, "New function" is enough for the
change log when you add a function, because there should be a comment
before the function definition to explain what it does.
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Fix bug: Init auto var to unrandomize `stack_depth' rv.
2010-01-13 10:02 ` Ludovic Courtès
@ 2010-01-13 13:56 ` Thien-Thi Nguyen
0 siblings, 0 replies; 7+ messages in thread
From: Thien-Thi Nguyen @ 2010-01-13 13:56 UTC (permalink / raw)
To: bug-guile
() ludo@gnu.org (Ludovic Courtès)
() Wed, 13 Jan 2010 11:02:47 +0100
I would advise adding explanatory comments in the code,
rather than in the log.
Good point. Will keep it in mind.
thi
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-01-13 13:56 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-09 8:28 [PATCH] Fix bug: Init auto var to unrandomize `stack_depth' rv Thien-Thi Nguyen
-- strict thread matches above, loose matches on Subject: below --
2010-01-09 10:01 Thien-Thi Nguyen
2010-01-09 22:29 ` Andy Wingo
2010-01-10 17:41 ` Thien-Thi Nguyen
2010-01-12 19:35 ` Andy Wingo
2010-01-13 10:02 ` Ludovic Courtès
2010-01-13 13:56 ` Thien-Thi Nguyen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).