unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
* Bug in http module of guile-www
@ 2004-07-14  7:38 Robert Marlow
  2004-07-14 22:41 ` Thien-Thi Nguyen
  2004-07-14 22:58 ` Kevin Ryde
  0 siblings, 2 replies; 4+ messages in thread
From: Robert Marlow @ 2004-07-14  7:38 UTC (permalink / raw)


Hi all (I hope I'm posting this to the correct list. IIRC you guys also
handle guile-www)

I happened accross a bug in the HTTP module of guile-www which seemed to
trigger when I visited a page which gave no headers and just whitespace
in the body. In such a case the variable "second" of parse-status-line
gets bound to #f which messes up the later make-shared-substrings which
use it.

Admittedly I didn't really study the http module too much to figure out
what that procedure was meant to do or the exact nature of the fail, but
I did produce a quick fix which worked for my purposes. Whether it's
correct or not I have no idea. Anyway, it's simple enough for those who
would know such things to digest and decide:

139,140c139,144
<         (make-shared-substring statline (1+ first) second)
<         (make-shared-substring statline (1+ second)))))
---
>         (if second
>             (make-shared-substring statline (1+ first) second)
>             #f)
>         (if second
>             (make-shared-substring statline (1+ second))
>             #f))))


Apologies it's not in unified diff. The diff on this machine doesn't
seem to support it.

-- 
Regards,

Robert Marlow




_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2004-07-15  1:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-07-14  7:38 Bug in http module of guile-www Robert Marlow
2004-07-14 22:41 ` Thien-Thi Nguyen
2004-07-15  1:37   ` Kevin Ryde
2004-07-14 22:58 ` Kevin Ryde

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).