From: lloda <lloda@sarc.name>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 60234@debbugs.gnu.org
Subject: bug#60234: Build failure on mac os 12.6 / gcc 12.2
Date: Fri, 20 Jan 2023 10:38:18 +0100 [thread overview]
Message-ID: <DABCF605-96BB-413F-BFC2-9129279CDB7C@sarc.name> (raw)
In-Reply-To: <87k01h8tqd.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 2012 bytes --]
> On 18 Jan 2023, at 23:16, Ludovic Courtès <ludo@gnu.org <mailto:ludo@gnu.org>> wrote:
>
> Hi Daniel,
>
> lloda <lloda@sarc.name <mailto:lloda@sarc.name>> skribis:
>
>> .../libguile/threads.h:194:43: error: 'scm_i_current_thread' is defined with tls model global-dynamic
>> 194 | SCM_INTERNAL SCM_THREAD_LOCAL scm_thread *scm_i_current_thread;
>> | ^
>> .../libguile/threads.c:357:30: note: previously defined here as local-dynamic
>> 357 | SCM_THREAD_LOCAL scm_thread *scm_i_current_thread = NULL;
>>
>> Simply repeating SCM_INTERNAL in the .c fixes it...
>
> The problem is that ‘SCM_INTERNAL’ is synonymous with ‘extern’, which
> makes no sense for a definition (threads.c:357), so rightfully GCC
> GNU/Linux rightfully complains:
>
> --8<---------------cut here---------------start------------->8---
> CC libguile_3.0_la-threads.lo
> threads.c:358:43: warning: 'scm_i_current_thread' initialized and declared 'extern'
> 358 | SCM_INTERNAL SCM_THREAD_LOCAL scm_thread *scm_i_current_thread = NULL;
> | ^~~~~~~~~~~~~~~~~~~~
> --8<---------------cut here---------------end--------------->8---
>
> It’s just a warning, but still not looking good.
Hi,
Agreed, I had the same warning on mac os. Looked like the least bad choice...
> Is there something else at play, such as a ‘-ftls-model’ flag being
> passed to GCC somehow (info “(gcc) Code Gen Options")?
>
> If not, should we have:
>
> #define SCM_THREAD_LOCAL \
> __thread __attribute__ ((__tls_model__ ("global-dynamic")))
>
> instead (info "(gcc) Common Variable Attributes")?
>
> Would that work with Clang?
>
> Ludo’.
I don't seem to have any such flags.
The attribute does fix the issue on mac os with gcc 12.
I hadn't tried clang before, but I did now, and clang 14 works fine with or without the attribute. So the fix would only be for gcc.
Thanks
Daniel
[-- Attachment #2: Type: text/html, Size: 5727 bytes --]
prev parent reply other threads:[~2023-01-20 9:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 6:49 bug#60234: Build failure on mac os 12.6 / gcc 12.2 lloda
2022-12-21 7:06 ` lloda
2023-01-18 22:16 ` Ludovic Courtès
2023-01-20 9:38 ` lloda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DABCF605-96BB-413F-BFC2-9129279CDB7C@sarc.name \
--to=lloda@sarc.name \
--cc=60234@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).