From: lloda <lloda@sarc.name>
To: 61660@debbugs.gnu.org
Subject: bug#61660: [feature request] optimization of case-lambda
Date: Thu, 23 Feb 2023 20:00:04 +0100 [thread overview]
Message-ID: <CF5217BF-0AAD-476A-A5F2-B9AC040B0CBF@sarc.name> (raw)
In-Reply-To: <handler.60971.B.167424218722695.ack@debbugs.gnu.org>
[-- Attachment #1: Type: text/plain, Size: 39 bytes --]
Patch attached, tests tbd. Thoughts?
[-- Attachment #2: 0001-peval-reduces-some-inlined-case-lambda-calls.patch --]
[-- Type: application/octet-stream, Size: 1952 bytes --]
From a1f605598a7a49b2971072c8db635b788e209e3a Mon Sep 17 00:00:00 2001
From: Daniel Llorens <lloda@sarc.name>
Date: Thu, 23 Feb 2023 17:38:10 +0100
Subject: [PATCH] peval reduces some inlined case-lambda calls
* module/language/tree-il/peval.scm (peval): Reduce multiple case lambda
in <call> trees according to the number of arguments. Lambda cases
with more than required args (either optional, keyword, or rest
arguments) are ignored.
---
module/language/tree-il/peval.scm | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/module/language/tree-il/peval.scm b/module/language/tree-il/peval.scm
index 7945fd9b9..5c9799edb 100644
--- a/module/language/tree-il/peval.scm
+++ b/module/language/tree-il/peval.scm
@@ -1668,6 +1668,21 @@ top-level bindings from ENV and return the resulting expression."
(log 'inline-end result exp)
result)))))
+ (($ <lambda> src-proc meta body)
+ ;; If there are multiple cases and one matches nargs, omit all the others.
+ (or (and (lambda-case-alternate body)
+ (let ((nargs (length orig-args)))
+ (let loop ((body body))
+ (match body
+ (#f #f)
+ (($ <lambda-case> src-body req opt rest kw inits gensyms body alt)
+ (if (and (not opt) (not rest) (not kw) (= nargs (length req)))
+ (revisit-proc
+ (make-lambda
+ src-proc meta
+ (make-lambda-case src-body req opt rest kw inits gensyms body #f)))
+ (loop alt)))))))
+ (make-call src (for-call orig-proc) (map for-value orig-args))))
(($ <let> _ _ _ vals _)
;; Attempt to inline `let' in the operator position.
;;
--
2.30.2
next prev parent reply other threads:[~2023-02-23 19:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 19:16 bug#60971: build failure of v3.0.9rc1 on mac os 12.6 lloda
[not found] ` <handler.60971.B.167424218722695.ack@debbugs.gnu.org>
2023-02-23 19:00 ` lloda [this message]
2023-02-24 17:26 ` bug#61660: [feature request] optimization of case-lambda lloda
2023-02-27 10:11 ` Ludovic Courtès
2023-02-27 17:19 ` lloda
-- strict thread matches above, loose matches on Subject: below --
2023-02-20 17:56 lloda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CF5217BF-0AAD-476A-A5F2-B9AC040B0CBF@sarc.name \
--to=lloda@sarc.name \
--cc=61660@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).