From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Freja Nordsiek Newsgroups: gmane.lisp.guile.bugs Subject: bug#24657: Autoconf macro GUILE_PROGS only looks for guile without version suffix even if given version - patch included Date: Thu, 23 Feb 2017 23:31:46 +0100 Message-ID: References: <87bmttw8cv.fsf@pobox.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1487889133 2373 195.159.176.226 (23 Feb 2017 22:32:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 23 Feb 2017 22:32:13 +0000 (UTC) Cc: 24657-done@debbugs.gnu.org To: Andy Wingo Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Thu Feb 23 23:32:08 2017 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ch1vj-00005H-HX for guile-bugs@m.gmane.org; Thu, 23 Feb 2017 23:32:07 +0100 Original-Received: from localhost ([::1]:33270 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ch1vp-0002hW-D6 for guile-bugs@m.gmane.org; Thu, 23 Feb 2017 17:32:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44967) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ch1vj-0002eL-Up for bug-guile@gnu.org; Thu, 23 Feb 2017 17:32:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ch1ve-0004RI-74 for bug-guile@gnu.org; Thu, 23 Feb 2017 17:32:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55135) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ch1ve-0004RC-3a for bug-guile@gnu.org; Thu, 23 Feb 2017 17:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ch1vd-00009f-QZ for bug-guile@gnu.org; Thu, 23 Feb 2017 17:32:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Freja Nordsiek Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Thu, 23 Feb 2017 22:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24657 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Original-Received: via spool by 24657-done@debbugs.gnu.org id=D24657.1487889114581 (code D ref 24657); Thu, 23 Feb 2017 22:32:01 +0000 Original-Received: (at 24657-done) by debbugs.gnu.org; 23 Feb 2017 22:31:54 +0000 Original-Received: from localhost ([127.0.0.1]:53334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ch1vW-00009J-0z for submit@debbugs.gnu.org; Thu, 23 Feb 2017 17:31:54 -0500 Original-Received: from mail-wr0-f173.google.com ([209.85.128.173]:36774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ch1vU-000097-PD for 24657-done@debbugs.gnu.org; Thu, 23 Feb 2017 17:31:53 -0500 Original-Received: by mail-wr0-f173.google.com with SMTP id 89so2720993wrr.3 for <24657-done@debbugs.gnu.org>; Thu, 23 Feb 2017 14:31:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=1cKKqQLYRmc5PVvNKykG/tXXsaP8K50Gxoe/N9wlAOI=; b=nWrhzFyhf7S8cR75rt2QOVVhV2XoPiJr6TrX4kelfPkP/1ZmQk0UL4hMAy90YlY123 ZM9UX+2HXwfaPeIRCeg3Ct/rnXWdhv7otQBRZ5j9QOXAU2LHkyQHA2kOTqnoo759PnnF Z6GfWl1Utlo4Mt1x+wUtmQJACJOI8+soeMwdhVxbPiLmTHu7O1OYkAfRfcvWtPRv5blX 9Qk7bDb9Dl5bYsDdSPhSo+BDDok1Bqb8doDTLYeOVmHT+JfHHBSoWU1WSk3ZeP2+UFMd lumhf1k0ej/aPcq9gJwhnyf6jodqS0pYgk4X9a0PTqL151AYHbpOpbCxAPXGDDxuiyOt yO9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1cKKqQLYRmc5PVvNKykG/tXXsaP8K50Gxoe/N9wlAOI=; b=EqMYdsJwXXVOUkMME2VtXSMHDLDOvbBYB39fi26nno8PDpnUdJj5F8J4v6Rs3wzH7C kx51/qCOEaPhe9F6UfCDYMxrwqvY/diTvEm92MSDwL1m8dz5T8O9fVGLIvP1nTZuBm9L qroDlO+6CxlarHnRjdZidKNt8gjBsNNas85CzmwjHHub/oQGva7YxzGjtySkKdBCskiB 7SublZ28Ovy6dw9CQ0ZHgN2FzV2vh/hV7bHRHAgSFZGaWI7kWcEBVZUn0RDhqtkFkbzg 11H9ljzbqFYGm4kWA2+1LgCCP2LNzBYsA3hB6Rxq+tLpo/QgnoX5mJ/ZthRusJpi6q3J OkcQ== X-Gm-Message-State: AMke39nNApD82wdwpnGwF6s6h65EneP8VnCzRWL2kZs45uuv2fDfR+xsDNOsDPuIhW7TnrYArpea0+sfuWtg/g== X-Received: by 10.223.131.97 with SMTP id 88mr4522014wrd.202.1487889106918; Thu, 23 Feb 2017 14:31:46 -0800 (PST) Original-Received: by 10.28.143.142 with HTTP; Thu, 23 Feb 2017 14:31:46 -0800 (PST) In-Reply-To: <87bmttw8cv.fsf@pobox.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:8570 Archived-At: Andy, Your modifications to the patch make it a bit better since it will handle the case where guile 2.2 gets put under the name guile-2 or guile2. GIven how much more similar guile 2.1.x (and eventually 2.2.x) are to guile 2.0.x than guile 2.0.x is to guile 1.8.x, this is not too unlikely on distribution or another at some point. Only one potential issue. On the off chance that the guile program found by AC_PATH_PROGS is in the current directory and the absolute path is not given nor a prefix of "./", it might be better to replace _guile_suffix=`echo "$GUILE" | sed -e 's,^.*/guile\(.*\)$,\1,'` with _guile_suffix=`basename "$GUILE" | sed -e 's,^.*guile\(.*\)$,\1,'` which replaces echo with basename to remove all the directory information and then '/' is not looked for in the sed script anymore. Freja On Thu, Feb 23, 2017 at 10:43 AM, Andy Wingo wrote: > Hi Freja, > > Thanks for this bug report and the patch, and sorry for the delay :) > > On Mon 10 Oct 2016 11:45, Freja Nordsiek writes: > >> While trying to build a package that uses guile with autotools, I >> found a problem in the provided GUILE_PROGS macro. >> >> The macro searches for the executables guile, guild, guile-config, and >> guile-tools. The problem is that even if the macro is given the >> version, it only looks for guile, guild, etc. with no version suffix. > > Applied your patch with some small modifications; attached. Let me know > if it works for you! > > Andy >