From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Israelsson Tampe Newsgroups: gmane.lisp.guile.bugs Subject: bug#32644: bytevector bug Date: Fri, 14 Sep 2018 20:44:35 +0200 Message-ID: References: <87a7ousfio.fsf@netris.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000b5ae250575d9378d" X-Trace: blaine.gmane.org 1536950597 15567 195.159.176.226 (14 Sep 2018 18:43:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 14 Sep 2018 18:43:17 +0000 (UTC) Cc: 32644@debbugs.gnu.org To: Mark H Weaver Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Fri Sep 14 20:43:13 2018 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g0t3a-0003oG-Jm for guile-bugs@m.gmane.org; Fri, 14 Sep 2018 20:43:06 +0200 Original-Received: from localhost ([::1]:52949 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g0t5g-00089C-Vq for guile-bugs@m.gmane.org; Fri, 14 Sep 2018 14:45:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40666) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g0t5Z-00088r-PH for bug-guile@gnu.org; Fri, 14 Sep 2018 14:45:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g0t5V-0005nV-Ds for bug-guile@gnu.org; Fri, 14 Sep 2018 14:45:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36652) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g0t5R-0005k7-TE for bug-guile@gnu.org; Fri, 14 Sep 2018 14:45:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g0t5R-0003OR-Nj for bug-guile@gnu.org; Fri, 14 Sep 2018 14:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Israelsson Tampe Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Fri, 14 Sep 2018 18:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32644 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Original-Received: via spool by 32644-submit@debbugs.gnu.org id=B32644.153695069413017 (code B ref 32644); Fri, 14 Sep 2018 18:45:01 +0000 Original-Received: (at 32644) by debbugs.gnu.org; 14 Sep 2018 18:44:54 +0000 Original-Received: from localhost ([127.0.0.1]:40910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g0t5K-0003Nt-59 for submit@debbugs.gnu.org; Fri, 14 Sep 2018 14:44:54 -0400 Original-Received: from mail-vs1-f52.google.com ([209.85.217.52]:34973) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g0t5I-0003Ne-8Z for 32644@debbugs.gnu.org; Fri, 14 Sep 2018 14:44:52 -0400 Original-Received: by mail-vs1-f52.google.com with SMTP id m26-v6so817322vso.2 for <32644@debbugs.gnu.org>; Fri, 14 Sep 2018 11:44:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6ToVUp7LePTESHRgBB56rnbjqqGHQr2llzAmep8eK+U=; b=nf5zjf4CoDg7vIZOBPQSXCmZ5ZQr+jKNnrNunHnWm6HtP2YduoObMecqaKgm71Abla gcTsPL06TglqXPT7z+f1zWUIYTwFa37UChLASNDGktvDGRerA8u9Yj1GhrPuXulRilQ4 b1XDaJaEjROef1kjBoQ4w2XUXgXC0KObUhkSNGoaDFRulnoaOb77PNalAd/mxTvJ0EpS VosV9JpNe32uDZHUzxBQzbLbVjw2k4lEgce5g3RJS4FtDu5eiLi2yhET2BTs+64R84dd JFzdx25rVTLlmPj/mIa71UXQOY5Lu47i2DL0CWP1WdF/UXQzKsKqfiljwYZF3B8lfllz JQvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6ToVUp7LePTESHRgBB56rnbjqqGHQr2llzAmep8eK+U=; b=ExOXSQEMItN6vNDzBXYdGVnfCmjDmzeO9IojRc8C/Wd0Bo3WayG+SccWjOlRESY0Df bt1An2ECKhNycIW7KUwPEYqFQIU92AjCmI6GOe/EoTX6Irx8K03mhCtZUDoXefdoktGY bRaFAOXhZXIYWL6MftcKfMgsDMGOoVDlGhq1H9VhyA4LGP/lovXoHScXXdb1zag8MhfT 4W2rBm6sMkXamBmHNZy1R4mkQRjYf2W+DUbzv5mBZ3pgB6MYVFFpTTlEJOhI2X9cEbvD o528vFog4TMLJUorxcAeLmhIlXiUXC5p5d2pztkMcvV3i+/6eapltj2a9v2bx2g0aUXt /4og== X-Gm-Message-State: APzg51CjTO3BpYT2B2ryN6+g0KdysofCA343/jOVC4dEVjUc8KJlOZeV WuMEWt4wF5YCjNIpQN2BoHrmiZWWSgn+Kn7QsLo= X-Google-Smtp-Source: ANB0VdYiiOayWNKERR9KlrQduom36ytisOLGHOWjGDtUjiBRUME3Evm4CV63LVo/THYMT26hGZv+65ngGBjF6SepJU0= X-Received: by 2002:a67:4e53:: with SMTP id c80-v6mr4168312vsb.32.1536950686558; Fri, 14 Sep 2018 11:44:46 -0700 (PDT) In-Reply-To: <87a7ousfio.fsf@netris.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:9161 Archived-At: --000000000000b5ae250575d9378d Content-Type: text/plain; charset="UTF-8" I managed to get it to compile on the latest lightning branch as of 2018-09-14 On Thu, Sep 6, 2018 at 7:28 PM Mark H Weaver wrote: > Stefan Israelsson Tampe writes: > > > The code velow does not compile when the define-inlinable of id is > active. If in stead > > id defined by define is used it all compiles just fine. > > > > Tested on latest tar ball for guile 2.4 > > Did you mean to write guile 2.2.4? > > Mark > > > > ------------------------------------------- > > (use-modules (rnrs bytevectors)) > > > > (define-inlinable (id x) x) > > ;(define (id x) x) > > (define-syntax-rule (mkcrc crc_hqx high xor mask) > > (define (crc_hqx data value) > > (let ((n (bytevector-length data)) > > (d data)) > > (let lp ((i 0) (v value)) > > (if (< i n) > > (let ((b (id (bytevector-u8-ref d i)))) > > (let lp2 ((j 0) (x 1) (v v)) > > (if (> j -8) > > (let ((bit (ash (logand x b) j)) > > (hbit (logand v high))) > > (if (= hbit 0) > > (lp2 (- j 1) (ash x 1) (logior bit (ash v 1))) > > (lp2 (- j 1) (ash x 1) (logxor > > xor > > (logand mask > > (logior > > bit > > (ash v 1))))))) > > (lp (+ i 1) v)))) > > v))))) > > > > (mkcrc crc_hqx #x8000 #x1021 #xffff) > > (mkcrc crc32 #x80000000 #x04c11db7 #xffffffff) > --000000000000b5ae250575d9378d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I managed to get it to compile on the latest lightning bra= nch as of 2018-09-14

O= n Thu, Sep 6, 2018 at 7:28 PM Mark H Weaver <mhw@netris.org> wrote:
stefan.itampe@gmail.com> writes:

> The code velow does not compile when the define-inlinable of id is act= ive. If in stead
> id defined by define is used it all compiles just fine.
>
> Tested on latest tar ball for guile 2.4

Did you mean to write guile 2.2.4?

=C2=A0 =C2=A0 =C2=A0 Mark


> -------------------------------------------
> (use-modules (rnrs bytevectors))
>
> (define-inlinable (id x) x)
> ;(define (id x) x)
> (define-syntax-rule (mkcrc crc_hqx high xor mask)
>=C2=A0 =C2=A0(define (crc_hqx data value)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 (let ((n (bytevector-length data))
>=C2=A0 =C2=A0 =C2=A0 (d data))
> (let lp ((i 0) (v value))
>=C2=A0 =C2=A0 (if (< i n)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 (let ((b (id (bytevector-u8-ref d i))))
> (let lp2 ((j 0) (x 1) (v v))
>=C2=A0 =C2=A0 (if (> j -8)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 (let ((bit=C2=A0 =C2=A0(ash (logand x b) j)= )
>=C2=A0 =C2=A0 =C2=A0 (hbit=C2=A0 (logand v high)))
> (if (=3D hbit 0)
>=C2=A0 =C2=A0 =C2=A0 (lp2 (- j 1) (ash x 1) (logior bit (ash v 1)))
>=C2=A0 =C2=A0 =C2=A0 (lp2 (- j 1) (ash x 1) (logxor
>=C2=A0 =C2=A0 =C2=A0 xor
>=C2=A0 =C2=A0 =C2=A0 (logand mask
>=C2=A0 =C2=A0 =C2=A0 (logior
>=C2=A0 =C2=A0 =C2=A0 =C2=A0bit
>=C2=A0 =C2=A0 =C2=A0 =C2=A0(ash v 1)))))))
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 (lp (+ i 1) v))))
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 v)))))
>
> (mkcrc crc_hqx #x8000=C2=A0 =C2=A0 =C2=A0#x1021=C2=A0 =C2=A0 =C2=A0#xf= fff)
> (mkcrc crc32=C2=A0 =C2=A0#x80000000 #x04c11db7 #xffffffff)
--000000000000b5ae250575d9378d--