From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Israelsson Tampe Newsgroups: gmane.lisp.guile.bugs Subject: bug#21883: unnecessary bit shifting range limits Date: Mon, 15 Oct 2018 09:08:51 +0200 Message-ID: References: <20151112070725.GA875@fysh.org> <87tvlpszzu.fsf@netris.org> <87a7ngtblz.fsf@netris.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000000d280605783f1ccc" X-Trace: blaine.gmane.org 1539587236 333 195.159.176.226 (15 Oct 2018 07:07:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 15 Oct 2018 07:07:16 +0000 (UTC) Cc: 21883@debbugs.gnu.org, Zefram To: Mark H Weaver Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Mon Oct 15 09:07:11 2018 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gBwy5-0008R0-I8 for guile-bugs@m.gmane.org; Mon, 15 Oct 2018 09:07:09 +0200 Original-Received: from localhost ([::1]:50740 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gBx0B-0003yt-Q8 for guile-bugs@m.gmane.org; Mon, 15 Oct 2018 03:09:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52331) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gBwzz-0003vi-EA for bug-guile@gnu.org; Mon, 15 Oct 2018 03:09:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gBwzw-0001dL-9i for bug-guile@gnu.org; Mon, 15 Oct 2018 03:09:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45476) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gBwzw-0001dB-5C for bug-guile@gnu.org; Mon, 15 Oct 2018 03:09:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gBwzu-00030w-67 for bug-guile@gnu.org; Mon, 15 Oct 2018 03:09:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Israelsson Tampe Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Mon, 15 Oct 2018 07:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21883 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Original-Received: via spool by 21883-submit@debbugs.gnu.org id=B21883.153958734111580 (code B ref 21883); Mon, 15 Oct 2018 07:09:02 +0000 Original-Received: (at 21883) by debbugs.gnu.org; 15 Oct 2018 07:09:01 +0000 Original-Received: from localhost ([127.0.0.1]:49734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gBwzt-00030i-1P for submit@debbugs.gnu.org; Mon, 15 Oct 2018 03:09:01 -0400 Original-Received: from mail-ua1-f41.google.com ([209.85.222.41]:43636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gBwzq-00030O-1T for 21883@debbugs.gnu.org; Mon, 15 Oct 2018 03:08:59 -0400 Original-Received: by mail-ua1-f41.google.com with SMTP id c89so1644526uac.10 for <21883@debbugs.gnu.org>; Mon, 15 Oct 2018 00:08:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=/qc5Ip8hNC/pcGnHbJP4W6ZUdi69jn1GEv96Av8wfxY=; b=ARxm1REjX0+RFLAmkeW+krcj1Pz6w1YeA4jUmb2YORQr1LLha3JyYoNgPebb00JRjT HyQUn/zxUsU0mJZVLLPIfpfaO80WrPPHYZMSU2A+vCnZ0kmGgg5pQdltTmrhekVUEufH tA0rrKj78zFWh0G3U+ypCp9/T8cP2FkNgbvlv243pI36ommcJA/oBVgwZnzLgX92ayiZ Vyxa3YQDjR1awgZ9ZFcciiuQc3vls31bFS6eM5hVxVPEU6j808qPVsXdAZji8wXD2dnh AzJEVg4FhXORw0HyAck/Gy+umtO6mx+qwHtSyoXwc0Mp4MDpDpP5i4XMWV41goMXMpiS R9yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=/qc5Ip8hNC/pcGnHbJP4W6ZUdi69jn1GEv96Av8wfxY=; b=lrr42hqmaiBpj3Q19Ehsz2kxcqAf45TirKBbhg/PZIQnjGo12NuuWa82kQnMhxiLha XP3uUOMx0+apAZI9/qLBb04+qMQ+ldamN/ZnMZOpvBTOTeWlqSscdJ+uM8XWIg0t7uRi 3JXNm16Uq44Rvzx9N1yBvBVZaiNj++u/o8bIeLUVSV4FfK1tcHQG+sSGhNjLkWNY7di0 tpmr0VjGqG7RH78T56sNJP5FGxAsZ3ZvqaGWpEtxgdYalAfW5vJidnN13ZJN3I2U6KuT f66HstGlg94m0/HZT9w7tbSVLaHVPIYKLtudtpqpMigP5RioulOTrXt8ti3KCslFdrWa +6Jw== X-Gm-Message-State: ABuFfogjvIFdC5K+Ty6V5juH7YH9UskCIwFeVcGOYIEFTcwcepW4EWhy VwGepMBhXh7ggOsn64pq7+kGUwgHs504kAVkjFE= X-Google-Smtp-Source: ACcGV60rFSp9CvZYLeQN6M94d4UCur+v6tRqLB0oIHmIUrbBj59KywlEeLPuP7+ttOQE4sdImaj3hq2LRHswHnvnEyU= X-Received: by 2002:ab0:24a:: with SMTP id 68-v6mr6861456uas.25.1539587332448; Mon, 15 Oct 2018 00:08:52 -0700 (PDT) Original-Received: by 2002:a1f:2801:0:0:0:0:0 with HTTP; Mon, 15 Oct 2018 00:08:51 -0700 (PDT) Original-Received: by 2002:a1f:2801:0:0:0:0:0 with HTTP; Mon, 15 Oct 2018 00:08:51 -0700 (PDT) In-Reply-To: <87a7ngtblz.fsf@netris.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:9193 Archived-At: --0000000000000d280605783f1ccc Content-Type: text/plain; charset="UTF-8" i think you got it. sorry for the fuzz. Den 15 okt 2018 12:19 AM skrev "Mark H Weaver" : > Stefan Israelsson Tampe writes: > > how would this slow down the code. just add the correction where you > > throw the exception which should be in a branch outside the hot path. > > If you have a suggestion that's simpler than what I did in commits > 011aec7e, 9448a078, and 1990aa91, and just as fast in the common cases, > feel free to propose a patch. The words above are insufficient. > > Mark > --0000000000000d280605783f1ccc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
i think you got it. sorry for the fuzz.
=

D= en 15 okt 2018 12:19 AM skrev "Mark H Weaver" <mhw@netris.org>:
Stefan Israelsson Tampe <stefan.itampe@gmail.com> writes:
> how would this slow down the code. just add the correction where you > throw the exception which should be in a branch outside the hot path.<= br>
If you have a suggestion that's simpler than what I did in commits
011aec7e, 9448a078, and 1990aa91, and just as fast in the common cases,
feel free to propose a patch.=C2=A0 The words above are insufficient.

=C2=A0 =C2=A0 =C2=A0 Mark
--0000000000000d280605783f1ccc--