bug#20645: sxml xpath exports "filter"

bug#20645: sxml xpath exports "filter"

[Matt Wette]

sxml xpath exports "filter" which is incompatible with the common procedure of the same name.

I suggest renaming unless it breaks a lot of code.

I use

  #:use-module ((sxml xpath)
		#:renamer (lambda (s) (if (eq? s 'filter) 'xp-filter s)))

but would rather other agree that renaming in sxml/xpath.scm is better.

Matt

bug#20645: sxml xpath exports "filter"

[Matt Wette]

This is a very annoying "bug".  The (sxml xpath) “filter” procedure overrides the builtin guile “filter”.

I believe the fix can be implemented with the following changes to (sxml xpath):
1) (define node-filter filter)
2) In the #:export list, replace “filter” with “node-filter”

Matt

bug#20645: sxml xpath exports "filter"

[Thompson, David]

On Mon, Feb 8, 2016 at 11:03 PM, Matt Wette <mwette@alumni.caltech.edu> wrote:
> This is a very annoying "bug".  The (sxml xpath) “filter” procedure overrides the builtin guile “filter”.
>
> I believe the fix can be implemented with the following changes to (sxml xpath):
> 1) (define node-filter filter)
> 2) In the #:export list, replace “filter” with “node-filter”

Is this really a bug?  The module system allows names to have
different meanings without conflicting in a global namespace.  When
importing a module, you can choose which symbols to import, or prefix
all of the symbols with something.

- Dave

bug#20645: sxml xpath exports "filter"

[Mark H Weaver]

Matt Wette <mwette@alumni.caltech.edu> writes:

> This is a very annoying "bug".  The (sxml xpath) “filter” procedure overrides the builtin guile “filter”.
>
> I believe the fix can be implemented with the following changes to (sxml xpath):
> 1) (define node-filter filter)
> 2) In the #:export list, replace “filter” with “node-filter”

We can't do this because it would break existing code that uses 'filter'
from (sxml xpath), and also introduce a Guile-specific change to the API
of a portable library.

However, you can rename 'filter' at import time as follows:

  (use-modules ((sxml xpath) #:select ((filter . node-filter))))

Does this work for you?

    Mark

bug#20645: sxml xpath exports "filter"

[Mark H Weaver]

Mark H Weaver <mhw@netris.org> writes:

> Matt Wette <mwette@alumni.caltech.edu> writes:
>
>> This is a very annoying "bug".  The (sxml xpath) “filter” procedure overrides the builtin guile “filter”.
>>
>> I believe the fix can be implemented with the following changes to (sxml xpath):
>> 1) (define node-filter filter)
>> 2) In the #:export list, replace “filter” with “node-filter”
>
> We can't do this because it would break existing code that uses 'filter'
> from (sxml xpath), and also introduce a Guile-specific change to the API
> of a portable library.
>
> However, you can rename 'filter' at import time as follows:
>
>   (use-modules ((sxml xpath) #:select ((filter . node-filter))))
>
> Does this work for you?

Having not heard back for 19 weeks, I'm closing this bug now.

      Mark