From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Matt Wette Newsgroups: gmane.lisp.guile.bugs Subject: bug#25786: [PATCH] use of abs() in numbers.c: should be labs() Date: Sat, 18 Feb 2017 09:46:07 -0800 Message-ID: <90F3BCE0-765F-43F6-B3ED-7B339EF9B2F0@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Content-Type: multipart/alternative; boundary="Apple-Mail=_13E92D88-44DC-4AEE-BFED-7E91847C6064" X-Trace: blaine.gmane.org 1487440039 508 195.159.176.226 (18 Feb 2017 17:47:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 18 Feb 2017 17:47:19 +0000 (UTC) To: 25786@debbugs.gnu.org Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Sat Feb 18 18:47:12 2017 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf96D-0007tn-94 for guile-bugs@m.gmane.org; Sat, 18 Feb 2017 18:47:09 +0100 Original-Received: from localhost ([::1]:59355 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cf96I-00036f-P1 for guile-bugs@m.gmane.org; Sat, 18 Feb 2017 12:47:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cf96A-00035U-3l for bug-guile@gnu.org; Sat, 18 Feb 2017 12:47:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cf967-0008Jq-0U for bug-guile@gnu.org; Sat, 18 Feb 2017 12:47:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47056) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cf966-0008Jm-T1 for bug-guile@gnu.org; Sat, 18 Feb 2017 12:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cf966-0002Hw-JV for bug-guile@gnu.org; Sat, 18 Feb 2017 12:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Matt Wette Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Sat, 18 Feb 2017 17:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 25786 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-guile@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.14874399858745 (code B ref -1); Sat, 18 Feb 2017 17:47:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 18 Feb 2017 17:46:25 +0000 Original-Received: from localhost ([127.0.0.1]:45255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf95V-0002Gy-JI for submit@debbugs.gnu.org; Sat, 18 Feb 2017 12:46:25 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:45455) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf95T-0002Gj-9G for submit@debbugs.gnu.org; Sat, 18 Feb 2017 12:46:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cf95M-0008Bz-Qv for submit@debbugs.gnu.org; Sat, 18 Feb 2017 12:46:17 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:41009) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cf95M-0008Bv-NP for submit@debbugs.gnu.org; Sat, 18 Feb 2017 12:46:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36412) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cf95L-0002Yv-Jh for bug-guile@gnu.org; Sat, 18 Feb 2017 12:46:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cf95I-00089h-HX for bug-guile@gnu.org; Sat, 18 Feb 2017 12:46:15 -0500 Original-Received: from mail-pg0-x231.google.com ([2607:f8b0:400e:c05::231]:35086) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cf95I-00089U-7v for bug-guile@gnu.org; Sat, 18 Feb 2017 12:46:12 -0500 Original-Received: by mail-pg0-x231.google.com with SMTP id b129so2911209pgc.2 for ; Sat, 18 Feb 2017 09:46:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:mime-version:subject:message-id:date:to; bh=+0jtwY6etoDTKOjzblwQYLJqRYZaIrzg/Ef6MUfj44w=; b=W3dEdqnUBDRuC57G71EpOX0IY1NhggxzdVj42BzYtj3XBGC96sguD+LK76hgDnduqX amaWVHq9ZcVz/X3LtbcQ7IwMb9nkuTAlVZWhsx5kt30h042TduyjE7WDvWB+Z8Mo4xxz vYB9vbxFrzmKk1qJIJ1Zh7Pu2H4nD6E9P63642VNnVMrYoqCeqS70ZYt0NtPQ58scFLc ye/gqSY0bY9MTGOFcPoGAzlsElMk8CYf9exJKaXef+y/u0OLei9Rnq7M2Gl3aSZXmIEX gXfPpof7MId5NcqbZDywEtYgbYU7VFu8q1X6ikhAnlzOhKiqCuXnSJF8Mq9LxvgfBab7 UYnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:subject:message-id:date:to; bh=+0jtwY6etoDTKOjzblwQYLJqRYZaIrzg/Ef6MUfj44w=; b=dhcqWWG1kzD/K+hlX7I+vlVp2ChIgcobimbipSrbcJqqRJyXH7hnr38lJ9H2h1bJxp cye3nmtHkQVqFDu5eflQVsI0B1nqaVJetXLBVqWn+KsDoULLM9r/yXpUGBWpn2JUJY8X I//gujNSCJQrvd0jZAEpI2LEiMUKHu4oyGEx99bdjrthRowogj727mFHnkX+JRpf5jy2 iyrZKlhmJ9W/TFU+fPti4wEUWMtureYZDbOERvDSo6cMhzdWyyEHbRhcKe5tXJ16PFaN yU2tP3/BetXMu3/+meL1adHpyATTXEOg4cg4atcoG2iesnkKItW+UoDsqO/w6MkRnC78 5LBg== X-Gm-Message-State: AMke39mLpskwVCJpqZPC/yLlPSN57y39F6TbAAznMshtFRHo3o9+mKyy/CbLCcS9jO5YqA== X-Received: by 10.98.198.199 with SMTP id x68mr16171062pfk.87.1487439970770; Sat, 18 Feb 2017 09:46:10 -0800 (PST) Original-Received: from nautilus.championbroadband.com (216-165-246-244.championbroadband.com. [216.165.246.244]) by smtp.gmail.com with ESMTPSA id q26sm2865559pfg.47.2017.02.18.09.46.09 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 18 Feb 2017 09:46:09 -0800 (PST) X-Mailer: Apple Mail (2.3259) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:8548 Archived-At: --Apple-Mail=_13E92D88-44DC-4AEE-BFED-7E91847C6064 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii In libguile/numbers.c abs() is used for long argument where labs() = should be used. =20 A patch is included below for guile-2.1.7. /* Returns log(n/d), for exact non-zero integers n and d */ static SCM log_of_fraction (SCM n, SCM d) { long n_size =3D scm_to_long (scm_integer_length (n)); long d_size =3D scm_to_long (scm_integer_length (d)); if (abs (n_size - d_size) > 1) return (scm_difference (log_of_exact_integer (n), log_of_exact_integer (d))); --- libguile/numbers.c.orig 2017-02-18 08:29:52.000000000 -0800 +++ libguile/numbers.c 2017-02-18 08:30:23.000000000 -0800 @@ -9951,7 +9951,7 @@ long n_size =3D scm_to_long (scm_integer_length (n)); long d_size =3D scm_to_long (scm_integer_length (d)); =20 - if (abs (n_size - d_size) > 1) + if (labs (n_size - d_size) > 1) return (scm_difference (log_of_exact_integer (n), log_of_exact_integer (d))); else if (scm_is_false (scm_negative_p (n))) --Apple-Mail=_13E92D88-44DC-4AEE-BFED-7E91847C6064 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii In = libguile/numbers.c abs() is used for long argument where labs() should = be used.  
A patch is included below for guile-2.1.7.

/* Returns = log(n/d), for exact non-zero integers n and d */
static SCM
log_of_fraction = (SCM n, SCM d)
{
  long n_size =3D scm_to_long = (scm_integer_length (n));
  long d_size = =3D scm_to_long (scm_integer_length (d));

  if (abs = (n_size - d_size) > 1)
    = return (scm_difference (log_of_exact_integer = (n),
          =                   = log_of_exact_integer (d)));


--- = libguile/numbers.c.orig 2017-02-18 08:29:52.000000000 = -0800
+++ libguile/numbers.c 2017-02-18 08:30:23.000000000 = -0800
@@ -9951,7 +9951,7 @@
   long n_size =3D = scm_to_long (scm_integer_length (n));
   long d_size =3D = scm_to_long (scm_integer_length (d));
 
-  if (abs = (n_size - d_size) > 1)
+  if (labs (n_size - d_size) > = 1)
     return (scm_difference = (log_of_exact_integer (n),
    =  log_of_exact_integer (d)));
   else if (scm_is_false = (scm_negative_p (n)))

= --Apple-Mail=_13E92D88-44DC-4AEE-BFED-7E91847C6064--