unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
From: Mark H Weaver <mhw@netris.org>
To: <dsmich@roadrunner.com>
Cc: bug-guile@gnu.org, Francis Southern <francis.southern@gmail.com>
Subject: Re: Stable 2.0 and popen.test on Debian Squeeze
Date: Wed, 02 Mar 2011 05:40:09 -0500	[thread overview]
Message-ID: <87zkpdrek6.fsf@netris.org> (raw)
In-Reply-To: <20110302013257.1DDMP.140430.root@cdptpa-web28-z02> (dsmich@roadrunner.com's message of "Tue, 1 Mar 2011 20:32:56 -0500")

<dsmich@roadrunner.com> writes:
> dsmith@stumpy:~/src/guile$ ./check-guile popen.test
> Testing /home/dsmith/src/guile/meta/guile ... popen.test
> with GUILE_LOAD_PATH=/home/dsmith/src/guile/test-suite
> Running popen.test
> FAIL: popen.test: open-output-pipe: no duplicate

The problem here is that "dash -c COMMAND" runs COMMAND as a subprocess
of dash, whereas "bash -c COMMAND" which uses exec such that COMMAND
replaces the bash process.

dash's behavior breaks the "open-output-pipe: no duplicate" test, which
checks that the parent will receive a SIGPIPE if the child closes its
STDIN without terminating.  This depends on the child not keeping a
duplicate of that file descriptor around (as was done in Guile 1.6.4),
hence the name of the test.

Because "dash -c" creates a subprocess instead of exec'ing, the waiting
dash process is holding a duplicate of its STDIN open.  This prevents
the child from closing the end of the pipe, and thus the parent does not
receive a SIGPIPE and the test fails.

     Mark



  reply	other threads:[~2011-03-02 10:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-25  5:01 Stable 2.0 and popen.test on Debian Squeeze Francis Southern
2011-02-27 22:07 ` Andy Wingo
2011-03-01 19:40   ` Mark H Weaver
2011-03-02  1:32     ` dsmich
2011-03-02 10:40       ` Mark H Weaver [this message]
2011-03-02 11:17       ` Mark H Weaver
2011-03-02 11:28         ` dsmich
  -- strict thread matches above, loose matches on Subject: below --
2011-03-02 11:29 dsmich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zkpdrek6.fsf@netris.org \
    --to=mhw@netris.org \
    --cc=bug-guile@gnu.org \
    --cc=dsmich@roadrunner.com \
    --cc=francis.southern@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).