From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Maxim Cournoyer Newsgroups: gmane.lisp.guile.bugs Subject: bug#71684: [PATCH v2] doc: Document the peek and pk procedures. Date: Sat, 14 Sep 2024 00:42:39 +0900 Message-ID: <87zfobtv9s.fsf@gmail.com> References: <87jzi45tyn.fsf@gmail.com> <20240702164418.11886-1-juli@incana.org> <878qy9glbd.fsf@gmail.com> <877cdtuixm.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27080"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 71684@debbugs.gnu.org, Simon Tournier To: Juliana Sims Original-X-From: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Fri Sep 13 17:44:06 2024 Return-path: Envelope-to: guile-bugs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sp8Ss-0006v5-IF for guile-bugs@m.gmane-mx.org; Fri, 13 Sep 2024 17:44:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sp8Sg-00024r-Pi; Fri, 13 Sep 2024 11:43:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sp8Se-0001vI-Pl for bug-guile@gnu.org; Fri, 13 Sep 2024 11:43:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sp8Se-0002iT-Fi for bug-guile@gnu.org; Fri, 13 Sep 2024 11:43:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=3qsMdFX6HiBkk3OWluMoYMdvEQDfmsz2Zmg1DcJN59I=; b=uU6x2SIqUCb5JK9fhbLt3KmpdnW7Gslp0KjeSjD//g2RrazUSVWQQi1EH79n+T1LGwVa9zzLzrW8lQaPoSOnv1X4ez7MRKrin/zT4dBCyba+AF1rM5f1IXvEmxraxGhn9JsFx7+Ey8nkyZFB6anRNNju9DrmS5QwoFQC+kB7tPPUdHiP0JnE94yud7kpDGsALuaL1LeMb7NAkhRoznMXMhA+EsipJiG+mvuyrrrjzGGYE+j6UbtgH5gJ8QYqbbvkOsOdD0CaWkZh2pjlv69DcRJVhqgWAjRkK3/JNynKPetcZMpIFjxPEEIQtZLU40Wd/ZAVKP2zzhbP8wmOSrjsuw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sp8Sn-0006s8-OA for bug-guile@gnu.org; Fri, 13 Sep 2024 11:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Fri, 13 Sep 2024 15:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71684 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch Original-Received: via spool by 71684-submit@debbugs.gnu.org id=B71684.172624224126402 (code B ref 71684); Fri, 13 Sep 2024 15:44:01 +0000 Original-Received: (at 71684) by debbugs.gnu.org; 13 Sep 2024 15:44:01 +0000 Original-Received: from localhost ([127.0.0.1]:44059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sp8Sm-0006rl-Ki for submit@debbugs.gnu.org; Fri, 13 Sep 2024 11:44:00 -0400 Original-Received: from mail-pg1-f182.google.com ([209.85.215.182]:42037) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sp8Sk-0006rV-SE for 71684@debbugs.gnu.org; Fri, 13 Sep 2024 11:43:59 -0400 Original-Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-7d666fb3fb9so1206484a12.0 for <71684@debbugs.gnu.org>; Fri, 13 Sep 2024 08:43:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726242163; x=1726846963; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3qsMdFX6HiBkk3OWluMoYMdvEQDfmsz2Zmg1DcJN59I=; b=Rl6ED6xOs0hTnBqAR79e7zHqGezgoDiSaZXsWBXVkR9MicqV1ZPARbCU8Uv8JvwSAI mdvpxm2SiibH5f1dlWiYBrb+5BycWqR4puwWBYkP+7MCkf566LYNYwdj634qyAAz0GAR 8pyQdOALotkueO0zwWSqeOWazsY0asE00hD7Zu2UTF7SX3zSK/JvLN6pYW05qXUPfG3m jnANOiy2O14zw+ZBmJR8Teb94LlfC2nwxnWVszStq+CgkGJnfqhHVtboqdaaq4oAVZyA qFKzR4ljEjgJt9Nziipnp5RPNQsJ6lsr8MbS1fvgrJYYLjzry0rLKu1LyfLyIi5NsymC pvbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726242163; x=1726846963; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3qsMdFX6HiBkk3OWluMoYMdvEQDfmsz2Zmg1DcJN59I=; b=rbbWwmWlhOp5RVFgpOCctqnS0x4GZrR9ncR/C/9R5ucJKUv+hdWbzeL2Ok/Y9baJ3B Ov7rMh+g52tNqDx9DmlvFSDfW2HNE3Z7hMF3nSWvhEMoSXl0VlRxh5RjkXxEr7yqw8Gv FF9ujGWK3G91fbOVtbDgW5YC9czeu8RTp53xg9X6u/jkiY9vzgJBL0d/poW1Y0LC9Q9o NjmvTVxdouCvvYPSQudZMaoYvCXE1jWbXo9saSvy6upP2pnnTuBNnWky7UgatpiSOpaF q4MbrtgkfS3HrUnsAClvjESwN1U2Z6p1luJmUZjvHDQDQa8CX/AWFykHTNb8UHr+Eovq 053A== X-Forwarded-Encrypted: i=1; AJvYcCWcd+L0e2hNIc06EbndrlJgGbJOdI4dc94BXbWGKi3V2J/fX/hX3QJmrdh+YzzE3+gZAWlI5Q==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxFT9q9K3wzZr8Qp4D0IPcwRj+r9vMoCLnRBCHluMFxeja9PO1s xC9S6r+IVjLNXRFwPiewMJZ8DckgwW62126o+w2TFJfeL5tla33wpZUaaAGu X-Google-Smtp-Source: AGHT+IHWuXGL1wFWdZU//eMfgx5t5Ukwwzg9tW6sn+u+EKckl1xoUkPiQFrcBceOGa74JAwtH5iY1A== X-Received: by 2002:a05:6a21:3a85:b0:1c0:f114:100c with SMTP id adf61e73a8af0-1cf756c41e8mr10770073637.17.1726242163170; Fri, 13 Sep 2024 08:42:43 -0700 (PDT) Original-Received: from hurd ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71908eae89fsm6257624b3a.0.2024.09.13.08.42.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Sep 2024 08:42:42 -0700 (PDT) In-Reply-To: (Juliana Sims's message of "Mon, 15 Jul 2024 22:46:24 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.bugs:10971 Archived-At: Hi Juliana, Juliana Sims writes: > Hi y'all, > Thanks for the (continued) reviews! > >> I hadn't commented on that last sentence before, but if I knew how to >> have the Guile debugger reliably break where I want it to (I don't, or >> somehow haven't managed to have it work well), I don't think using >> 'pk', >> which requires editing files before and after debugging, could be >> described as more convenient :-). > > A fair point! I can change that wording in a next version of the patch. > >> I would suggest to apply the =E2=80=99pk=E2=80=99 on the other branch, s= omething as: >> --8<---------------cut here---------------start------------->8--- >> (map (lambda (v) >> (if (number? v) >> (pk 'number v (number->string v)) >> v)) >> '(1 "2" "3" 4)) >> --8<---------------cut here---------------end--------------->8--- > > I'm not sure I understand how this improves the demonstration of 'pk'. > What does this form of the example demonstrate that the version in the > patch does not? It's a minor change so I'm happy to make it; I just > want to ensure that we have the best possible version of the solution > to the problem you see. I'm not sure I understand the motivation too. To me the v2 patch looked fine as-is. --=20 Thanks, Maxim