unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Juliana Sims <juli@incana.org>
Cc: 71684@debbugs.gnu.org, Simon Tournier <zimon.toutoune@gmail.com>
Subject: bug#71684: [PATCH v2] doc: Document the peek and pk procedures.
Date: Sat, 14 Sep 2024 00:42:39 +0900	[thread overview]
Message-ID: <87zfobtv9s.fsf@gmail.com> (raw)
In-Reply-To: <CP3PGS.SGM0LJUASK8Q2@incana.org> (Juliana Sims's message of "Mon, 15 Jul 2024 22:46:24 -0400")

Hi Juliana,

Juliana Sims <juli@incana.org> writes:

> Hi y'all,
> Thanks for the (continued) reviews!
>
>> I hadn't commented on that last sentence before, but if I knew how to
>> have the Guile debugger reliably break where I want it to (I don't, or
>> somehow haven't managed to have it work well), I don't think using
>> 'pk',
>> which requires editing files before and after debugging, could be
>> described as more convenient :-).
>
> A fair point!  I can change that wording in a next version of the patch.
>
>> I would suggest to apply the ’pk’ on the other branch, something as:
>> --8<---------------cut here---------------start------------->8---
>> (map (lambda (v)
>>        (if (number? v)
>>            (pk 'number v (number->string v))
>>            v))
>>      '(1 "2" "3" 4))
>> --8<---------------cut here---------------end--------------->8---
>
> I'm not sure I understand how this improves the demonstration of 'pk'.
> What does this form of the example demonstrate that the version in the
> patch does not?  It's a minor change so I'm happy to make it; I just
> want to ensure that we have the best possible version of the solution
> to the problem you see.

I'm not sure I understand the motivation too. To me the v2 patch looked
fine as-is.

-- 
Thanks,
Maxim





  parent reply	other threads:[~2024-09-13 15:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-20 18:54 bug#71684: [PATCH] doc: Document the peek and pk procedures Juliana Sims via Bug reports for GUILE, GNU's Ubiquitous Extension Language
2024-07-02  3:54 ` Maxim Cournoyer
2024-07-02 16:28   ` bug#71684: [PATCH v2] " Juliana Sims via Bug reports for GUILE, GNU's Ubiquitous Extension Language
2024-07-09  2:56     ` Maxim Cournoyer
2024-09-13 15:47       ` Maxim Cournoyer
2024-07-10 18:21     ` Simon Tournier
2024-07-10 19:48       ` Maxim Cournoyer
2024-07-11  8:59         ` Simon Tournier
2024-07-16  2:46           ` Juliana Sims via Bug reports for GUILE, GNU's Ubiquitous Extension Language
2024-07-23 15:24             ` bug#71684: [PATCH] " jgart via Bug reports for GUILE, GNU's Ubiquitous Extension Language
2024-09-13 15:42             ` Maxim Cournoyer [this message]
2024-09-13 16:03               ` bug#71684: [PATCH v2] " Simon Tournier
2024-09-13 20:03                 ` bug#71684: [PATCH v3] " Juliana Sims via Bug reports for GUILE, GNU's Ubiquitous Extension Language
2024-10-14  7:57                   ` Janneke Nieuwenhuizen
2024-10-14 12:53                     ` bug#71684: [PATCH v4] " Juliana Sims via Bug reports for GUILE, GNU's Ubiquitous Extension Language
2024-10-26 17:32                       ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zfobtv9s.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=71684@debbugs.gnu.org \
    --cc=juli@incana.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).