[patch] 1.6.4: aclocal 1.8 compatibility

[patch] 1.6.4: aclocal 1.8 compatibility

[Maciej W. Rozycki]

Hello,

 Since automake 1.8 aclocal requires macro names being defined by AC_DEFUN 
to be quoted.  Here is a patch that adds missing quotations.

2004-07-30  Maciej W. Rozycki  <macro@linux-mips.org>

	* acinclude.m4: Quote names of macros to be defined by AC_DEFUN
	throughout.
	* configure.in: Likewise.
	* aclocal.m4: Regenerate.
	* configure: Regenerate.

 Please apply.

  Maciej

guile-1.6.4-am18.patch
diff -up --recursive --new-file guile-1.6.4.macro/acinclude.m4 guile-1.6.4/acinclude.m4
--- guile-1.6.4.macro/acinclude.m4	2002-12-07 22:41:28.000000000 +0000
+++ guile-1.6.4/acinclude.m4	2004-07-26 21:21:30.000000000 +0000
@@ -1,7 +1,7 @@
 dnl  On the NeXT, #including <utime.h> doesn't give you a definition for
 dnl  struct utime, unless you #define _POSIX_SOURCE.
 
-AC_DEFUN(GUILE_STRUCT_UTIMBUF, [
+AC_DEFUN([GUILE_STRUCT_UTIMBUF], [
   AC_CACHE_CHECK([whether we need POSIX to get struct utimbuf],
     guile_cv_struct_utimbuf_needs_posix,
     [AC_TRY_CPP([
@@ -71,7 +71,7 @@ dnl with other parameters, such as libra
 dnl
 dnl GUILE_NAMED_CHECK_FUNC(FUNCTION, TESTNAME,
 dnl                        [ACTION-IF-FOUND [, ACTION-IF-NOT-FOUND]])
-AC_DEFUN(GUILE_NAMED_CHECK_FUNC,
+AC_DEFUN([GUILE_NAMED_CHECK_FUNC],
 [AC_MSG_CHECKING([for $1])
 AC_CACHE_VAL(ac_cv_func_$1_$2,
 [AC_TRY_LINK(
diff -up --recursive --new-file guile-1.6.4.macro/configure.in guile-1.6.4/configure.in
--- guile-1.6.4.macro/configure.in	2002-12-08 01:48:52.000000000 +0000
+++ guile-1.6.4/configure.in	2004-07-26 21:25:11.000000000 +0000
@@ -279,7 +279,7 @@ AC_CHECK_LIB(crypt, crypt)
 
 ### Check for a declaration of FUNCTION in HEADERFILE; if it is
 ### not there, #define MISSING_FUNCTION_DECL.
-AC_DEFUN(GUILE_FUNC_DECLARED, [
+AC_DEFUN([GUILE_FUNC_DECLARED], [
   AC_CACHE_CHECK(for $1 declaration, guile_cv_func_$1_declared,
     AC_EGREP_HEADER($1, $2,
 		    guile_cv_func_$1_declared=yes,


_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile

Re: [patch] 1.6.4: aclocal 1.8 compatibility

[Kevin Ryde]

"Maciej W. Rozycki" <macro@linux-mips.org> writes:
>
>  Since automake 1.8 aclocal requires macro names being defined by AC_DEFUN 
> to be quoted.  Here is a patch that adds missing quotations.

Thanks, I made that change.

(Not sure what automake version will actually be used for the next
release though.)


_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile

Re: [patch] 1.6.4: aclocal 1.8 compatibility

[Maciej W. Rozycki]

On Sat, 31 Jul 2004, Kevin Ryde wrote:

> >  Since automake 1.8 aclocal requires macro names being defined by AC_DEFUN 
> > to be quoted.  Here is a patch that adds missing quotations.
> 
> Thanks, I made that change.
> 
> (Not sure what automake version will actually be used for the next
> release though.)

 Well, quoting in this context has always been accepted and perhaps even
preferred, it's only tools that used to be more forgiving, so the patch 
doesn't rely on any particular version of automake.  But 1.9 has been 
released, so you may have a look whether it suits you; otherwise 1.8.5 is 
probably a reasonable fall-back.

 Newer versions of autotools tend to work better with less common or newer
platforms, e.g. the "mips64el-linux" alias has only recently started being
recognized correctly.  It usually requires a complete replacement of
helper files with `libtoolize --automake --copy --force; automake
--add-missing --copy --force', though.

  Maciej


_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile

Re: [patch] 1.6.4: aclocal 1.8 compatibility

[Rob Browning]

Kevin Ryde <user42@zip.com.au> writes:

> (Not sure what automake version will actually be used for the next
> release though.)

NB: unless there's some compelling reason not to, I generally use
whatever's in current Debian unstable.

-- 
Rob Browning
rlb @defaultvalue.org and @debian.org; previously @cs.utexas.edu
GPG starting 2002-11-03 = 14DD 432F AE39 534D B592  F9A0 25C8 D377 8C7E 73A4


_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile