From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Newsgroups: gmane.lisp.guile.bugs Subject: bug#52835: [PATCH 0/2] Fix spawning a child not setting standard fds properly Date: Fri, 23 Dec 2022 11:53:26 +0100 Message-ID: <87y1qyz909.fsf_-_@gnu.org> References: <87iligyyh9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25557"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Cc: 52835@debbugs.gnu.org, Timothy Sample To: Josselin Poiret Original-X-From: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Fri Dec 23 11:54:30 2022 Return-path: Envelope-to: guile-bugs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p8fh7-0006TU-Le for guile-bugs@m.gmane-mx.org; Fri, 23 Dec 2022 11:54:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p8fgk-0002HU-Lo; Fri, 23 Dec 2022 05:54:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p8fgg-0002H0-Th for bug-guile@gnu.org; Fri, 23 Dec 2022 05:54:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p8fgg-00046K-Jx for bug-guile@gnu.org; Fri, 23 Dec 2022 05:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p8fgg-00007D-FY for bug-guile@gnu.org; Fri, 23 Dec 2022 05:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Fri, 23 Dec 2022 10:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52835 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch Original-Received: via spool by 52835-submit@debbugs.gnu.org id=B52835.1671792819426 (code B ref 52835); Fri, 23 Dec 2022 10:54:02 +0000 Original-Received: (at 52835) by debbugs.gnu.org; 23 Dec 2022 10:53:39 +0000 Original-Received: from localhost ([127.0.0.1]:36928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p8fgJ-00006o-B5 for submit@debbugs.gnu.org; Fri, 23 Dec 2022 05:53:39 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p8fgG-00006f-SS for 52835@debbugs.gnu.org; Fri, 23 Dec 2022 05:53:37 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p8fgA-0003wE-Ro; Fri, 23 Dec 2022 05:53:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=zQ1V9kemSuY6s3ktuQpdDIg64BrRHd++BHYXYEdmTmQ=; b=DF1krITYHbQxaxK3KyV4 rewmlVBvbRnWjxBzUd3gOxSn6tHCJ4peyDw8iTgOLsluxRtfaItivOfFBuCWXniLZCPSx989xeAbJ xqzr6Ma3A6vIDQNu5A4hMwqHch7V1ibksbT2JtzGJSrPcrMa7YN0o7zxxycv2+h74j5R9G9E3Fju3 uszYofareCaQcBiMmxvsRPWPrKALeoNlpw76OPqGjauekMn8TPEUdAvc7lKKskq+MAc5QeEvJ+qMa Qn6i3/bdT2V1sNfz7kmbCxyCHDHCb7Gcg6dttPyRM+Qc8ESlxZ2NdNqYeeuOx/nz8KfdPvVxA9K4P wePlIGoBwiyF+Q==; Original-Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p8fg9-0006Wg-F5; Fri, 23 Dec 2022 05:53:29 -0500 In-Reply-To: (Josselin Poiret's message of "Thu, 22 Dec 2022 13:49:07 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.bugs:10486 Archived-At: Hi Josselin, Josselin Poiret skribis: > Here is hopefully the last reroll of this patchset. First of all, I did = not > include the gnulib patch again because it still applies cleanly and it is > extremely large, but it should be applied before those 3 patches. Yay! > The first two patches should be applied on the current major release, whi= le the > third one should be applied on the next major release to finish the migra= tion to > spawn. I pushed it to =E2=80=98wip-posix-spawn=E2=80=99 along with fixups I=E2=80= =99m proposing, mostly along the lines of what I suggested in : =E2=80=A2 Avoiding the extra =E2=80=98fork=E2=80=99 in =E2=80=98system*= =E2=80=99 upon error; =E2=80=A2 Keep =E2=80=98scm_spawn_process=E2=80=99 internal. I also added Andrew Whatson=E2=80=99s patch from . If that=E2=80=99s fine with you, I can squash the =E2=80=9Cfixup!=E2=80=9D = commits and merge the branch. Let me know! Earlier we agreed it=E2=80=99d be nice to expose =E2=80=98spawn*=E2=80=99/= =E2=80=98primitive-spawn=E2=80=99. I still think it=E2=80=99s a good idea, but the interface would need some wor= k IMO to be more generally useful. In essence, we could provide something similar to =E2=80=98fork+exec-command=E2=80=99 in the Shepherd, where one c= an pass environment variables, stdin/stdout/stderr, etc., all that with keyword arguments and reasonable defaults. It=E2=80=99s a bit of extra work though so we can discuss that later, separately. Thank you! Ludo=E2=80=99.