unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
From: Neil Jerram <neil@ossau.uklinux.net>
To: Gregory Marton <gremio@csail.mit.edu>
Cc: bug-guile@gnu.org
Subject: Re: A passing test case
Date: Sat, 26 Jan 2008 18:58:30 +0000	[thread overview]
Message-ID: <87wspwo1m1.fsf@ossau.uklinux.net> (raw)
In-Reply-To: <Pine.LNX.4.62.0801260926320.307@ashmore.csail.mit.edu> (Gregory Marton's message of "Sat, 26 Jan 2008 09:28:59 -0500 (EST)")

Gregory Marton <gremio@csail.mit.edu> writes:

> The differences are not significant.  I guess I wanted to make clear
> in the test case that this isn't something to do with literal
> rationals, and I didn't want the test case to be printing things to
> the console.

OK, thanks for explaining that.  I assume that this test relates to
the following NEWS item (for 1.8.2):

** Fractions were not `equal?' if stored in unreduced form.
(A subtle problem, since printing a value reduced it, making it work.)

But doesn't that mean that your test needs to use an unreduced
fraction, e.g. 2/4 instead of 1/2 ?

(Or does Guile have a strange idea of reduction which means that 1/2
is not already a reduced form?)

Regards,
        Neil

>>> --- test-suite/tests/fractions.test.1.8.3	2008-01-25 20:08:57.000000000 -0500
>>> +++ test-suite/tests/fractions.test	2008-01-25 20:09:07.000000000 -0500
>>> @@ -400,3 +400,8 @@
>>>  (with-test-prefix "fraction generics"
>>>    (testeq (G 1) 'integer)
>>>    (testeq (G 2/3) 'fraction))
>>> +
>>> +(pass-if (let ((x (/ 1 2)))
>>> +	   (with-output-to-string (lambda () (display x)))
>>> +	   (equal? x (/ 1 2))))
>>> +





  reply	other threads:[~2008-01-26 18:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-26  1:19 A passing test case Gregory Marton
2008-01-26 13:19 ` Neil Jerram
2008-01-26 14:28   ` Gregory Marton
2008-01-26 18:58     ` Neil Jerram [this message]
2008-01-26 19:09       ` Gregory Marton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wspwo1m1.fsf@ossau.uklinux.net \
    --to=neil@ossau.uklinux.net \
    --cc=bug-guile@gnu.org \
    --cc=gremio@csail.mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).