From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.bugs,gmane.comp.lib.gnulib.bugs Subject: Re: -Wundef warning in striconveh.h Date: Mon, 25 Apr 2011 23:35:28 +0200 Message-ID: <87wriihv4v.fsf@gnu.org> References: <4D82151D.50303@redhat.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: dough.gmane.org 1303767361 26365 80.91.229.12 (25 Apr 2011 21:36:01 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 25 Apr 2011 21:36:01 +0000 (UTC) Cc: bug-gnulib@gnu.org To: bug-guile@gnu.org Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Mon Apr 25 23:35:52 2011 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QETRf-0000Hu-Mm for guile-bugs@m.gmane.org; Mon, 25 Apr 2011 23:35:51 +0200 Original-Received: from localhost ([::1]:44407 helo=lists2.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QETRf-0001SS-7Z for guile-bugs@m.gmane.org; Mon, 25 Apr 2011 17:35:51 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:39708) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QETRc-0001SM-Mn for bug-guile@gnu.org; Mon, 25 Apr 2011 17:35:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QETRb-0008Uo-CO for bug-guile@gnu.org; Mon, 25 Apr 2011 17:35:48 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:36188) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QETRb-0008UZ-30 for bug-guile@gnu.org; Mon, 25 Apr 2011 17:35:47 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1QETRZ-0000Fr-3h for bug-guile@gnu.org; Mon, 25 Apr 2011 23:35:45 +0200 Original-Received: from reverse-83.fdn.fr ([80.67.176.83]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 25 Apr 2011 23:35:45 +0200 Original-Received: from ludo by reverse-83.fdn.fr with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 25 Apr 2011 23:35:45 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Followup-To: gmane.comp.lib.gnulib.bugs Original-Lines: 49 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: reverse-83.fdn.fr X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 6 =?iso-8859-1?Q?Flor=E9al?= an 219 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu User-Agent: Gnus/5.110015 (No Gnus v0.15) Emacs/23.3 (gnu/linux) Cancel-Lock: sha1:q2ol1U6CWWT1gyOqQLQX/gCnTOk= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 80.91.229.12 X-BeenThere: bug-guile@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.bugs:5518 gmane.comp.lib.gnulib.bugs:26109 Archived-At: Hello, Andy Wingo writes: > On Thu 17 Mar 2011 15:05, Eric Blake writes: > >> On 03/17/2011 04:20 AM, Andy Wingo wrote: >>> striconveh.h:22 and striconveh.h:34 use #if when they should use #ifdef, >>> or something. >> >> Not a bug in gnulib, >> >>> >>> Building Guile a contributor got this warning: >> >> but in guile. Gnulib specifically documents that -Wundef is >> incompatible with gnulib modules, and that our coding style is >> deliberate. -Wundef only catches portability problems for ancient >> (non-C89) compilers, and gnulib requires C89 as a bare minimum. While >> you are free to use it for the rest of your project, you need to avoid >> it while compiling gnulib (or at least ignore the warnings and avoid >> -Werror). > > This error did not occur while compiling gnulib (in the lib/) directory, > but rather libguile, which included striconveh.h. I believe we already > follow your suggestions for building gnulib itself. [...] > See also this thread also: > > http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/24225 > > Do you have a response to Ludovic's concerns in his second message? Unfortunately now similarly prevents use of -Wundef by its users (again this happens when compiling libguile; Gnulib itself is compiled _without_ -Wundef): verify.h:177:8: error: "HAVE_STATIC_ASSERT" is not defined [-Werror=undef] I’m giving up on compiling Guile itself with -Wundef, but I’d prefer it if Gnulib did not impose its policy on Guile. Would you be willing to fix the problematic headers? I’d be happy to help with that, as I did in the past. Thanks, Ludo’.