From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark H Weaver Newsgroups: gmane.lisp.guile.bugs Subject: bug#20907: [PATCH] Manual bug for scm_gc_protect_object Date: Tue, 01 Sep 2015 21:59:21 -0400 Message-ID: <87wpw97f9i.fsf@netris.org> References: <1019343405.630040.1435359632144.JavaMail.yahoo@mail.yahoo.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1441159283 16082 80.91.229.3 (2 Sep 2015 02:01:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 2 Sep 2015 02:01:23 +0000 (UTC) Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 20907@debbugs.gnu.org To: Mike Gran Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Wed Sep 02 04:01:11 2015 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZWxMM-0001xe-Cd for guile-bugs@m.gmane.org; Wed, 02 Sep 2015 04:01:10 +0200 Original-Received: from localhost ([::1]:60331 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWxMM-0005b6-5b for guile-bugs@m.gmane.org; Tue, 01 Sep 2015 22:01:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWxMI-0005aK-6Z for bug-guile@gnu.org; Tue, 01 Sep 2015 22:01:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWxMF-0005M4-0i for bug-guile@gnu.org; Tue, 01 Sep 2015 22:01:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53335) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWxME-0005M0-TQ for bug-guile@gnu.org; Tue, 01 Sep 2015 22:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZWxME-00078w-FM for bug-guile@gnu.org; Tue, 01 Sep 2015 22:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Wed, 02 Sep 2015 02:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20907 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch Original-Received: via spool by 20907-submit@debbugs.gnu.org id=B20907.144115920927343 (code B ref 20907); Wed, 02 Sep 2015 02:01:02 +0000 Original-Received: (at 20907) by debbugs.gnu.org; 2 Sep 2015 02:00:09 +0000 Original-Received: from localhost ([127.0.0.1]:45545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZWxLL-00076v-NG for submit@debbugs.gnu.org; Tue, 01 Sep 2015 22:00:08 -0400 Original-Received: from world.peace.net ([50.252.239.5]:43838) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZWxLH-00076R-Ht for 20907@debbugs.gnu.org; Tue, 01 Sep 2015 22:00:05 -0400 Original-Received: from [10.1.10.32] (helo=yeeloong) by world.peace.net with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1ZWxLB-000593-0E; Tue, 01 Sep 2015 21:59:57 -0400 In-Reply-To: <1019343405.630040.1435359632144.JavaMail.yahoo@mail.yahoo.com> (Mike Gran's message of "Fri, 26 Jun 2015 23:00:32 +0000 (UTC)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.bugs:7836 Archived-At: Hi Mike, Mike Gran writes: > Manual claims C globals weren't scanned by GC in 1.8. The opposite > is true. Ludovic wrote that text in 2009, commit f07c349eb38d6c7b160b8980fc4007fb502e3433. Ludovic, what do you make of this? > * doc/ref/api-memory.texi [scm_gc_protect_object]: modified > --- > doc/ref/api-memory.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/ref/api-memory.texi b/doc/ref/api-memory.texi > index 0e37d16..3496cc5 100644 > --- a/doc/ref/api-memory.texi > +++ b/doc/ref/api-memory.texi > @@ -42,7 +42,7 @@ as it was protected. It is an error to unprotect an object more times > than it has been protected. Returns the SCM object it was passed. > > Note that storing @var{obj} in a C global variable has the same > -effect@footnote{In Guile up to version 1.8, C global variables were not > +effect@footnote{In Guile up to version 1.8, C global variables were > scanned by the garbage collector; hence, @code{scm_gc_protect_object} > was the only way in C to prevent a Scheme object from being freed.}. If what you say is true, then this patch would not be sufficient, because the footnote would not make sense. If you're right, then the entire paragraph above should be removed. Mark