From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.bugs Subject: bug#17418: #:select gives access to private variables Date: Tue, 21 Jun 2016 17:17:20 +0200 Message-ID: <87wpliwozj.fsf@pobox.com> References: <87sion47ji.fsf@gnu.org> <8738fo2k7q.fsf@yeeloong.lan> <87vbsj4ttv.fsf@gnu.org> <87ioohvbeh.fsf@yeeloong.lan> <87egz5vb9g.fsf@yeeloong.lan> <87twgmy6z7.fsf@pobox.com> <87ziqe7fx2.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1466522330 13668 80.91.229.3 (21 Jun 2016 15:18:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 21 Jun 2016 15:18:50 +0000 (UTC) Cc: 17418-done@debbugs.gnu.org To: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Tue Jun 21 17:18:41 2016 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bFNRh-0002uP-QE for guile-bugs@m.gmane.org; Tue, 21 Jun 2016 17:18:34 +0200 Original-Received: from localhost ([::1]:52506 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFNRc-0004uo-8I for guile-bugs@m.gmane.org; Tue, 21 Jun 2016 11:18:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52088) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFNRJ-0004rt-CO for bug-guile@gnu.org; Tue, 21 Jun 2016 11:18:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFNRC-00058d-PN for bug-guile@gnu.org; Tue, 21 Jun 2016 11:18:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37580) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFNRC-00058T-M1 for bug-guile@gnu.org; Tue, 21 Jun 2016 11:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bFNRC-0006WL-Hv for bug-guile@gnu.org; Tue, 21 Jun 2016 11:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andy Wingo Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Tue, 21 Jun 2016 15:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17418 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Original-Received: via spool by 17418-done@debbugs.gnu.org id=D17418.146652225224999 (code D ref 17418); Tue, 21 Jun 2016 15:18:02 +0000 Original-Received: (at 17418-done) by debbugs.gnu.org; 21 Jun 2016 15:17:32 +0000 Original-Received: from localhost ([127.0.0.1]:49912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFNQh-0006V8-Ma for submit@debbugs.gnu.org; Tue, 21 Jun 2016 11:17:32 -0400 Original-Received: from pb-sasl2.pobox.com ([64.147.108.67]:58995 helo=sasl.smtp.pobox.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFNQf-0006Uz-Q8 for 17418-done@debbugs.gnu.org; Tue, 21 Jun 2016 11:17:31 -0400 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-sasl2.pobox.com (Postfix) with ESMTP id 3C24A24883; Tue, 21 Jun 2016 11:17:28 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=ZIcQIfsp25MW g86p2EQPfHe/A0Y=; b=iHsG9NuVlY1NNqngiQFtZMGkl2wVWMGCTyd9RggXI5hQ GqxqlBITu3jKI3GUHebvlyQIdBIT4iAbu/FHxcWNBDSC/HwEW2Lz2R9q5Nz78nSS P6cNijl+NNK5gGTEk/LGaG9eDeMITa/jyIl0n0zO7pxlGJ50qfelK8PXVXGJMEo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=Yc9PYK HDZlA/0/XBbcoJ9OP3qYj7CdpeA+u0cBn6X2rr1C9E0puFwC5mKGplK83fTTSvNT VT+/nAnJVJ+0odnZ7jAcSlffHL333+LRgsYobHLkwMNEALZD0jgO125eK7uUeisG csJgD0G/4rxvdhGFLgdlj6lxGsCYI4Of0eBW4= Original-Received: from pb-sasl2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-sasl2.pobox.com (Postfix) with ESMTP id 3471624882; Tue, 21 Jun 2016 11:17:28 -0400 (EDT) Original-Received: from clucks (unknown [88.160.190.192]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-sasl2.pobox.com (Postfix) with ESMTPSA id 7D04B24881; Tue, 21 Jun 2016 11:17:27 -0400 (EDT) In-Reply-To: <87ziqe7fx2.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Tue, 21 Jun 2016 16:52:25 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-Pobox-Relay-ID: 43C32780-37C3-11E6-8135-28A6F1301B6D-02397024!pb-sasl2.pobox.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:8106 Archived-At: On Tue 21 Jun 2016 16:52, ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Andy Wingo skribis: > >> On Wed 04 Jun 2014 01:11, Mark H Weaver writes: >> >>> Mark H Weaver writes: >>>> Sounds good. Specifically, I guess we should deprecate this way of >>>> using #:select. >>>> >>>> If you do this, can you adjust system/repl/coop-server.scm to avoid it? >>>> It imports the following private bindings: >>>> >>>> start-repl* run-server* add-open-socket! close-socket! >>> >>> Also: prompting-meta-read >> >> Fixed in master. > > I would not close the bug if it remains in 2.0.x. Thoughts? I think we can't break 2.0 in this regard; it's technically incompatible. We could print a better deprecation warning but in this case I think I did the right thing. WDYT? A