From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Newsgroups: gmane.lisp.guile.bugs Subject: bug#29162: [PATCH] fix scm_make_foreign_object_n Date: Wed, 22 Nov 2017 22:29:56 +0100 Message-ID: <87wp2iuhm3.fsf@gnu.org> References: <20171105221510.12760-1-slyfox@gentoo.org> <871skqz6sn.fsf@gnu.org> <20171122200320.23ad3f55@sf> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1511386221 20504 195.159.176.226 (22 Nov 2017 21:30:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 22 Nov 2017 21:30:21 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) Cc: 29162@debbugs.gnu.org To: Sergei Trofimovich , Andy Wingo Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Wed Nov 22 22:30:13 2017 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eHcas-0004Rr-Es for guile-bugs@m.gmane.org; Wed, 22 Nov 2017 22:30:06 +0100 Original-Received: from localhost ([::1]:41394 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eHcaz-0005u8-OI for guile-bugs@m.gmane.org; Wed, 22 Nov 2017 16:30:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43440) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eHcat-0005s3-77 for bug-guile@gnu.org; Wed, 22 Nov 2017 16:30:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eHcaq-0005b0-2e for bug-guile@gnu.org; Wed, 22 Nov 2017 16:30:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44479) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eHcap-0005aw-VM for bug-guile@gnu.org; Wed, 22 Nov 2017 16:30:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eHcap-0001NL-Mv for bug-guile@gnu.org; Wed, 22 Nov 2017 16:30:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Wed, 22 Nov 2017 21:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29162 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch Original-Received: via spool by 29162-submit@debbugs.gnu.org id=B29162.15113862025266 (code B ref 29162); Wed, 22 Nov 2017 21:30:03 +0000 Original-Received: (at 29162) by debbugs.gnu.org; 22 Nov 2017 21:30:02 +0000 Original-Received: from localhost ([127.0.0.1]:53158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eHcan-0001Ml-Cr for submit@debbugs.gnu.org; Wed, 22 Nov 2017 16:30:01 -0500 Original-Received: from hera.aquilenet.fr ([141.255.128.1]:33445) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eHcal-0001MI-Hd for 29162@debbugs.gnu.org; Wed, 22 Nov 2017 16:29:59 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id AFADEFF63; Wed, 22 Nov 2017 22:30:00 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Original-Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7srEgRx5sNIg; Wed, 22 Nov 2017 22:30:00 +0100 (CET) Original-Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 9D219F3E2; Wed, 22 Nov 2017 22:29:59 +0100 (CET) X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 2 Frimaire an 226 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu In-Reply-To: <20171122200320.23ad3f55@sf> (Sergei Trofimovich's message of "Wed, 22 Nov 2017 20:03:20 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:8909 Archived-At: Heya, Sergei Trofimovich skribis: > On Wed, 22 Nov 2017 16:12:24 +0100 > ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > >> Hi Sergei, >>=20 >> Sergei Trofimovich skribis: >>=20 >> > diff --git a/libguile/foreign-object.c b/libguile/foreign-object.c >> > index 34b9f22ca..8fd2c384c 100644 >> > --- a/libguile/foreign-object.c >> > +++ b/libguile/foreign-object.c >> > @@ -108,7 +108,7 @@ scm_make_foreign_object_n (SCM type, size_t n, voi= d *vals[]) >> >=20=20 >> > SCM_VALIDATE_VTABLE (SCM_ARG1, type); >> >=20=20 >> > - if (SCM_VTABLE_SIZE (type) / 2 < n) >> > + if (SCM_VTABLE_SIZE (type) < n) >> > scm_out_of_range (FUNC_NAME, scm_from_size_t (n));=20=20 >>=20 >> Your analysis seems right, but the code in the current =E2=80=98stable-2= .2=E2=80=99 >> branch (which corresponds to the 2.2.x stable series) has different code >> (correct code): >>=20 >> SCM_VALIDATE_VTABLE (SCM_ARG1, type); >>=20 >> layout =3D SCM_VTABLE_LAYOUT (type); >>=20 >> if (scm_i_symbol_length (layout) / 2 < n) >> scm_out_of_range (FUNC_NAME, scm_from_size_t (n)); >>=20 >> What version were you looking at? > > It was the master branch of > git://git.savannah.gnu.org/guile.git > > Commit from November: > http://git.savannah.gnu.org/cgit/guile.git/commit/?id=3Df96a670332b22= 4326b89ce135a0edfb77a70c46e=20=20=20=20 > > The link with line number: > http://git.savannah.gnu.org/cgit/guile.git/tree/libguile/foreign-obje= ct.c?id=3Df96a670332b224326b89ce135a0edfb77a70c46e#n111 > > In master branch it still seems to be around: > http://git.savannah.gnu.org/cgit/guile.git/tree/libguile/foreign-obje= ct.c#n111 Indeed. Andy, could you take a look? The patch LGTM. Ludo=E2=80=99.