unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 30154-done@debbugs.gnu.org
Subject: bug#30154: [PATCH] web: Export http-request.
Date: Sat, 23 Jun 2018 23:31:56 +0200	[thread overview]
Message-ID: <87woupw5o3.fsf@gnu.org> (raw)
In-Reply-To: <20180621172718.16029-1-arunisaac@systemreboot.net> (Arun Isaac's message of "Thu, 21 Jun 2018 22:57:18 +0530")

[-- Attachment #1: Type: text/plain, Size: 406 bytes --]

Hello Arun,

Arun Isaac <arunisaac@systemreboot.net> skribis:

> * module/web/client.scm (request): Rename to http-request, add a
> docstring, and export it.
> (http-get, http-head, http-post, http-put, http-delete, http-trace,
> http-options): Update docstring.
> * doc/ref/web.texi (Web Client): Document http-request.

Awesome!  Applied with the tiny changes below.

Thank you,
Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 2391 bytes --]

diff --git a/doc/ref/web.texi b/doc/ref/web.texi
index e99907fe3..62b25d889 100644
--- a/doc/ref/web.texi
+++ b/doc/ref/web.texi
@@ -1,6 +1,6 @@
 @c -*-texinfo-*-
 @c This is part of the GNU Guile Reference Manual.
-@c Copyright (C) 2010, 2011, 2012, 2013, 2015 Free Software Foundation, Inc.
+@c Copyright (C) 2010, 2011, 2012, 2013, 2015, 2018 Free Software Foundation, Inc.
 @c See the file guile.texi for copying conditions.
 
 @node Web
@@ -1467,7 +1467,7 @@ how to install the GnuTLS bindings for Guile,, gnutls-guile,
 GnuTLS-Guile}, for more information.
 @end deffn
 
-@anchor{http-request}@deffn {Scheme Procedure} http-request uri arg...
+@anchor{http-request}@deffn {Scheme Procedure} http-request @var{uri} @var{arg}@dots{}
 
 Connect to the server corresponding to @var{uri} and make a request over
 HTTP, using @var{method} (@code{GET}, @code{HEAD}, @code{POST}, etc.).
@@ -1516,22 +1516,21 @@ body as a string, bytevector, #f value, or as a port (if
 @var{streaming?} is true).
 @end deffn
 
-@deffn {Scheme Procedure} http-get uri arg...
-@deffnx {Scheme Procedure} http-head uri arg...
-@deffnx {Scheme Procedure} http-post uri arg...
-@deffnx {Scheme Procedure} http-put uri arg...
-@deffnx {Scheme Procedure} http-delete uri arg...
-@deffnx {Scheme Procedure} http-trace uri arg...
-@deffnx {Scheme Procedure} http-options uri arg...
-
+@deffn {Scheme Procedure} http-get @var{uri} @var{arg}@dots{}
+@deffnx {Scheme Procedure} http-head @var{uri} @var{arg}@dots{}
+@deffnx {Scheme Procedure} http-post @var{uri} @var{arg}@dots{}
+@deffnx {Scheme Procedure} http-put @var{uri} @var{arg}@dots{}
+@deffnx {Scheme Procedure} http-delete @var{uri} @var{arg}@dots{}
+@deffnx {Scheme Procedure} http-trace @var{uri} @var{arg}@dots{}
+@deffnx {Scheme Procedure} http-options @var{uri} @var{arg}@dots{}
 Connect to the server corresponding to @var{uri} and make a request over
 HTTP, using the appropriate method (@code{GET}, @code{HEAD},
 @code{POST}, etc.).
 
 These procedures are variants of @code{http-request} specialized with a
 specific @var{method} argument, and have the same prototype: a URI
-followed by an optional sequence of keyword arguments.  See
-@ref{http-request} for full documentation on the various keyword
+followed by an optional sequence of keyword arguments.
+@xref{http-request}, for full documentation on the various keyword
 arguments.
 
 @end deffn

      reply	other threads:[~2018-06-23 21:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-18  9:43 bug#30154: [PATCH] web: Add http-patch Arun Isaac
2018-01-26 23:22 ` Mark H Weaver
2018-01-28  0:27   ` Arun Isaac
2018-01-28 21:10     ` Mark H Weaver
2018-01-29  8:33       ` Arun Isaac
2018-06-18 12:13         ` Ludovic Courtès
2018-06-19  5:34           ` Arun Isaac
2018-06-21 17:27 ` bug#30154: [PATCH] web: Export http-request Arun Isaac
2018-06-23 21:31   ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87woupw5o3.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=30154-done@debbugs.gnu.org \
    --cc=arunisaac@systemreboot.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).