From: Kevin Ryde <user42@zip.com.au>
Cc: bug-guile@gnu.org
Subject: Re: [Patch] --with-threads on MinGW
Date: Mon, 04 Dec 2006 11:31:16 +1100 [thread overview]
Message-ID: <87veks33jf.fsf@zip.com.au> (raw)
In-Reply-To: <457316BF.6090003@web.de> (Nils Durner's message of "Sun, 03 Dec 2006 19:26:07 +0100")
Nils Durner <ndurner@web.de> writes:
>
> the attached patch fixes building on MinGW with "--with-threads=pthreads"
Looks good in principle, but some bits ought to be in a more autoconfy
style.
> -#ifdef HAVE_STRUCT_TIMESPEC
> +#if HAVE_STRUCT_TIMESPEC || SCM_I_GSC_USE_PTHREAD_THREADS
> pf ("typedef struct timespec scm_t_timespec;\n");
Does the detection of struct timespec go wrong somehow?
> +#ifndef __MINGW32__
> + sigset_t all_sigs;
> +
> sigfillset (&all_sigs);
> scm_i_pthread_sigmask (SIG_SETMASK, &all_sigs, NULL);
> +#endif
I think I'd rather either conditionalize on the existance of
pthread_sigmask, or perhaps make some dummy sigset stuff if it doesn't
exist.
> +#ifndef __MINGW32__
> + t->pthread,
> +#else
> + t->pthread.p,
> +#endif
What does that do?
> #if SCM_USE_PTHREAD_THREADS
> /* pthread_getattr_np not available on MacOS X and Solaris 10. */
> -#if HAVE_PTHREAD_ATTR_GETSTACK && HAVE_PTHREAD_GETATTR_NP
> +#if (HAVE_PTHREAD_ATTR_GETSTACK && HAVE_PTHREAD_GETATTR_NP) || __MINGW32__
Remind us what's wrong with the getstack detection ...
_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile
next prev parent reply other threads:[~2006-12-04 0:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-03 18:26 [Patch] --with-threads on MinGW Nils Durner
2006-12-04 0:31 ` Kevin Ryde [this message]
2006-12-04 21:18 ` Nils Durner
2006-12-13 23:29 ` Kevin Ryde
2006-12-13 23:55 ` Kevin Ryde
2006-12-14 0:09 ` Kevin Ryde
2006-12-14 22:12 ` Nils Durner
2006-12-15 0:24 ` Kevin Ryde
2006-12-14 0:40 ` Kevin Ryde
2006-12-14 0:12 ` Kevin Ryde
2006-12-14 21:42 ` Nils Durner
2006-12-15 0:25 ` Kevin Ryde
2006-12-27 0:10 ` Kevin Ryde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87veks33jf.fsf@zip.com.au \
--to=user42@zip.com.au \
--cc=bug-guile@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).