From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark H Weaver Newsgroups: gmane.lisp.guile.bugs Subject: Re: Stable 2.0 and popen.test on Debian Squeeze Date: Wed, 02 Mar 2011 06:17:40 -0500 Message-ID: <87vd01rctn.fsf@netris.org> References: <87aahesk8d.fsf@netris.org> <20110302013257.1DDMP.140430.root@cdptpa-web28-z02> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: dough.gmane.org 1299064684 10348 80.91.229.12 (2 Mar 2011 11:18:04 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 2 Mar 2011 11:18:04 +0000 (UTC) Cc: bug-guile@gnu.org, Francis Southern To: Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Wed Mar 02 12:17:58 2011 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Puk45-0001qV-87 for guile-bugs@m.gmane.org; Wed, 02 Mar 2011 12:17:57 +0100 Original-Received: from localhost ([127.0.0.1]:44291 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Puk44-0004w3-NO for guile-bugs@m.gmane.org; Wed, 02 Mar 2011 06:17:56 -0500 Original-Received: from [140.186.70.92] (port=49922 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Puk40-0004vf-8k for bug-guile@gnu.org; Wed, 02 Mar 2011 06:17:53 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Puk3y-0006Fg-P3 for bug-guile@gnu.org; Wed, 02 Mar 2011 06:17:52 -0500 Original-Received: from world.peace.net ([216.204.32.208]:37495) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Puk3y-0006F6-LF for bug-guile@gnu.org; Wed, 02 Mar 2011 06:17:50 -0500 Original-Received: from ip68-9-118-38.ri.ri.cox.net ([68.9.118.38] helo=freedomincluded) by world.peace.net with esmtpa (Exim 4.69) (envelope-from ) id 1Puk3q-0007ax-Eg; Wed, 02 Mar 2011 06:17:42 -0500 Original-Received: from mhw by freedomincluded with local (Exim 4.69) (envelope-from ) id 1Puk3o-0000nJ-8P; Wed, 02 Mar 2011 06:17:40 -0500 In-Reply-To: <20110302013257.1DDMP.140430.root@cdptpa-web28-z02> (dsmich@roadrunner.com's message of "Tue, 1 Mar 2011 20:32:56 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 216.204.32.208 X-BeenThere: bug-guile@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.bugs:5252 Archived-At: --=-=-= writes: > dsmith@stumpy:~/src/guile$ ./check-guile popen.test > Testing /home/dsmith/src/guile/meta/guile ... popen.test > with GUILE_LOAD_PATH=/home/dsmith/src/guile/test-suite > Running popen.test > FAIL: popen.test: open-output-pipe: no duplicate Does the attached patch fix your problems with popen.test on Squeeze? Thanks, Mark --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Portability-fixes-for-popen.test-for-when-bin-sh-is-.patch Content-Description: Portability fixes for popen.test (for when /bin/sh is not bash) >From 11195909b25347ae710d6423165eb123cf0aa996 Mon Sep 17 00:00:00 2001 From: Mark H Weaver Date: Wed, 2 Mar 2011 06:02:58 -0500 Subject: [PATCH] Portability fixes for popen.test (for when /bin/sh is not bash) * test-suite/tests/popen.test (open-input-pipe no-duplicate): Pass "read REPLY" command instead of "read" to the subshell, for improved portability. In particular, it is needed when /bin/sh is dash. (open-output-pipe no-duplicate): Pass "exec guile [...]" instead of "guile [...]" to the subshell, to ensure that the subshell will not run guile as a subprocess while holding a duplicate of STDIN, which would cause this test to fail. This is needed when /bin/sh is dash. --- test-suite/tests/popen.test | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test-suite/tests/popen.test b/test-suite/tests/popen.test index 6300c3b..bfd7da7 100644 --- a/test-suite/tests/popen.test +++ b/test-suite/tests/popen.test @@ -104,7 +104,7 @@ (with-input-from-port (car p2c) (lambda () (open-input-pipe - "exec 1>/dev/null; echo closed 1>&2; exec 2>/dev/null; read"))))))) + "exec 1>/dev/null; echo closed 1>&2; exec 2>/dev/null; read REPLY"))))))) (close-port (cdr c2p)) ;; write side (let ((result (eof-object? (read-char port)))) (display "hello!\n" (cdr p2c)) @@ -168,7 +168,7 @@ (port (with-error-to-port (cdr c2p) (lambda () (open-output-pipe - (string-append "guile --no-auto-compile -s \"" + (string-append "exec guile --no-auto-compile -s \"" (getenv "TEST_SUITE_DIR") "/tests/popen-child.scm\"")))))) (close-port (cdr c2p)) ;; write side -- 1.7.1 --=-=-=--