From: Aidan Gauland <aidalgol@no8wireless.co.nz>
To: 13018@debbugs.gnu.org
Subject: bug#13018: fport_fill_input should handle EINTR
Date: Wed, 28 Nov 2012 21:19:06 +1300 [thread overview]
Message-ID: <87vccqnnr9.fsf@dimension8.tehua.net> (raw)
Guile version: 3.2.0-4-amd64
OS: Debian wheezy GNU/Linux, kernel 3.2.0-4-amd64
In a program that maintains a TCP connection with a polling loop, I have
defined a signal handler with the `sigaction' procedure to terminate the
connection gracefully. When the trapped signal is received (in this
case SIGINT) and the handler called, the following error message is
printed (full backtrace omitted):
ERROR: In procedure %read-line:
ERROR: In procedure fport_fill_input: Interrupted system call
I mentioned this on #guile on freenode and mark_weaver informed me that
I should be setting the SA_RESTART flag to avoid this problem, but that
there is a bug in Guile causing the error.
<mark_weaver> fport_fill_input should handle an EINTR error from 'read',
and restart the read if that happens.
<mark_weaver> by default on some systems, signals cause 'read', 'write',
and many other system calls to abort and return an EINTR
error.
<mark_weaver> basically, at the POSIX level, every call to 'read' has to
be within a little loop that takes care of the EINTR
problem.
In short, I don't fully understand the innards to have an opinion on
whether this a bug or users should just set the SA_RESTART flag, bug
Mark assures me this is, indeed, a bug. Any disagreement, take it up
with him. ;)
Regards,
Aidan Gauland
next reply other threads:[~2012-11-28 8:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 8:19 Aidan Gauland [this message]
2012-11-29 20:19 ` bug#13018: fport_fill_input should handle EINTR Ludovic Courtès
2013-03-13 11:44 ` Andy Wingo
2013-03-29 7:35 ` Aidan Gauland
2013-07-03 19:14 ` Mark H Weaver
2013-08-08 21:39 ` Mark H Weaver
2013-03-05 17:57 ` Andy Wingo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vccqnnr9.fsf@dimension8.tehua.net \
--to=aidalgol@no8wireless.co.nz \
--cc=13018@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).