From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: taylanbayirli@gmail.com (Taylan Ulrich =?UTF-8?Q?Bay=C4=B1rl=C4=B1/Kammer?=) Newsgroups: gmane.lisp.guile.bugs Subject: bug#21887: 'monitor' form broken Date: Thu, 12 Nov 2015 16:29:30 +0100 Message-ID: <87vb97s0bp.fsf@T420.taylan> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1447342335 23845 80.91.229.3 (12 Nov 2015 15:32:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 12 Nov 2015 15:32:15 +0000 (UTC) To: 21887@debbugs.gnu.org Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Thu Nov 12 16:32:02 2015 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zwtqy-0005tX-4f for guile-bugs@m.gmane.org; Thu, 12 Nov 2015 16:32:00 +0100 Original-Received: from localhost ([::1]:47380 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zwtqx-00043r-Ek for guile-bugs@m.gmane.org; Thu, 12 Nov 2015 10:31:59 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36848) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwtqA-0002dm-CL for bug-guile@gnu.org; Thu, 12 Nov 2015 10:31:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zwtq4-0005b4-Mr for bug-guile@gnu.org; Thu, 12 Nov 2015 10:31:10 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44174) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zwtq4-0005ax-Hx for bug-guile@gnu.org; Thu, 12 Nov 2015 10:31:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Zwtq4-0004MR-8A for bug-guile@gnu.org; Thu, 12 Nov 2015 10:31:04 -0500 X-Loop: help-debbugs@gnu.org Resent-From: taylanbayirli@gmail.com (Taylan Ulrich =?UTF-8?Q?Bay=C4=B1rl=C4=B1/Kammer?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Thu, 12 Nov 2015 15:31:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 21887 X-GNU-PR-Package: guile X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-guile@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.144734220716607 (code B ref -1); Thu, 12 Nov 2015 15:31:03 +0000 Original-Received: (at submit) by debbugs.gnu.org; 12 Nov 2015 15:30:07 +0000 Original-Received: from localhost ([127.0.0.1]:34882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zwtp3-0004JT-EG for submit@debbugs.gnu.org; Thu, 12 Nov 2015 10:30:04 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:54830) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zwtoi-0004Ii-OC for submit@debbugs.gnu.org; Thu, 12 Nov 2015 10:29:59 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zwtoh-0005L4-Eu for submit@debbugs.gnu.org; Thu, 12 Nov 2015 10:29:40 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:51556) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zwtoh-0005L0-Bi for submit@debbugs.gnu.org; Thu, 12 Nov 2015 10:29:39 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36591) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zwtoc-0001rR-N7 for bug-guile@gnu.org; Thu, 12 Nov 2015 10:29:39 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zwtob-0005KH-MC for bug-guile@gnu.org; Thu, 12 Nov 2015 10:29:34 -0500 Original-Received: from mail-wm0-x229.google.com ([2a00:1450:400c:c09::229]:37476) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zwtob-0005KD-Ft for bug-guile@gnu.org; Thu, 12 Nov 2015 10:29:33 -0500 Original-Received: by wmww144 with SMTP id w144so93458803wmw.0 for ; Thu, 12 Nov 2015 07:29:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:user-agent:mime-version :content-type; bh=letWYKqsb7ZO5fAgumbiaG3iwzhL3Xxf+ImSVzKA4sw=; b=v7TvKH6t0Yx8y09ubh9Wer5GM3WO7o+WQa0lnAQAeERz4OAE0WGoiKSrFWrOICWvYG f1qlol/j1voHZb+9cb6xMo23RFYNxaOmtBWYD9HXY5fahONZWdJWRWRwVtKx27nq8hJd hQVyb0272PV13+Hhqct5wjWnufdy4a07dYTtK3N21/f1oIAu3aZrA4Wm78SR5doN1RjA PiiROuIYrnMlPlr4Raq39o3uuIi8OhJ9rQfaweR46m1a5fUWKQFkz8fGDXqnZItRMTTg LPz6lEevV3rWy+knAcETuCiSnSRu8TA/DDm6SdC3sz88NzrEThDiBlUYig2q7OxRWlPD BCrg== X-Received: by 10.194.201.202 with SMTP id kc10mr19628294wjc.84.1447342172188; Thu, 12 Nov 2015 07:29:32 -0800 (PST) Original-Received: from T420.taylan ([2a02:908:c32:4740:221:ccff:fe66:68f0]) by smtp.gmail.com with ESMTPSA id 71sm15562884wmt.15.2015.11.12.07.29.30 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Nov 2015 07:29:31 -0800 (PST) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.bugs:7890 Archived-At: It seems that the 'monitor' form is currently a no-op. The form (par-for-each (lambda (x) (monitor (foo))) xs) should be functionally equivalent to (let ((mutex (make-mutex))) (par-for-each (lambda (x) (with-mutex mutex (foo))) xs)) but currently becomes (par-for-each (lambda (x) (let ((mutex (make-mutex))) (with-mutex mutex (foo)))) xs) which is ineffective. I don't know what's the best way to fix this. The simplest thing that comes to my mind is something along the lines of: (define-syntax monitor (lambda (stx) (syntax-case stx () ((_ body body* ...) (let ((uuid (generate-uuid))) #`(with-mutex (mutex-with-uuid #,uuid) body body* ...)))))) where mutex-with-uuid looks it up from a hash table at run-time and instantiates it when it doesn't exist, this operation also being synchronized across threads, like: (define mutex-table (make-hash-table)) (define mutex-table-mutex (make-mutex)) (define (mutex-with-uuid uuid) (with-mutex mutex-table-mutex (or (hash-ref mutex-table uuid) (let ((mutex (make-mutex))) (hash-set! mutex-table uuid mutex) mutex)))) If that looks OK, I can try to make a proper patch from it. I'm not sure what I'd use in place of `generate-uuid' though. Would `gensym' be good enough? Shameless advertisement: with SRFI-126, the (or (hash-ref ...) ...) bit would have been just: (hashtable-intern! mutex-table uuid make-mutex) It's borrowed from MIT/GNU Scheme. Seems pretty useful. Taylan