From: Andy Wingo <wingo@pobox.com>
To: Mark H Weaver <mhw@netris.org>
Cc: David Kastrup <dak@gnu.org>, 20109@debbugs.gnu.org
Subject: bug#20109: Incompatible API change in 2.0 series for string port encoding
Date: Thu, 23 Jun 2016 18:23:05 +0200 [thread overview]
Message-ID: <87vb0znac6.fsf@pobox.com> (raw)
In-Reply-To: <874mof5o5d.fsf@netris.org> (Mark H. Weaver's message of "Fri, 17 Apr 2015 01:17:50 -0400")
On Fri 17 Apr 2015 07:17, Mark H Weaver <mhw@netris.org> writes:
> David Kastrup <dak@gnu.org> writes:
>
>> In 2.0.9, the following patch/code for getting what amounts to a binary
>> string port worked.
>>
>> commit 7f7a124d3470b0d566f796e88f4e2ad5aa043f16
>> Author: David Kastrup <dak@gnu.org>
>> Date: Sun Sep 21 18:40:06 2014 +0200
>>
>> Source_file::init_port: Keep GUILEv2 from redecoding string input
>>
>> diff --git a/lily/source-file.cc b/lily/source-file.cc
>> index 1118b9d..75ed0d9 100644
>> --- a/lily/source-file.cc
>> +++ b/lily/source-file.cc
>> @@ -152,7 +152,11 @@ Source_file::init_port ()
>> // we do our own utf8 encoding and verification in the parser, so we
>> // use the no-conversion equivalent of latin1
>> SCM str = scm_from_latin1_string (c_str ());
>> - str_port_ = scm_mkstrport (SCM_INUM0, str, SCM_OPN | SCM_RDNG, __FUNCTION__);
>> + scm_dynwind_begin ((scm_t_dynwind_flags)0);
>> + // Why doesn't scm_set_port_encoding_x work here?
>> + scm_dynwind_fluid (ly_lily_module_constant ("%default-port-encoding"), SCM_BOOL_F);
>> + str_port_ = scm_open_input_string (str);
>> + scm_dynwind_end ();
>> scm_set_port_filename_x (str_port_, ly_string2scm (name_));
>> }
>>
>>
>> In 2.0.11, it doesn't. This is an incompatible API change within the
>> "stable" 2.0 series.
>
> Are you sure that you weren't using Guile from our 'master' branch? I'm
> not aware of any change made on our stable-2.0 branch that would break
> the above approach.
>
> We _did_ make an incompatible change that would break this approach on
> our master branch, which will become Guile 2.2. On that branch, string
> ports always use UTF-8 to encode the initial string, and UTF-8 is always
> used as the initial port encoding. However, stable-2.0 still uses
> %default-port-encoding.
I believe Mark is right -- the change to string ports is only on
`master'. Given that, I think the bug can be closed. David does this
match your perception?
Andy
next prev parent reply other threads:[~2016-06-23 16:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-15 13:15 bug#20109: Incompatible API change in 2.0 series for string port encoding David Kastrup
2015-03-16 20:42 ` Mark H Weaver
2015-03-16 20:46 ` Mark H Weaver
2015-03-17 8:39 ` David Kastrup
2015-03-17 22:44 ` Mark H Weaver
2015-03-18 12:32 ` David Kastrup
2015-04-17 5:17 ` Mark H Weaver
2016-06-23 16:23 ` Andy Wingo [this message]
2016-06-23 16:46 ` David Kastrup
2016-06-23 17:58 ` Andy Wingo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vb0znac6.fsf@pobox.com \
--to=wingo@pobox.com \
--cc=20109@debbugs.gnu.org \
--cc=dak@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).