From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.bugs Subject: bug#11887: string->number edge cases Date: Tue, 05 Mar 2013 15:49:13 +0100 Message-ID: <87txopyk9i.fsf@pobox.com> References: <87sjd1qfs3.fsf@Kagami.home> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1362509700 31581 80.91.229.3 (5 Mar 2013 18:55:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 5 Mar 2013 18:55:00 +0000 (UTC) Cc: Peter.Bex@xs4all.nl, 11887@debbugs.gnu.org To: Ian Price Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Tue Mar 05 19:55:21 2013 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UCx1E-00080d-Uq for guile-bugs@m.gmane.org; Tue, 05 Mar 2013 19:55:21 +0100 Original-Received: from localhost ([::1]:37997 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCx0t-00021r-8O for guile-bugs@m.gmane.org; Tue, 05 Mar 2013 13:54:59 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:60403) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCx0i-00020Y-0I for bug-guile@gnu.org; Tue, 05 Mar 2013 13:54:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UCx0a-0002to-SF for bug-guile@gnu.org; Tue, 05 Mar 2013 13:54:47 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56976) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCx0a-0002te-LK for bug-guile@gnu.org; Tue, 05 Mar 2013 13:54:40 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UCx0v-0000ZM-Py for bug-guile@gnu.org; Tue, 05 Mar 2013 13:55:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andy Wingo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-guile@gnu.org Resent-Date: Tue, 05 Mar 2013 18:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11887 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Original-Received: via spool by 11887-submit@debbugs.gnu.org id=B11887.13625096602030 (code B ref 11887); Tue, 05 Mar 2013 18:55:01 +0000 Original-Received: (at 11887) by debbugs.gnu.org; 5 Mar 2013 18:54:20 +0000 Original-Received: from localhost ([127.0.0.1]:32822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UCx0D-0000WS-PY for submit@debbugs.gnu.org; Tue, 05 Mar 2013 13:54:20 -0500 Original-Received: from a-pb-sasl-quonix.pobox.com ([208.72.237.25]:38230 helo=sasl.smtp.pobox.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UCx00-0000Ve-DN for 11887@debbugs.gnu.org; Tue, 05 Mar 2013 13:54:04 -0500 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id A7F6FBF92; Tue, 5 Mar 2013 13:53:42 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=1q2AF6Hszokx Iv4ZUCW9LrTp8j8=; b=qlHkEMrh7QOxTLykhdgOX8n0VaWjH2Mgk5wBehMJelt2 V2v1WTJP7N9bp2ssrbdDbk8CJGFEYgXbRdIUvgL+4J4KcXjR+BknkBQpRVpk3iL4 +MKMcLIl7lQkeBCpRjfE2IoXF+ZJak5m5/Q137ERePSxfzWE2ImGPCdkAcnBiXY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=P+4vgP Cd7+2gTflIUvLmIlfbmWKUvvZCSdg4inkRi0Ormy3mYpSx8dEZfonGuoDfWa1rUQ A3vbWGNqwTT+at9d2qBzbVUfplsgokM51PAHWbmLREe122VsM8e9xbp1cZnCZl63 5Dj9W1a7wO66PCOIxUxOr1o/rJEHSVul6I5iU= Original-Received: from a-pb-sasl-quonix.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id A05BBBF91; Tue, 5 Mar 2013 13:53:42 -0500 (EST) Original-Received: from badger (unknown [217.91.84.86]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTPSA id 22F04BF90; Tue, 5 Mar 2013 13:53:42 -0500 (EST) In-Reply-To: <87sjd1qfs3.fsf@Kagami.home> (Ian Price's message of "Mon, 09 Jul 2012 13:29:16 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) X-Pobox-Relay-ID: FFE4975E-85C5-11E2-9CD8-59240E5B5709-02397024!a-pb-sasl-quonix.pobox.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.bugs:6837 Archived-At: Hi Ian, On Mon 09 Jul 2012 14:29, Ian Price writes: > PARSE ERROR ("+InF.0" +inf.0 "+inf.0" "+Inf.0") =3D> #f > PARSE ERROR ("-iNF.0" -inf.0 "-inf.0" "-Inf.0") =3D> #f > PARSE ERROR ("+NAN.0" +nan.0 "+nan.0" "+NaN.0") =3D> #f These are not errors. +NAN.0 is not even not a number :) > PARSE ERROR ("+nan.1" #f) =3D> +nan.0 > PARSE ERROR ("+nan.01" #f) =3D> +nan.0 These are only supported because 2.0.0 was released with +nan.1 parsing as +nan.0. It signals a deprecation warning with a note to this effect. Guile from master should pass these particular tests. > PARSE ERROR ("nan.0" #f) =3D> +nan.0 > PARSE ERROR ("inf.0" #f) =3D> +inf.0 > PARSE ERROR ("#e+nan.0" #f) =3D> +nan.0 > PARSE ERROR ("#e+inf.0" #f) =3D> +inf.0 > PARSE ERROR ("#e-inf.0" #f) =3D> -inf.0 These are errors. > If the number contains a division by zero, we get a numerical overflow > error. > > scheme@(guile=E2=88=92user)> (string->number "3/0") > ERROR: In procedure string=E2=88=92>number: > ERROR: Throw to key `numerical=E2=88=92overflow' with args `("make=E2=88= =92ratio" "Numerical overflow" #f #f)'. This is also an error. We should plumb through some extra arg to mem2ureal, I guess, to check for a zero denominator. Andy --=20 http://wingolog.org/