From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.bugs Subject: bug#19180: guile bug#19180: vacuum_weak_hash_table error Date: Wed, 22 Jun 2016 16:55:38 +0200 Message-ID: <87twgls26t.fsf@pobox.com> References: <87k322bi46.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1466607396 5367 80.91.229.3 (22 Jun 2016 14:56:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 22 Jun 2016 14:56:36 +0000 (UTC) Cc: 19180@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= , Linas Vepstas To: Anand Mohanadoss Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Wed Jun 22 16:56:24 2016 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bFjZk-0002yT-5Z for guile-bugs@m.gmane.org; Wed, 22 Jun 2016 16:56:20 +0200 Original-Received: from localhost ([::1]:58914 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFjZd-0004Zj-QZ for guile-bugs@m.gmane.org; Wed, 22 Jun 2016 10:56:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59267) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFjZW-0004ZG-L5 for bug-guile@gnu.org; Wed, 22 Jun 2016 10:56:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFjZS-00043J-H8 for bug-guile@gnu.org; Wed, 22 Jun 2016 10:56:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38946) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFjZS-00043F-DD for bug-guile@gnu.org; Wed, 22 Jun 2016 10:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bFjZS-0004jt-5F for bug-guile@gnu.org; Wed, 22 Jun 2016 10:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andy Wingo Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Wed, 22 Jun 2016 14:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19180 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Original-Received: via spool by 19180-submit@debbugs.gnu.org id=B19180.146660734818196 (code B ref 19180); Wed, 22 Jun 2016 14:56:02 +0000 Original-Received: (at 19180) by debbugs.gnu.org; 22 Jun 2016 14:55:48 +0000 Original-Received: from localhost ([127.0.0.1]:51283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFjZE-0004jP-Jj for submit@debbugs.gnu.org; Wed, 22 Jun 2016 10:55:48 -0400 Original-Received: from pb-sasl2.pobox.com ([64.147.108.67]:55778 helo=sasl.smtp.pobox.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFjZD-0004jG-Fh for 19180@debbugs.gnu.org; Wed, 22 Jun 2016 10:55:48 -0400 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-sasl2.pobox.com (Postfix) with ESMTP id 2AD891F309; Wed, 22 Jun 2016 10:55:46 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=mjT+1Axc8OvHsRor7LviA0DUCic=; b=xeGWNw 9IWsSsKdyhgaIzJeYQPa1tD+HF+5HKTcsOZEp/POxfFpF2VJTHFPzJKsRxKeq8ph s5xPECTLYcip8XWNJmiobtCIP+GQ+ewoepubXFiKcDjYTRFfafZTulvocNbyulKK zhCk5eDwQD2u/6Q7oToiaH51mWT2Yrx2l59J4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=rzZBnoIFrLfpSrTfCabUrt80vFTWlaDS c4IAnDSLrut4W3VZgROZrXAbmDHcoHwq3HTk4Jf+eIkI9XglkU6En2DruRA5DXNJ RYuF5dMU09ORCXGCaRU6uoRIIlHLEtOukpWjTZ01MOmBaHXiRiJ0RoMlWMMjgIun LMgoajuAn2s= Original-Received: from pb-sasl2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-sasl2.pobox.com (Postfix) with ESMTP id 23F871F308; Wed, 22 Jun 2016 10:55:46 -0400 (EDT) Original-Received: from clucks (unknown [88.160.190.192]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-sasl2.pobox.com (Postfix) with ESMTPSA id 40BC11F307; Wed, 22 Jun 2016 10:55:45 -0400 (EDT) In-Reply-To: (Anand Mohanadoss's message of "Mon, 15 Dec 2014 12:06:44 +0530") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-Pobox-Relay-ID: 66124F3E-3889-11E6-ACDD-28A6F1301B6D-02397024!pb-sasl2.pobox.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:8127 Archived-At: Hi :) On Mon 15 Dec 2014 07:36, Anand Mohanadoss writes: > Here is what we changed in hashtab.c - > > 130a131 >> size_t orig_len = len; > 137,138c138,144 > < assert (removed <= len); > < len -= removed; > --- >> if (removed <= len) >> len -= removed; >> else >> { >> printf ("Vacuum weak hash table assert Table=%p len=%zi removed=%zi > orig_len=%zi n_items=%zi\n", table, len, removed, orig_len, > SCM_HASHTABLE_N_ITEMS (table)); >> len = 0; >> } > > With this change, we got lines similar to the following printed > periodically - > > Vacuum weak hash table assert Table=0x9bdb840 len=0 removed=1 > orig_len=2321 n_items=2321 I guess printing a warning is not worse than crashing. I was unable to make this table work in a reliable way in 2.0 without rewriting it, so in 2.2 there's a new implementation with hopefully no bug in this regard. Ludovic what do you thing, should we just be sloppy in 2.0 and remove the assertion? I don't think it's fixable. The other option I see is to close as WONTFIX. Andy