From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Newsgroups: gmane.lisp.guile.bugs Subject: bug#19540: repeated ./././ in compiled modules Date: Fri, 24 Jun 2016 10:28:41 +0200 Message-ID: <87twgj9eiu.fsf@gnu.org> References: <188846A3-246A-49DB-95F0-37FEE6903C85@alumni.caltech.edu> <877fwiy0q2.fsf@gnu.org> <093940B7-4480-4FD4-A0AD-0B19B6FEECDB@alumni.caltech.edu> <87iog117is.fsf@gnu.org> <871t3oqp2e.fsf@pobox.com> <87k2hgoy0c.fsf@gnu.org> <87fus3opto.fsf@pobox.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1466757492 17279 80.91.229.3 (24 Jun 2016 08:38:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 24 Jun 2016 08:38:12 +0000 (UTC) Cc: 19540-done@debbugs.gnu.org, Matt Wette To: Andy Wingo Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Fri Jun 24 10:38:00 2016 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bGMce-0007hQ-Na for guile-bugs@m.gmane.org; Fri, 24 Jun 2016 10:37:56 +0200 Original-Received: from localhost ([::1]:41922 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGMcY-0006ws-Qg for guile-bugs@m.gmane.org; Fri, 24 Jun 2016 04:37:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGMU5-0006Px-7j for bug-guile@gnu.org; Fri, 24 Jun 2016 04:29:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGMU3-0005qZ-4P for bug-guile@gnu.org; Fri, 24 Jun 2016 04:29:04 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41020) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGMU3-0005qK-0H for bug-guile@gnu.org; Fri, 24 Jun 2016 04:29:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bGMU2-0001w3-SW for bug-guile@gnu.org; Fri, 24 Jun 2016 04:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Fri, 24 Jun 2016 08:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19540 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Original-Received: via spool by 19540-done@debbugs.gnu.org id=D19540.14667569357417 (code D ref 19540); Fri, 24 Jun 2016 08:29:02 +0000 Original-Received: (at 19540-done) by debbugs.gnu.org; 24 Jun 2016 08:28:55 +0000 Original-Received: from localhost ([127.0.0.1]:53356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bGMTv-0001vZ-7E for submit@debbugs.gnu.org; Fri, 24 Jun 2016 04:28:55 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bGMTu-0001vK-0Q for 19540-done@debbugs.gnu.org; Fri, 24 Jun 2016 04:28:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGMTk-0005fY-So for 19540-done@debbugs.gnu.org; Fri, 24 Jun 2016 04:28:48 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGMTk-0005fT-PT; Fri, 24 Jun 2016 04:28:44 -0400 Original-Received: from pluto.bordeaux.inria.fr ([193.50.110.57]:47624 helo=pluto) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bGMTj-0006NL-SV; Fri, 24 Jun 2016 04:28:44 -0400 X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 7 Messidor an 224 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu In-Reply-To: <87fus3opto.fsf@pobox.com> (Andy Wingo's message of "Thu, 23 Jun 2016 18:03:15 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:8210 Archived-At: Hello! Andy Wingo skribis: > On Thu 23 Jun 2016 15:06, ludo@gnu.org (Ludovic Court=C3=A8s) writes: > >> Andy Wingo skribis: >> >>> commit 9a951678713557b548415d32eae6d63d039bf652 >>> Author: Andy Wingo >>> Date: Thu Jun 23 10:03:10 2016 +0200 >>> >>> Fix relative file name canonicalization on paths with "." >>>=20=20=20=20=20 >>> * libguile/filesys.c (scm_i_relativize_path): Canonicalize the file >>> names elements that we will be using as prefixes. Fixes the case >>> where a load path contains a relative file name: #19540. >>> * test-suite/tests/ports.test ("%file-port-name-canonicalization"):= Add >>> tests that elements of the load path are canonicalized. >>> >> =E2=80=98canonicalize_file_name=E2=80=99 is costly: roughly one syscall = per file name >> component. >> >> IIUC, =E2=80=98canonicalize_file_name=E2=80=99 is now called once for ea= ch =E2=80=98%load-path=E2=80=99 >> entry and file name that we canonicalize. Is this correct? > > That's correct, but only for relative canonicalization, which is in > practive only when loading Scheme files from source. Seems out of the > hot path; what do you think? I think it=E2=80=99s likely to have a noticeable impact on startup time for projects with a large number of modules like Guix. For instance, commands like =E2=80=98guix package -A=E2=80=99 or =E2=80=98g= uix build foo=E2=80=99 load all the modules. The impact will be smaller on a laptop with an SSD than on an NFS mount, where it=E2=80=99s likely going to be terrrible (this could be tested using the =E2=80=98delay=E2=80=99 device mapper.) WDYT? Ludo=E2=80=99.