From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark H Weaver Newsgroups: gmane.lisp.guile.bugs Subject: bug#30020: floating point unboxing regression in 2.2.3 Date: Mon, 11 Jun 2018 10:26:50 -0400 Message-ID: <87tvq9761h.fsf@netris.org> References: <87lgc4xpu6.fsf@netris.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1528728015 20847 195.159.176.226 (11 Jun 2018 14:40:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 11 Jun 2018 14:40:15 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 30020-done@debbugs.gnu.org To: "Thompson\, David" Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Mon Jun 11 16:40:11 2018 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSNzK-0005Ga-Gv for guile-bugs@m.gmane.org; Mon, 11 Jun 2018 16:40:06 +0200 Original-Received: from localhost ([::1]:49249 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSO1R-0000Ie-HN for guile-bugs@m.gmane.org; Mon, 11 Jun 2018 10:42:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53983) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSNof-0006dv-Sk for bug-guile@gnu.org; Mon, 11 Jun 2018 10:29:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSNoc-0003LR-Ol for bug-guile@gnu.org; Mon, 11 Jun 2018 10:29:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35626) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fSNoc-0003L0-KQ for bug-guile@gnu.org; Mon, 11 Jun 2018 10:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fSNoc-0000LU-97 for bug-guile@gnu.org; Mon, 11 Jun 2018 10:29:02 -0400 Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-To: bug-guile@gnu.org Resent-Date: Mon, 11 Jun 2018 14:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 30020 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Mail-Followup-To: 30020@debbugs.gnu.org, mhw@netris.org, dthompson2@worcester.edu Original-Received: via spool by 30020-done@debbugs.gnu.org id=D30020.15287272981272 (code D ref 30020); Mon, 11 Jun 2018 14:29:02 +0000 Original-Received: (at 30020-done) by debbugs.gnu.org; 11 Jun 2018 14:28:18 +0000 Original-Received: from localhost ([127.0.0.1]:43521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSNnu-0000KS-GK for submit@debbugs.gnu.org; Mon, 11 Jun 2018 10:28:18 -0400 Original-Received: from world.peace.net ([64.112.178.59]:42528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSNns-0000KE-Az for 30020-done@debbugs.gnu.org; Mon, 11 Jun 2018 10:28:16 -0400 Original-Received: from mhw by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fSNnk-0004Cw-Ve; Mon, 11 Jun 2018 10:28:09 -0400 In-Reply-To: <87lgc4xpu6.fsf@netris.org> (Mark H. Weaver's message of "Mon, 28 May 2018 02:21:37 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:9059 Archived-At: Mark H Weaver writes: > I did the moral equivalent of a git bisect, and found the culprit: > > commit d4883307ca64a7028b9a6cd072974437306c19d3 > Author: Andy Wingo > Date: Thu Nov 30 10:41:45 2017 +0100 > > Minor CSE run-time optimization > > * module/language/cps/cse.scm (compute-equivalent-subexpressions): Minor > optimization to reduce the size of equivalent expression keys, and to > avoid some work if an expression has no key. > > Fortunately, this commit can be reverted in isolation without any > difficulty, and apparently without any negative consequences. If a > better solution isn't found soon, perhaps that's what we should do. I pushed commit df93752479ab88446f5db4b1d6ebf53a85c7593f to the stable-2.2 branch, which reverts the above commit. I'm closing this bug, but feel free to reopen if there are still issues to resolve. Thanks, Mark